fix(metadata): upgrade script keep operation name (#5109)

soyuka · WilliamPeralta · soyuka · commit 176fff2cb15e · 2022-11-04T18:31:14.000+01:00
origin: #5105 Co-authored-by: WilliamPeralta <william.peralta18@gmail.com>
diff --git a/src/Core/Upgrade/UpgradeApiResourceVisitor.php b/src/Core/Upgrade/UpgradeApiResourceVisitor.php
@@ -359,8 +359,8 @@ private function removeAttribute(Node\Stmt\Class_|Node\Stmt\Interface_ $node)
             }
         }
         foreach ($node->stmts as $k => $stmts) {
-            foreach ($stmts->attrGroups as $i => $attrGroups) {
-                foreach ($attrGroups->attrs as $j => $attrs) {
+            foreach ($stmts->attrGroups ?? [] as $i => $attrGroups) {
+                foreach ($attrGroups->attrs ?? [] as $j => $attrs) {
                     if (str_ends_with(implode('\\', $attrs->name->parts), 'ApiSubresource')) {
                         unset($node->stmts[$k]->attrGroups[$i]);
                         break;
@@ -443,6 +443,9 @@ private function legacyOperationsToOperations($legacyOperations, bool $isCollect
 
             $method = $operation['method'] ?? strtoupper($operationName);
             unset($operation['method']);
+            if (!isset($operation['path']) && !\in_array($operationName, ['get', 'post', 'put', 'patch', 'delete'], true)) {
+                $operation['name'] = $operationName;
+            }
             $operations[] = $this->createOperation($this->getOperationNamespace($method, $isCollection), $operation);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -359,8 +359,8 @@ private function removeAttribute(Node\Stmt\Class_\|Node\Stmt\Interface_ $node)`
`359`	`359`	`}`
`360`	`360`	`}`
`361`	`361`	`foreach ($node->stmts as $k => $stmts) {`
`362`		`- foreach ($stmts->attrGroups as $i => $attrGroups) {`
`363`		`- foreach ($attrGroups->attrs as $j => $attrs) {`
	`362`	`+ foreach ($stmts->attrGroups ?? [] as $i => $attrGroups) {`
	`363`	`+ foreach ($attrGroups->attrs ?? [] as $j => $attrs) {`
`364`	`364`	`if (str_ends_with(implode('\\', $attrs->name->parts), 'ApiSubresource')) {`
`365`	`365`	`unset($node->stmts[$k]->attrGroups[$i]);`
`366`	`366`	`break;`
`@@ -443,6 +443,9 @@ private function legacyOperationsToOperations($legacyOperations, bool $isCollect`
`443`	`443`
`444`	`444`	`$method = $operation['method'] ?? strtoupper($operationName);`
`445`	`445`	`unset($operation['method']);`
	`446`	`+ if (!isset($operation['path']) && !\in_array($operationName, ['get', 'post', 'put', 'patch', 'delete'], true)) {`
	`447`	`+ $operation['name'] = $operationName;`
	`448`	`+ }`
`446`	`449`	`$operations[] = $this->createOperation($this->getOperationNamespace($method, $isCollection), $operation);`
`447`	`450`	`}`
`448`	`451`