fix(jsonschema): remove @id @type @context from input schema (#5267)

benblub · web-flow · commit 7f09a2640c41 · 2022-12-16T08:35:07.000+01:00
* do not add linked data for denormationContext If I look in the generated schema for denormalizationContext i can see the required fields for '@id' and '@type'. Why do have this fields required for write operations? We don't need to pass this fields in a write request. If you used this schema on the client with typescript you need to write workarounds because you not sending this fields in the requests. See #5263 * remove whitespace * change format to output * restore old test except output type and add test for input
diff --git a/src/Hydra/JsonSchema/SchemaFactory.php b/src/Hydra/JsonSchema/SchemaFactory.php
@@ -72,6 +72,10 @@ public function buildSchema(string $className, string $format = 'jsonld', string
             return $schema;
         }
 
+        if ('input' === $type) {
+            return $schema;
+        }
+
         $definitions = $schema->getDefinitions();
         if ($key = $schema->getRootDefinitionKey()) {
             $definitions[$key]['properties'] = self::BASE_ROOT_PROPS + ($definitions[$key]['properties'] ?? []);
diff --git a/tests/JsonSchema/Command/JsonSchemaGenerateCommandTest.php b/tests/JsonSchema/Command/JsonSchemaGenerateCommandTest.php
@@ -63,11 +63,21 @@ public function testExecuteWithCollectionOperationGet(): void
 
     public function testExecuteWithJsonldFormatOption(): void
     {
-        $this->tester->run(['command' => 'api:json-schema:generate', 'resource' => $this->entityClass, '--operation' => '_api_/dummies{._format}_post', '--format' => 'jsonld']);
+        $this->tester->run(['command' => 'api:json-schema:generate', 'resource' => $this->entityClass, '--operation' => '_api_/dummies{._format}_post', '--format' => 'jsonld', '--type' => 'output']);
         $result = $this->tester->getDisplay();
 
         $this->assertStringContainsString('@id', $result);
         $this->assertStringContainsString('@context', $result);
         $this->assertStringContainsString('@type', $result);
     }
+
+    public function testExecuteWithJsonldTypeInput(): void
+    {
+        $this->tester->run(['command' => 'api:json-schema:generate', 'resource' => $this->entityClass, '--operation' => '_api_/dummies{._format}_post', '--format' => 'jsonld', '--type' => 'input']);
+        $result = $this->tester->getDisplay();
+
+        $this->assertStringNotContainsString('@id', $result);
+        $this->assertStringNotContainsString('@context', $result);
+        $this->assertStringNotContainsString('@type', $result);
+    }
 }
