fix(symfony): use Type constraint violation code instead of exception code

soyuka · soyuka · commit f75649d49139 · 2023-12-23T09:31:52.000+01:00
diff --git a/features/main/validation.feature b/features/main/validation.feature
@@ -119,40 +119,40 @@ Feature: Using validations groups
         {
           "propertyPath": "",
           "message": "This value should be of type unknown.",
-          "code": "0",
+          "code": "ba785a8c-82cb-4283-967c-3cf342181b40",
           "hint": "Failed to create object because the class misses the \"baz\" property."
         },
         {
           "propertyPath": "qux",
           "message": "This value should be of type string.",
-          "code": "0"
+          "code": "ba785a8c-82cb-4283-967c-3cf342181b40"
         },
         {
           "propertyPath": "foo",
           "message": "This value should be of type bool.",
-          "code": "0"
+          "code": "ba785a8c-82cb-4283-967c-3cf342181b40"
         },
         {
           "propertyPath": "bar",
           "message": "This value should be of type int.",
-          "code": "0"
+          "code": "ba785a8c-82cb-4283-967c-3cf342181b40"
         },
         {
           "propertyPath": "uuid",
           "message": "This value should be of type uuid.",
-          "code": "0",
+          "code": "ba785a8c-82cb-4283-967c-3cf342181b40",
           "hint": "Invalid UUID string: y"
         },
         {
           "propertyPath": "relatedDummy",
           "message": "This value should be of type array|string.",
-          "code": "0",
+          "code": "ba785a8c-82cb-4283-967c-3cf342181b40",
           "hint": "The type of the \"relatedDummy\" attribute must be \"array\" (nested document) or \"string\" (IRI), \"integer\" given."
         },
         {
           "propertyPath": "relatedDummies",
           "message": "This value should be of type array.",
-          "code": "0"
+          "code": "ba785a8c-82cb-4283-967c-3cf342181b40"
         }
       ]
     }
diff --git a/src/State/Provider/DeserializeProvider.php b/src/State/Provider/DeserializeProvider.php
@@ -97,7 +97,7 @@ public function provide(Operation $operation, array $uriVariables = [], array $c
                 if ($exception->canUseMessageForUser()) {
                     $parameters['hint'] = $exception->getMessage();
                 }
-                $violations->add(new ConstraintViolation($this->translator->trans($message, ['{{ type }}' => implode('|', $exception->getExpectedTypes() ?? [])], 'validators'), $message, $parameters, null, $exception->getPath(), null, null, (string) $exception->getCode()));
+                $violations->add(new ConstraintViolation($this->translator->trans($message, ['{{ type }}' => implode('|', $exception->getExpectedTypes() ?? [])], 'validators'), $message, $parameters, null, $exception->getPath(), null, null, (string) Type::INVALID_TYPE_ERROR));
             }
             if (0 !== \count($violations)) {
                 throw new ValidationException($violations);
diff --git a/src/Symfony/EventListener/DeserializeListener.php b/src/Symfony/EventListener/DeserializeListener.php
@@ -115,7 +115,7 @@ public function onKernelRequest(RequestEvent $event): void
                 if ($exception->canUseMessageForUser()) {
                     $parameters['hint'] = $exception->getMessage();
                 }
-                $violations->add(new ConstraintViolation($this->translator->trans($message, ['{{ type }}' => implode('|', $exception->getExpectedTypes() ?? [])], 'validators'), $message, $parameters, null, $exception->getPath(), null, null, (string) $exception->getCode()));
+                $violations->add(new ConstraintViolation($this->translator->trans($message, ['{{ type }}' => implode('|', $exception->getExpectedTypes() ?? [])], 'validators'), $message, $parameters, null, $exception->getPath(), null, null, Type::INVALID_TYPE_ERROR));
             }
             if (0 !== \count($violations)) {
                 throw new ValidationException($violations);
diff --git a/tests/Symfony/EventListener/DeserializeListenerTest.php b/tests/Symfony/EventListener/DeserializeListenerTest.php
@@ -366,7 +366,7 @@ public function testTurnPartialDenormalizationExceptionIntoValidationException()
             $this->assertSame($violation->getPropertyPath(), 'foo');
             $this->assertNull($violation->getInvalidValue());
             $this->assertNull($violation->getPlural());
-            $this->assertSame($violation->getCode(), '0');
+            $this->assertSame($violation->getCode(), 'ba785a8c-82cb-4283-967c-3cf342181b40');
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -119,40 +119,40 @@ Feature: Using validations groups`
`119`	`119`	`{`
`120`	`120`	`"propertyPath": "",`
`121`	`121`	`"message": "This value should be of type unknown.",`
`122`		`- "code": "0",`
	`122`	`+ "code": "ba785a8c-82cb-4283-967c-3cf342181b40",`
`123`	`123`	`"hint": "Failed to create object because the class misses the \"baz\" property."`
`124`	`124`	`},`
`125`	`125`	`{`
`126`	`126`	`"propertyPath": "qux",`
`127`	`127`	`"message": "This value should be of type string.",`
`128`		`- "code": "0"`
	`128`	`+ "code": "ba785a8c-82cb-4283-967c-3cf342181b40"`
`129`	`129`	`},`
`130`	`130`	`{`
`131`	`131`	`"propertyPath": "foo",`
`132`	`132`	`"message": "This value should be of type bool.",`
`133`		`- "code": "0"`
	`133`	`+ "code": "ba785a8c-82cb-4283-967c-3cf342181b40"`
`134`	`134`	`},`
`135`	`135`	`{`
`136`	`136`	`"propertyPath": "bar",`
`137`	`137`	`"message": "This value should be of type int.",`
`138`		`- "code": "0"`
	`138`	`+ "code": "ba785a8c-82cb-4283-967c-3cf342181b40"`
`139`	`139`	`},`
`140`	`140`	`{`
`141`	`141`	`"propertyPath": "uuid",`
`142`	`142`	`"message": "This value should be of type uuid.",`
`143`		`- "code": "0",`
	`143`	`+ "code": "ba785a8c-82cb-4283-967c-3cf342181b40",`
`144`	`144`	`"hint": "Invalid UUID string: y"`
`145`	`145`	`},`
`146`	`146`	`{`
`147`	`147`	`"propertyPath": "relatedDummy",`
`148`	`148`	`"message": "This value should be of type array\|string.",`
`149`		`- "code": "0",`
	`149`	`+ "code": "ba785a8c-82cb-4283-967c-3cf342181b40",`
`150`	`150`	`"hint": "The type of the \"relatedDummy\" attribute must be \"array\" (nested document) or \"string\" (IRI), \"integer\" given."`
`151`	`151`	`},`
`152`	`152`	`{`
`153`	`153`	`"propertyPath": "relatedDummies",`
`154`	`154`	`"message": "This value should be of type array.",`
`155`		`- "code": "0"`
	`155`	`+ "code": "ba785a8c-82cb-4283-967c-3cf342181b40"`
`156`	`156`	`}`
`157`	`157`	`]`
`158`	`158`	`}`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ public function provide(Operation $operation, array $uriVariables = [], array $c`
`97`	`97`	`if ($exception->canUseMessageForUser()) {`
`98`	`98`	`$parameters['hint'] = $exception->getMessage();`
`99`	`99`	`}`
`100`		`- $violations->add(new ConstraintViolation($this->translator->trans($message, ['{{ type }}' => implode('\|', $exception->getExpectedTypes() ?? [])], 'validators'), $message, $parameters, null, $exception->getPath(), null, null, (string) $exception->getCode()));`
	`100`	`+ $violations->add(new ConstraintViolation($this->translator->trans($message, ['{{ type }}' => implode('\|', $exception->getExpectedTypes() ?? [])], 'validators'), $message, $parameters, null, $exception->getPath(), null, null, (string) Type::INVALID_TYPE_ERROR));`
`101`	`101`	`}`
`102`	`102`	`if (0 !== \count($violations)) {`
`103`	`103`	`throw new ValidationException($violations);`
Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ public function onKernelRequest(RequestEvent $event): void`
`115`	`115`	`if ($exception->canUseMessageForUser()) {`
`116`	`116`	`$parameters['hint'] = $exception->getMessage();`
`117`	`117`	`}`
`118`		`- $violations->add(new ConstraintViolation($this->translator->trans($message, ['{{ type }}' => implode('\|', $exception->getExpectedTypes() ?? [])], 'validators'), $message, $parameters, null, $exception->getPath(), null, null, (string) $exception->getCode()));`
	`118`	`+ $violations->add(new ConstraintViolation($this->translator->trans($message, ['{{ type }}' => implode('\|', $exception->getExpectedTypes() ?? [])], 'validators'), $message, $parameters, null, $exception->getPath(), null, null, Type::INVALID_TYPE_ERROR));`
`119`	`119`	`}`
`120`	`120`	`if (0 !== \count($violations)) {`
`121`	`121`	`throw new ValidationException($violations);`
Original file line number	Diff line number	Diff line change
`@@ -366,7 +366,7 @@ public function testTurnPartialDenormalizationExceptionIntoValidationException()`
`366`	`366`	`$this->assertSame($violation->getPropertyPath(), 'foo');`
`367`	`367`	`$this->assertNull($violation->getInvalidValue());`
`368`	`368`	`$this->assertNull($violation->getPlural());`
`369`		`- $this->assertSame($violation->getCode(), '0');`
	`369`	`+ $this->assertSame($violation->getCode(), 'ba785a8c-82cb-4283-967c-3cf342181b40');`
`370`	`370`	`}`
`371`	`371`	`}`
`372`	`372`	`}`