Merge pull request #9145 from joew46167/master

facchinm · web-flow · commit c3fdb10244d4 · 2019-08-19T11:16:06.000+02:00
Add in accessibility support for screen readers in board and library managers
diff --git a/app/src/cc/arduino/contributions/libraries/ui/ContributedLibraryTableCellJPanel.java b/app/src/cc/arduino/contributions/libraries/ui/ContributedLibraryTableCellJPanel.java
@@ -193,6 +193,8 @@ public ContributedLibraryTableCellJPanel(JTable parentTable, Object value,
 
     desc += "</body></html>";
     description.setText(desc);
+    // copy description to accessibility context for screen readers to use
+    description.getAccessibleContext().setAccessibleDescription(desc);
     description.setBackground(Color.WHITE);
 
     // for modelToView to work, the text area has to be sized. It doesn't
diff --git a/app/src/cc/arduino/contributions/packages/ui/ContributedPlatformTableCellJPanel.java b/app/src/cc/arduino/contributions/packages/ui/ContributedPlatformTableCellJPanel.java
@@ -230,6 +230,8 @@ void update(JTable parentTable, Object value, boolean isSelected,
 
     desc += "</body></html>";
     description.setText(desc);
+    // copy description to accessibility context for screen readers to use
+    description.getAccessibleContext().setAccessibleDescription(desc);
     description.setBackground(Color.WHITE);
 
     // for modelToView to work, the text area has to be sized. It doesn't
diff --git a/app/src/cc/arduino/contributions/ui/ProgressJProgressBar.java b/app/src/cc/arduino/contributions/ui/ProgressJProgressBar.java
@@ -38,8 +38,13 @@ public class ProgressJProgressBar extends JProgressBar {
 
   public void setValue(Progress p) {
     setValue((int) p.getProgress());
-    if (p.getStatus() != null)
+    if (p.getStatus() != null) {
       setString(p.getStatus());
+      // copy status to accessibility context for screen readers to use
+      getAccessibleContext().setAccessibleDescription(p.getStatus());
+      // make status focusable so screen readers can get to it
+      setFocusable(true);
+    }
   }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,13 @@ public class ProgressJProgressBar extends JProgressBar {`
`38`	`38`
`39`	`39`	`public void setValue(Progress p) {`
`40`	`40`	`setValue((int) p.getProgress());`
`41`		`- if (p.getStatus() != null)`
	`41`	`+ if (p.getStatus() != null) {`
`42`	`42`	`setString(p.getStatus());`
	`43`	`+ // copy status to accessibility context for screen readers to use`
	`44`	`+ getAccessibleContext().setAccessibleDescription(p.getStatus());`
	`45`	`+ // make status focusable so screen readers can get to it`
	`46`	`+ setFocusable(true);`
	`47`	`+ }`
`43`	`48`	`}`
`44`	`49`
`45`	`50`	`}`