From 0c96cb55b8d08451885751d5ca55eaa59c8e40f1 Mon Sep 17 00:00:00 2001 From: ErnestoELC Date: Thu, 17 Jun 2021 15:53:48 +0200 Subject: [PATCH 01/37] add documents folders --- docs/api.md | 210 +++++++++++++++++++++++++++++++++++++++++++++++++ docs/readme.md | 18 +++++ 2 files changed, 228 insertions(+) create mode 100644 docs/api.md create mode 100644 docs/readme.md diff --git a/docs/api.md b/docs/api.md new file mode 100644 index 0000000..24e127f --- /dev/null +++ b/docs/api.md @@ -0,0 +1,210 @@ +# ArduinoMotorCarrier library + +## Methods + +### `BATTERY` + +Returns information about the battery connected to the carrier. + +#### Syntax + +``` +battery.getRaw() +battery.getConverted() +battery.getFiltered() +``` + +#### Returns + +* _getRaw()_: returns the raw ADC read from the battery as am integer. +* _getConverted()_: returns the battery voltage converted to volts as a floating point. +* _getFiltered()_: returns the battery voltage converted to volts and filtered in the last 10 seconds. + + +#### Example + +``` + +#include + +//Variable to store the battery voltage +float batteryVoltage; +... +void loop() { + batteryVoltage = battery.getRaw()/236.0; //236 for Nano, 77 for MKR. + Serial.print("Battery voltage: "); + Serial.print(batteryVoltage,3); + Serial.print("V, Raw "); + Serial.println(battery.getRaw()); + delay(5000); //wait for a few seconds +} +``` + +### `SERVO` + +Represent the servomotors available on the MotorCarrier. There are 4 headers for servomotors. + +#### Syntax + +``` +servo1.setAngle(int) +servo2.setAngle(int) +servo3.setAngle(int) +servo4.setAngle(int) +``` + +#### Function + +* _setAngle(int)_: Set the rotation angle (from 0 to 180) + + +### `MOTOR` + +There is 4 objects pointing to each possible motor: M1, M2, M3 and M4. + +#### Syntax + +```` +M1.setDuty(int) +M2.setDuty(int) +M3.setDuty(int) +M4.setDuty(int) +```` + +#### Functions + +* _setDuty(int)_: Set the duty cycle of the dc motor (from -100 to +100) , 0 means stop. + + +### `ENCODER` + +Represents the 2 quadrature encoders embedded in the carrier board. The two objects are encoder1 and encoder2. + +#### Syntax + +```` +encoder1.getRawCount() +encoder2.resetCounter(); +```` + +#### Functions + +* _getRawCount()_: Returns the number of counts from start as an integer. +* _resetCounter(int)_: Resets counter to a certain value. + + +### `CONTROLLER` + +Represents the motor shield controller and exposes some high level functions. It also configures the battery charger (only on the NanoMotorCarrier) to start charging the battery. + +#### Syntax + +``` +controller.getFWVersion() +controller.reboot() +``` +### `PID` + +Allow setting Motor1 or Motor2 to a specific speed or position. There are two PID virtual objects in the controller: pid1 and pid2. pid1 acts on M1 and encoder1. pid2 acts on M2 and encoder2. It is advisable to control the motors using these functions. + +#### Syntax + +``` +pid1. setGains(int P, int I, int D) +``` + +#### Functions + +* _setGains(float P, float I, float D)_: Set PID gains. (`int` type for MKRMotorCarrier) +* _resetGains()_: Reset PID gains to factory default settings. +* _setControlMode(cl_control)_: Set control mode to either `CL_VELOCITY` or `CL_POSITION`. +* _setSetpoint(cl_mode, int target)_: Set a specific velocity or position in one of the motors. Define cl_mode as `TARGET_POSITION` or `TARGET_VELOCITY` and the desired value in target. + +#### Example + +Example for PID position control. + +``` +#include +#define INTERRUPT_PIN 6 + +//Variable to change the motor speed and direction +static int duty = 0; + +int target; +float P; +float I; +float D; + +void setup() +{ + //Serial port initialization + Serial.begin(115200); + while (!Serial); + + //Establishing the communication with the motor shield + if (controller.begin()) + { + Serial.print("MKR Motor Shield connected, firmware version "); + Serial.println(controller.getFWVersion()); + } + else + { + Serial.println("Couldn't connect! Is the red led blinking? You may need to update the firmware with FWUpdater sketch"); + while (1); + } + + // Reboot the motor controller; brings every value back to default + Serial.println("reboot"); + controller.reboot(); + delay(500); + + int dutyInit = 0; + M1.setDuty(dutyInit); + M2.setDuty(dutyInit); + M3.setDuty(dutyInit); + M4.setDuty(dutyInit); + Serial.print("Duty: "); + Serial.println(dutyInit); + + P = 0.07f;//0.07 //0.2 + I = 0.0f; + D = 0.007f; + + /************* PID 1 ***********************/ + + pid1.setControlMode(CL_POSITION); + + //pid1.resetGains(); + pid1.setGains(P, I, D); //Proportional(change) Integral(change) Derivative + Serial.print("P Gain: "); + Serial.println((float)pid1.getPgain()); + Serial.print("I Gain: "); + Serial.println((float)pid1.getIgain()); + Serial.print("D Gain: "); + Serial.println((float)pid1.getDgain(), 7); + Serial.println(""); + + encoder1.resetCounter(0); + Serial.print("encoder1: "); + Serial.println(encoder1.getRawCount()); + target = 5000; + pid1.setSetpoint(TARGET_POSITION, target); +} + +void loop() { + + Serial.print("encoder1: "); + Serial.print(encoder1.getRawCount()); + Serial.print(" target: "); + Serial.println(target); + if (encoder1.getRawCount() == target) { + target += 1000; + Serial.print("Target reached: Setting new target.."); + pid1.setSetpoint(TARGET_POSITION, target); + //delay(5000); + } + + delay(50); +} +``` diff --git a/docs/readme.md b/docs/readme.md new file mode 100644 index 0000000..8960d73 --- /dev/null +++ b/docs/readme.md @@ -0,0 +1,18 @@ +# ArduinoMotorCarrier library + + +This library allows you to use both the Arduino Nano Motor Carrier and the MKR Motor Carrier. The carrier supports inputs for servo motors, dc motors, and encoders, and can read the battery voltage level. This library, therefore, has functions and creates objects to support such hardware. In addition, the library supports PID control for position and velocity. Note that not all hardware features are supported in both carriers so take a look at the specifications for each board. You don't need to initiate any objects manually, they are automatically created when you include "ArduinoMotorCarrier.h" + +To use this library: + +``` +#include +``` + +## Circuit + +Connect the carrier to the main compatible board (MKR1010 or Nano 33 IoT), connect the LiPo battery, turn the switch on and connect the board to the computer using a micro USB cable. You can also connect the motors that you need for your project (servo or DC w/ or w/o encoders). + +## Examples + +* [Battery Read](https://docs.arduino.cc/tutorials/mkr-motor-carrier/mkr-motor-carrier-battery): Reading the battery level with the MKR Motor Carrier. From 5dd1e202924dfe93b1aa6537cdcca37609156fec Mon Sep 17 00:00:00 2001 From: Ali Jahangiri <75624145+aliphys@users.noreply.github.com> Date: Fri, 23 Jul 2021 09:17:08 +0200 Subject: [PATCH 02/37] Rename folders --- examples/{Flasher => Firmware}/Flasher.ino | 0 examples/{Flasher => Firmware}/fw_mkr.h | 0 examples/{Flasher => Firmware}/fw_nano.h | 0 .../Motor_test/CP3-SC1-GE3-PH.png | Bin .../Motor_test/Motor_test.ino | 0 .../Motor_test_encoder/CP3-SC1-GE3-PH.png | Bin .../Motor_test_encoder/Motor_test_encoder.ino | 0 .../Servo_test/CP3-SC2-GE3-IL.png | Bin .../Servo_test/Servo_test.ino | 0 examples/{MKR => MKRMotorCarrier}/Test/Test.ino | 0 .../Battery_Charging/Battery_Charging.ino | 0 .../DCMotorTest/DCMotorTest.ino | 0 .../EncoderTest/EncoderTest.ino | 0 .../IMU_Test/IMU_Test.ino | 0 .../PID_Position_test/PID_Position_test.ino | 0 .../ServoTest/ServoTest.ino | 0 16 files changed, 0 insertions(+), 0 deletions(-) rename examples/{Flasher => Firmware}/Flasher.ino (100%) rename examples/{Flasher => Firmware}/fw_mkr.h (100%) rename examples/{Flasher => Firmware}/fw_nano.h (100%) rename examples/{MKR => MKRMotorCarrier}/Motor_test/CP3-SC1-GE3-PH.png (100%) rename examples/{MKR => MKRMotorCarrier}/Motor_test/Motor_test.ino (100%) rename examples/{MKR => MKRMotorCarrier}/Motor_test_encoder/CP3-SC1-GE3-PH.png (100%) rename examples/{MKR => MKRMotorCarrier}/Motor_test_encoder/Motor_test_encoder.ino (100%) rename examples/{MKR => MKRMotorCarrier}/Servo_test/CP3-SC2-GE3-IL.png (100%) rename examples/{MKR => MKRMotorCarrier}/Servo_test/Servo_test.ino (100%) rename examples/{MKR => MKRMotorCarrier}/Test/Test.ino (100%) rename examples/{Nano => NanoMotorCarrier}/Battery_Charging/Battery_Charging.ino (100%) rename examples/{Nano => NanoMotorCarrier}/DCMotorTest/DCMotorTest.ino (100%) rename examples/{Nano => NanoMotorCarrier}/EncoderTest/EncoderTest.ino (100%) rename examples/{Nano => NanoMotorCarrier}/IMU_Test/IMU_Test.ino (100%) rename examples/{Nano => NanoMotorCarrier}/PID_Position_test/PID_Position_test.ino (100%) rename examples/{Nano => NanoMotorCarrier}/ServoTest/ServoTest.ino (100%) diff --git a/examples/Flasher/Flasher.ino b/examples/Firmware/Flasher.ino similarity index 100% rename from examples/Flasher/Flasher.ino rename to examples/Firmware/Flasher.ino diff --git a/examples/Flasher/fw_mkr.h b/examples/Firmware/fw_mkr.h similarity index 100% rename from examples/Flasher/fw_mkr.h rename to examples/Firmware/fw_mkr.h diff --git a/examples/Flasher/fw_nano.h b/examples/Firmware/fw_nano.h similarity index 100% rename from examples/Flasher/fw_nano.h rename to examples/Firmware/fw_nano.h diff --git a/examples/MKR/Motor_test/CP3-SC1-GE3-PH.png b/examples/MKRMotorCarrier/Motor_test/CP3-SC1-GE3-PH.png similarity index 100% rename from examples/MKR/Motor_test/CP3-SC1-GE3-PH.png rename to examples/MKRMotorCarrier/Motor_test/CP3-SC1-GE3-PH.png diff --git a/examples/MKR/Motor_test/Motor_test.ino b/examples/MKRMotorCarrier/Motor_test/Motor_test.ino similarity index 100% rename from examples/MKR/Motor_test/Motor_test.ino rename to examples/MKRMotorCarrier/Motor_test/Motor_test.ino diff --git a/examples/MKR/Motor_test_encoder/CP3-SC1-GE3-PH.png b/examples/MKRMotorCarrier/Motor_test_encoder/CP3-SC1-GE3-PH.png similarity index 100% rename from examples/MKR/Motor_test_encoder/CP3-SC1-GE3-PH.png rename to examples/MKRMotorCarrier/Motor_test_encoder/CP3-SC1-GE3-PH.png diff --git a/examples/MKR/Motor_test_encoder/Motor_test_encoder.ino b/examples/MKRMotorCarrier/Motor_test_encoder/Motor_test_encoder.ino similarity index 100% rename from examples/MKR/Motor_test_encoder/Motor_test_encoder.ino rename to examples/MKRMotorCarrier/Motor_test_encoder/Motor_test_encoder.ino diff --git a/examples/MKR/Servo_test/CP3-SC2-GE3-IL.png b/examples/MKRMotorCarrier/Servo_test/CP3-SC2-GE3-IL.png similarity index 100% rename from examples/MKR/Servo_test/CP3-SC2-GE3-IL.png rename to examples/MKRMotorCarrier/Servo_test/CP3-SC2-GE3-IL.png diff --git a/examples/MKR/Servo_test/Servo_test.ino b/examples/MKRMotorCarrier/Servo_test/Servo_test.ino similarity index 100% rename from examples/MKR/Servo_test/Servo_test.ino rename to examples/MKRMotorCarrier/Servo_test/Servo_test.ino diff --git a/examples/MKR/Test/Test.ino b/examples/MKRMotorCarrier/Test/Test.ino similarity index 100% rename from examples/MKR/Test/Test.ino rename to examples/MKRMotorCarrier/Test/Test.ino diff --git a/examples/Nano/Battery_Charging/Battery_Charging.ino b/examples/NanoMotorCarrier/Battery_Charging/Battery_Charging.ino similarity index 100% rename from examples/Nano/Battery_Charging/Battery_Charging.ino rename to examples/NanoMotorCarrier/Battery_Charging/Battery_Charging.ino diff --git a/examples/Nano/DCMotorTest/DCMotorTest.ino b/examples/NanoMotorCarrier/DCMotorTest/DCMotorTest.ino similarity index 100% rename from examples/Nano/DCMotorTest/DCMotorTest.ino rename to examples/NanoMotorCarrier/DCMotorTest/DCMotorTest.ino diff --git a/examples/Nano/EncoderTest/EncoderTest.ino b/examples/NanoMotorCarrier/EncoderTest/EncoderTest.ino similarity index 100% rename from examples/Nano/EncoderTest/EncoderTest.ino rename to examples/NanoMotorCarrier/EncoderTest/EncoderTest.ino diff --git a/examples/Nano/IMU_Test/IMU_Test.ino b/examples/NanoMotorCarrier/IMU_Test/IMU_Test.ino similarity index 100% rename from examples/Nano/IMU_Test/IMU_Test.ino rename to examples/NanoMotorCarrier/IMU_Test/IMU_Test.ino diff --git a/examples/Nano/PID_Position_test/PID_Position_test.ino b/examples/NanoMotorCarrier/PID_Position_test/PID_Position_test.ino similarity index 100% rename from examples/Nano/PID_Position_test/PID_Position_test.ino rename to examples/NanoMotorCarrier/PID_Position_test/PID_Position_test.ino diff --git a/examples/Nano/ServoTest/ServoTest.ino b/examples/NanoMotorCarrier/ServoTest/ServoTest.ino similarity index 100% rename from examples/Nano/ServoTest/ServoTest.ino rename to examples/NanoMotorCarrier/ServoTest/ServoTest.ino From 0898ed04fb031d8ee5f65f95d1eb6a1697971eff Mon Sep 17 00:00:00 2001 From: per1234 Date: Tue, 27 Jul 2021 01:40:34 -0700 Subject: [PATCH 03/37] Update sketch paths in "Compile Examples" CI workflow Due to the library having examples specific to the MKR and Nano boards, the CI workflow must be configured to compile only the examples of that board. The examples were moved after the time the workflow was written without updating the workflow, resulting in spurious workflow run failures as opposed to the legitimate failures caused by this library's various bugs. --- .github/workflows/compile-examples.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index 2d98522..004853e 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -94,9 +94,7 @@ jobs: libraries: | - sketch-paths: | - - examples/Motor_test - - examples/Motor_test_encoder - - examples/Servo_test + - examples/MKR steps: - name: Checkout repository @@ -114,7 +112,6 @@ jobs: ${{ matrix.libraries }} sketch-paths: | - examples/Flasher - - examples/Test ${{ matrix.sketch-paths }} enable-deltas-report: true sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }} From b73116877c4e4f6cea5a8e8be3b7e271ea4ec145 Mon Sep 17 00:00:00 2001 From: Ali Jahangiri <75624145+aliphys@users.noreply.github.com> Date: Wed, 28 Jul 2021 14:42:29 +0200 Subject: [PATCH 04/37] Revert folder name --- examples/{Firmware => Flasher}/Flasher.ino | 0 examples/{Firmware => Flasher}/fw_mkr.h | 0 examples/{Firmware => Flasher}/fw_nano.h | 0 3 files changed, 0 insertions(+), 0 deletions(-) rename examples/{Firmware => Flasher}/Flasher.ino (100%) rename examples/{Firmware => Flasher}/fw_mkr.h (100%) rename examples/{Firmware => Flasher}/fw_nano.h (100%) diff --git a/examples/Firmware/Flasher.ino b/examples/Flasher/Flasher.ino similarity index 100% rename from examples/Firmware/Flasher.ino rename to examples/Flasher/Flasher.ino diff --git a/examples/Firmware/fw_mkr.h b/examples/Flasher/fw_mkr.h similarity index 100% rename from examples/Firmware/fw_mkr.h rename to examples/Flasher/fw_mkr.h diff --git a/examples/Firmware/fw_nano.h b/examples/Flasher/fw_nano.h similarity index 100% rename from examples/Firmware/fw_nano.h rename to examples/Flasher/fw_nano.h From d5dec77f635c19717e19d7d768932ca96a90cc62 Mon Sep 17 00:00:00 2001 From: Ali Jahangiri <75624145+aliphys@users.noreply.github.com> Date: Wed, 28 Jul 2021 14:46:59 +0200 Subject: [PATCH 05/37] Update example paths --- .github/workflows/compile-examples.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index 2d98522..3916638 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -88,15 +88,13 @@ jobs: - name: BNO055 - name: Arduino_BQ24195 sketch-paths: | - - examples/Nano + - examples/NanoMotorCarrier - board: type: mkr libraries: | - sketch-paths: | - - examples/Motor_test - - examples/Motor_test_encoder - - examples/Servo_test + - examples/MKRMotorCarrier steps: - name: Checkout repository @@ -114,7 +112,7 @@ jobs: ${{ matrix.libraries }} sketch-paths: | - examples/Flasher - - examples/Test + - examples/MKRMotorCarrier/Test ${{ matrix.sketch-paths }} enable-deltas-report: true sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }} From 5ebecf81fd837320f4daad9844d38e00461e8c62 Mon Sep 17 00:00:00 2001 From: Ali Jahangiri <75624145+aliphys@users.noreply.github.com> Date: Fri, 30 Jul 2021 11:12:08 +0200 Subject: [PATCH 06/37] Remove test --- .github/workflows/compile-examples.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index db46ff1..4a660c3 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -113,7 +113,6 @@ jobs: ${{ matrix.libraries }} sketch-paths: | - examples/Flasher - - examples/MKRMotorCarrier/Test ${{ matrix.sketch-paths }} enable-deltas-report: true From cb2af4bc7bb826e0e39beca01c1d3cffa0b73482 Mon Sep 17 00:00:00 2001 From: Ali Jahangiri <75624145+aliphys@users.noreply.github.com> Date: Fri, 30 Jul 2021 17:06:13 +0200 Subject: [PATCH 07/37] pid1.setGains() needs float-compiles correctly now --- examples/MKRMotorCarrier/Test/Test.ino | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/MKRMotorCarrier/Test/Test.ino b/examples/MKRMotorCarrier/Test/Test.ino index 71e107d..a7e0af8 100644 --- a/examples/MKRMotorCarrier/Test/Test.ino +++ b/examples/MKRMotorCarrier/Test/Test.ino @@ -46,7 +46,7 @@ void setup() { // This way, you can program the motor to reach a certain position or velocity without any further intervention. // The PID can be carefully tuned if a particular profile is needed. pid1.setControlMode(CL_POSITION); - pid1.setGains(25, 0, 3); + pid1.setGains(25.0f, 0.0f, 3.0f); pid1.setMaxAcceleration(4000); pid1.setSetpoint(TARGET_POSITION, 5000); } From ca35c5403744315a0aff072d4f945317bf4a8796 Mon Sep 17 00:00:00 2001 From: per1234 Date: Wed, 22 Sep 2021 03:08:21 -0700 Subject: [PATCH 08/37] Correct library reference URL in metadata The library.properties `url` field provides a location for users to find information about the library. The automatically generated library reference pages are accessed via a URL based on the library `name` value converted to all lower case. Use of the real library name with upper case letters results in a 404. --- library.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library.properties b/library.properties index a15c549..9dcdb37 100644 --- a/library.properties +++ b/library.properties @@ -5,6 +5,6 @@ maintainer=Arduino sentence=Allows use of the Arduino Motor Carrier paragraph=(Nano and MKR version) category=Signal Input/Output -url=https://www.arduino.cc/reference/en/libraries/ArduinoMotorCarrier/ +url=https://www.arduino.cc/reference/en/libraries/arduinomotorcarrier/ architectures=samd includes=ArduinoMotorCarrier.h From fe6d4e2a6653578ab31d69b014ba21debdb7f360 Mon Sep 17 00:00:00 2001 From: Martino Facchin Date: Wed, 3 Nov 2021 15:24:40 +0100 Subject: [PATCH 09/37] Fix setGains() argument in example --- examples/MKR/Test/Test.ino | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/MKR/Test/Test.ino b/examples/MKR/Test/Test.ino index 71e107d..a7e0af8 100644 --- a/examples/MKR/Test/Test.ino +++ b/examples/MKR/Test/Test.ino @@ -46,7 +46,7 @@ void setup() { // This way, you can program the motor to reach a certain position or velocity without any further intervention. // The PID can be carefully tuned if a particular profile is needed. pid1.setControlMode(CL_POSITION); - pid1.setGains(25, 0, 3); + pid1.setGains(25.0f, 0.0f, 3.0f); pid1.setMaxAcceleration(4000); pid1.setSetpoint(TARGET_POSITION, 5000); } From f89b4162188dfb830ccf97da94ec9f6495b67700 Mon Sep 17 00:00:00 2001 From: Martino Facchin Date: Wed, 3 Nov 2021 15:24:53 +0100 Subject: [PATCH 10/37] Fix compilation for Portenta H7 --- src/Common.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Common.h b/src/Common.h index cdd374c..f31e330 100644 --- a/src/Common.h +++ b/src/Common.h @@ -14,6 +14,10 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#ifdef ARDUINO_PORTENTA_H7_M7 +#define RESET _RESET +#endif + enum Commands { GET_VERSION = 0x01, RESET, From 4b6096807f8fa9574b16bc0caeb9f5c7208552cd Mon Sep 17 00:00:00 2001 From: Ali Jahangiri <75624145+aliphys@users.noreply.github.com> Date: Thu, 2 Dec 2021 13:53:00 +0100 Subject: [PATCH 11/37] Remove interrupt statement --- examples/Nano/DCMotorTest/DCMotorTest.ino | 1 - examples/Nano/EncoderTest/EncoderTest.ino | 1 - examples/Nano/PID_Position_test/PID_Position_test.ino | 1 - examples/Nano/ServoTest/ServoTest.ino | 1 - 4 files changed, 4 deletions(-) diff --git a/examples/Nano/DCMotorTest/DCMotorTest.ino b/examples/Nano/DCMotorTest/DCMotorTest.ino index 9d517c2..a68122a 100644 --- a/examples/Nano/DCMotorTest/DCMotorTest.ino +++ b/examples/Nano/DCMotorTest/DCMotorTest.ino @@ -1,5 +1,4 @@ #include -#define INTERRUPT_PIN 6 //Variable to store the battery voltage static int batteryVoltage; diff --git a/examples/Nano/EncoderTest/EncoderTest.ino b/examples/Nano/EncoderTest/EncoderTest.ino index eef1c63..6b7697d 100644 --- a/examples/Nano/EncoderTest/EncoderTest.ino +++ b/examples/Nano/EncoderTest/EncoderTest.ino @@ -1,5 +1,4 @@ #include -#define INTERRUPT_PIN 6 //Variable to store the battery voltage static int batteryVoltage; diff --git a/examples/Nano/PID_Position_test/PID_Position_test.ino b/examples/Nano/PID_Position_test/PID_Position_test.ino index 3dc65f6..65b0399 100644 --- a/examples/Nano/PID_Position_test/PID_Position_test.ino +++ b/examples/Nano/PID_Position_test/PID_Position_test.ino @@ -1,6 +1,5 @@ #include //#include -#define INTERRUPT_PIN 6 //Variable to store the battery voltage static int batteryVoltage; diff --git a/examples/Nano/ServoTest/ServoTest.ino b/examples/Nano/ServoTest/ServoTest.ino index caf21fc..8f5477a 100644 --- a/examples/Nano/ServoTest/ServoTest.ino +++ b/examples/Nano/ServoTest/ServoTest.ino @@ -2,7 +2,6 @@ #include //#include //#include -#define INTERRUPT_PIN 6 void setup() From 15fa8df4a5f073b20667033e3b27e1dbd383f176 Mon Sep 17 00:00:00 2001 From: per1234 Date: Sun, 9 Jan 2022 23:50:31 -0800 Subject: [PATCH 12/37] Add GitHub Actions workflow to synchronize with shared repository labels (#47) On every push that changes relevant files, and periodically, configure the repository's issue and pull request labels according to the universal, shared, and local label configuration files. --- .github/dependabot.yml | 2 + .github/workflows/sync-labels.yml | 138 ++++++++++++++++++++++++++++++ 2 files changed, 140 insertions(+) create mode 100644 .github/workflows/sync-labels.yml diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 03600dd..fa738ec 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -8,3 +8,5 @@ updates: directory: / # Check the repository's workflows under /.github/workflows/ schedule: interval: daily + labels: + - "topic: infrastructure" diff --git a/.github/workflows/sync-labels.yml b/.github/workflows/sync-labels.yml new file mode 100644 index 0000000..3ee6feb --- /dev/null +++ b/.github/workflows/sync-labels.yml @@ -0,0 +1,138 @@ +# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/sync-labels.md +name: Sync Labels + +# See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows +on: + push: + paths: + - ".github/workflows/sync-labels.ya?ml" + - ".github/label-configuration-files/*.ya?ml" + pull_request: + paths: + - ".github/workflows/sync-labels.ya?ml" + - ".github/label-configuration-files/*.ya?ml" + schedule: + # Run daily at 8 AM UTC to sync with changes to shared label configurations. + - cron: "0 8 * * *" + workflow_dispatch: + repository_dispatch: + +env: + CONFIGURATIONS_FOLDER: .github/label-configuration-files + CONFIGURATIONS_ARTIFACT: label-configuration-files + +jobs: + check: + runs-on: ubuntu-latest + + steps: + - name: Checkout repository + uses: actions/checkout@v2 + + - name: Download JSON schema for labels configuration file + id: download-schema + uses: carlosperate/download-file-action@v1 + with: + file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/arduino-tooling-gh-label-configuration-schema.json + location: ${{ runner.temp }}/label-configuration-schema + + - name: Install JSON schema validator + run: | + sudo npm install \ + --global \ + ajv-cli \ + ajv-formats + + - name: Validate local labels configuration + run: | + # See: https://github.com/ajv-validator/ajv-cli#readme + ajv validate \ + --all-errors \ + -c ajv-formats \ + -s "${{ steps.download-schema.outputs.file-path }}" \ + -d "${{ env.CONFIGURATIONS_FOLDER }}/*.{yml,yaml}" + + download: + needs: check + runs-on: ubuntu-latest + + strategy: + matrix: + filename: + # Filenames of the shared configurations to apply to the repository in addition to the local configuration. + # https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/sync-labels + - universal.yml + + steps: + - name: Download + uses: carlosperate/download-file-action@v1 + with: + file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/${{ matrix.filename }} + + - name: Pass configuration files to next job via workflow artifact + uses: actions/upload-artifact@v2 + with: + path: | + *.yaml + *.yml + if-no-files-found: error + name: ${{ env.CONFIGURATIONS_ARTIFACT }} + + sync: + needs: download + runs-on: ubuntu-latest + + steps: + - name: Set environment variables + run: | + # See: https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable + echo "MERGED_CONFIGURATION_PATH=${{ runner.temp }}/labels.yml" >> "$GITHUB_ENV" + + - name: Determine whether to dry run + id: dry-run + if: > + github.event_name == 'pull_request' || + ( + ( + github.event_name == 'push' || + github.event_name == 'workflow_dispatch' + ) && + github.ref != format('refs/heads/{0}', github.event.repository.default_branch) + ) + run: | + # Use of this flag in the github-label-sync command will cause it to only check the validity of the + # configuration. + echo "::set-output name=flag::--dry-run" + + - name: Checkout repository + uses: actions/checkout@v2 + + - name: Download configuration files artifact + uses: actions/download-artifact@v2 + with: + name: ${{ env.CONFIGURATIONS_ARTIFACT }} + path: ${{ env.CONFIGURATIONS_FOLDER }} + + - name: Remove unneeded artifact + uses: geekyeggo/delete-artifact@v1 + with: + name: ${{ env.CONFIGURATIONS_ARTIFACT }} + + - name: Merge label configuration files + run: | + # Merge all configuration files + shopt -s extglob + cat "${{ env.CONFIGURATIONS_FOLDER }}"/*.@(yml|yaml) > "${{ env.MERGED_CONFIGURATION_PATH }}" + + - name: Install github-label-sync + run: sudo npm install --global github-label-sync + + - name: Sync labels + env: + GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }} + run: | + # See: https://github.com/Financial-Times/github-label-sync + github-label-sync \ + --labels "${{ env.MERGED_CONFIGURATION_PATH }}" \ + ${{ steps.dry-run.outputs.flag }} \ + ${{ github.repository }} From 27986a055286dd97a0498237a212f107604f6f56 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 1 Mar 2022 23:13:00 +0000 Subject: [PATCH 13/37] Bump actions/checkout from 2 to 3 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/check-arduino.yml | 2 +- .github/workflows/compile-bootloader.yml | 2 +- .github/workflows/compile-examples.yml | 2 +- .github/workflows/compile-firmware.yml | 2 +- .github/workflows/spell-check.yml | 2 +- .github/workflows/sync-labels.yml | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/check-arduino.yml b/.github/workflows/check-arduino.yml index 0d969f6..3e0d26c 100644 --- a/.github/workflows/check-arduino.yml +++ b/.github/workflows/check-arduino.yml @@ -16,7 +16,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Arduino Lint uses: arduino/arduino-lint-action@v1 diff --git a/.github/workflows/compile-bootloader.yml b/.github/workflows/compile-bootloader.yml index a5795f7..cba0ea0 100644 --- a/.github/workflows/compile-bootloader.yml +++ b/.github/workflows/compile-bootloader.yml @@ -43,7 +43,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Compile bootloader uses: arduino/compile-sketches@v1 diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index 004853e..7ff749c 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -98,7 +98,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Compile examples uses: arduino/compile-sketches@v1 diff --git a/.github/workflows/compile-firmware.yml b/.github/workflows/compile-firmware.yml index 512d8d9..0d6cb02 100644 --- a/.github/workflows/compile-firmware.yml +++ b/.github/workflows/compile-firmware.yml @@ -43,7 +43,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Compile firmware uses: arduino/compile-sketches@v1 diff --git a/.github/workflows/spell-check.yml b/.github/workflows/spell-check.yml index 01bee87..3f6b03f 100644 --- a/.github/workflows/spell-check.yml +++ b/.github/workflows/spell-check.yml @@ -16,7 +16,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Spell check uses: codespell-project/actions-codespell@master diff --git a/.github/workflows/sync-labels.yml b/.github/workflows/sync-labels.yml index 3ee6feb..4ea5755 100644 --- a/.github/workflows/sync-labels.yml +++ b/.github/workflows/sync-labels.yml @@ -27,7 +27,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Download JSON schema for labels configuration file id: download-schema @@ -105,7 +105,7 @@ jobs: echo "::set-output name=flag::--dry-run" - name: Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Download configuration files artifact uses: actions/download-artifact@v2 From 09f48007cb3abf9c5cb2ad0d2bb5993f9059a6b7 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 8 Apr 2022 23:10:06 +0000 Subject: [PATCH 14/37] Bump actions/download-artifact from 2 to 3 Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 3. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](https://github.com/actions/download-artifact/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/sync-labels.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sync-labels.yml b/.github/workflows/sync-labels.yml index 4ea5755..e84e803 100644 --- a/.github/workflows/sync-labels.yml +++ b/.github/workflows/sync-labels.yml @@ -108,7 +108,7 @@ jobs: uses: actions/checkout@v3 - name: Download configuration files artifact - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: ${{ env.CONFIGURATIONS_ARTIFACT }} path: ${{ env.CONFIGURATIONS_FOLDER }} From 4163501540fb50f2a1b6e4bb7cae70b2c0228341 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 8 Apr 2022 23:10:08 +0000 Subject: [PATCH 15/37] Bump actions/upload-artifact from 2 to 3 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/compile-bootloader.yml | 2 +- .github/workflows/compile-examples.yml | 2 +- .github/workflows/compile-firmware.yml | 2 +- .github/workflows/sync-labels.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/compile-bootloader.yml b/.github/workflows/compile-bootloader.yml index cba0ea0..57a5b41 100644 --- a/.github/workflows/compile-bootloader.yml +++ b/.github/workflows/compile-bootloader.yml @@ -59,7 +59,7 @@ jobs: sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }} - name: Save sketches report as workflow artifact - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: if-no-files-found: error path: ${{ env.SKETCHES_REPORTS_PATH }} diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index 7ff749c..88c81ae 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -117,7 +117,7 @@ jobs: sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }} - name: Save sketches report as workflow artifact - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: if-no-files-found: error path: ${{ env.SKETCHES_REPORTS_PATH }} diff --git a/.github/workflows/compile-firmware.yml b/.github/workflows/compile-firmware.yml index 0d6cb02..c650553 100644 --- a/.github/workflows/compile-firmware.yml +++ b/.github/workflows/compile-firmware.yml @@ -59,7 +59,7 @@ jobs: sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }} - name: Save sketches report as workflow artifact - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: if-no-files-found: error path: ${{ env.SKETCHES_REPORTS_PATH }} diff --git a/.github/workflows/sync-labels.yml b/.github/workflows/sync-labels.yml index 4ea5755..1d969d5 100644 --- a/.github/workflows/sync-labels.yml +++ b/.github/workflows/sync-labels.yml @@ -70,7 +70,7 @@ jobs: file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/${{ matrix.filename }} - name: Pass configuration files to next job via workflow artifact - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: path: | *.yaml From ee9484b18113c0ca6d34d7c84005aceaab83c821 Mon Sep 17 00:00:00 2001 From: kongtruss Date: Thu, 25 Aug 2022 16:48:27 +0200 Subject: [PATCH 16/37] Update PID_Position_test.ino --- examples/Nano/PID_Position_test/PID_Position_test.ino | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/Nano/PID_Position_test/PID_Position_test.ino b/examples/Nano/PID_Position_test/PID_Position_test.ino index 3dc65f6..a174815 100644 --- a/examples/Nano/PID_Position_test/PID_Position_test.ino +++ b/examples/Nano/PID_Position_test/PID_Position_test.ino @@ -1,5 +1,6 @@ -#include +//#include //#include +#include #define INTERRUPT_PIN 6 //Variable to store the battery voltage From 880eb7c98b8dce3bf12ac854a0db4640c58519ab Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 24 Oct 2022 23:11:19 +0000 Subject: [PATCH 17/37] Bump carlosperate/download-file-action from 1 to 2 Bumps [carlosperate/download-file-action](https://github.com/carlosperate/download-file-action) from 1 to 2. - [Release notes](https://github.com/carlosperate/download-file-action/releases) - [Commits](https://github.com/carlosperate/download-file-action/compare/v1...v2) --- updated-dependencies: - dependency-name: carlosperate/download-file-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/sync-labels.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sync-labels.yml b/.github/workflows/sync-labels.yml index 986bda6..5d7eee6 100644 --- a/.github/workflows/sync-labels.yml +++ b/.github/workflows/sync-labels.yml @@ -31,7 +31,7 @@ jobs: - name: Download JSON schema for labels configuration file id: download-schema - uses: carlosperate/download-file-action@v1 + uses: carlosperate/download-file-action@v2 with: file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/arduino-tooling-gh-label-configuration-schema.json location: ${{ runner.temp }}/label-configuration-schema @@ -65,7 +65,7 @@ jobs: steps: - name: Download - uses: carlosperate/download-file-action@v1 + uses: carlosperate/download-file-action@v2 with: file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/${{ matrix.filename }} From c160fdc0b4933cf5be70cb3eb52d5ba5bb6b8edc Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 29 Dec 2022 10:38:11 +0100 Subject: [PATCH 18/37] Bump geekyeggo/delete-artifact from 1 to 2 (#52) Bumps [geekyeggo/delete-artifact](https://github.com/geekyeggo/delete-artifact) from 1 to 2. - [Release notes](https://github.com/geekyeggo/delete-artifact/releases) - [Commits](https://github.com/geekyeggo/delete-artifact/compare/v1...v2) --- updated-dependencies: - dependency-name: geekyeggo/delete-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/sync-labels.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sync-labels.yml b/.github/workflows/sync-labels.yml index 5d7eee6..94938f3 100644 --- a/.github/workflows/sync-labels.yml +++ b/.github/workflows/sync-labels.yml @@ -114,7 +114,7 @@ jobs: path: ${{ env.CONFIGURATIONS_FOLDER }} - name: Remove unneeded artifact - uses: geekyeggo/delete-artifact@v1 + uses: geekyeggo/delete-artifact@v2 with: name: ${{ env.CONFIGURATIONS_ARTIFACT }} From 2d83df4060fa93a31b54695db1d6d17a62f25d1f Mon Sep 17 00:00:00 2001 From: Ali Jahangiri <75624145+aliphys@users.noreply.github.com> Date: Thu, 29 Dec 2022 10:38:37 +0100 Subject: [PATCH 19/37] pid1.setGains() uses float as input variables [AEK-309] (#38) * pid.setGains() requires float as input * fix spelling * Obsolete statement for the MKRMotorCarrier --- docs/api.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/api.md b/docs/api.md index 24e127f..6539e06 100644 --- a/docs/api.md +++ b/docs/api.md @@ -16,7 +16,7 @@ battery.getFiltered() #### Returns -* _getRaw()_: returns the raw ADC read from the battery as am integer. +* _getRaw()_: returns the raw ADC read from the battery as an integer. * _getConverted()_: returns the battery voltage converted to volts as a floating point. * _getFiltered()_: returns the battery voltage converted to volts and filtered in the last 10 seconds. @@ -110,12 +110,12 @@ Allow setting Motor1 or Motor2 to a specific speed or position. There are two PI #### Syntax ``` -pid1. setGains(int P, int I, int D) +pid1.setGains(float P, float I, float D) ``` #### Functions -* _setGains(float P, float I, float D)_: Set PID gains. (`int` type for MKRMotorCarrier) +* _setGains(float P, float I, float D)_: Set PID gains. * _resetGains()_: Reset PID gains to factory default settings. * _setControlMode(cl_control)_: Set control mode to either `CL_VELOCITY` or `CL_POSITION`. * _setSetpoint(cl_mode, int target)_: Set a specific velocity or position in one of the motors. Define cl_mode as `TARGET_POSITION` or `TARGET_VELOCITY` and the desired value in target. From f28af0e1d2ff348ebe4b6ad6bd6582e708d2a88c Mon Sep 17 00:00:00 2001 From: Alexander Entinger Date: Fri, 30 Dec 2022 08:11:58 +0100 Subject: [PATCH 20/37] Deleting out-commented code. --- examples/Nano/PID_Position_test/PID_Position_test.ino | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/Nano/PID_Position_test/PID_Position_test.ino b/examples/Nano/PID_Position_test/PID_Position_test.ino index a174815..662e57b 100644 --- a/examples/Nano/PID_Position_test/PID_Position_test.ino +++ b/examples/Nano/PID_Position_test/PID_Position_test.ino @@ -1,5 +1,3 @@ -//#include -//#include #include #define INTERRUPT_PIN 6 From 480267020ba1e33f86a267601605319e0d9234ef Mon Sep 17 00:00:00 2001 From: Alexander Entinger Date: Fri, 30 Dec 2022 08:27:44 +0100 Subject: [PATCH 21/37] Fix CI build error also for H7/M4 core. --- src/Common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Common.h b/src/Common.h index f31e330..c59c821 100644 --- a/src/Common.h +++ b/src/Common.h @@ -14,7 +14,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#ifdef ARDUINO_PORTENTA_H7_M7 +#if defined(ARDUINO_PORTENTA_H7_M7) || defined(ARDUINO_PORTENTA_H7_M4) #define RESET _RESET #endif From 6a0deb3f46072f6a107b1bf55b92986fb2194e63 Mon Sep 17 00:00:00 2001 From: Alexander Entinger Date: Fri, 30 Dec 2022 09:02:00 +0100 Subject: [PATCH 22/37] List `mbed_portenta` as supported architecture. (#56) --- library.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library.properties b/library.properties index 9dcdb37..4ffe5aa 100644 --- a/library.properties +++ b/library.properties @@ -6,5 +6,5 @@ sentence=Allows use of the Arduino Motor Carrier paragraph=(Nano and MKR version) category=Signal Input/Output url=https://www.arduino.cc/reference/en/libraries/arduinomotorcarrier/ -architectures=samd +architectures=samd,mbed_portenta includes=ArduinoMotorCarrier.h From e5d5d7974617263667bc9612dc1d092c1082d0b2 Mon Sep 17 00:00:00 2001 From: Alexander Entinger Date: Fri, 30 Dec 2022 09:03:33 +0100 Subject: [PATCH 23/37] Fix: Remove unncessary case which - in addition to being unnecessary - messes with compilation. (#55) --- examples/Flasher/Flasher.ino | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/Flasher/Flasher.ino b/examples/Flasher/Flasher.ino index 3413ebc..d5f89f3 100644 --- a/examples/Flasher/Flasher.ino +++ b/examples/Flasher/Flasher.ino @@ -112,7 +112,7 @@ void setup() { Wire.beginTransmission(0x66); Wire.write((uint8_t)GET_VERSION); - Wire.write((uint32_t)0); + Wire.write(0); Wire.endTransmission(); Wire.requestFrom(0x66, 5); From c52002f3ef9f0c28c4b82d6cbcd0b8e0606e5d66 Mon Sep 17 00:00:00 2001 From: Alexander Entinger Date: Fri, 30 Dec 2022 09:38:39 +0100 Subject: [PATCH 24/37] Release v2.0.2 --- library.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library.properties b/library.properties index 4ffe5aa..6cf5480 100644 --- a/library.properties +++ b/library.properties @@ -1,5 +1,5 @@ name=ArduinoMotorCarrier -version=2.0.1 +version=2.0.2 author=Arduino maintainer=Arduino sentence=Allows use of the Arduino Motor Carrier From 0d1cc6cb091aa3caa9b180919a458792daf638c9 Mon Sep 17 00:00:00 2001 From: Alexander Entinger Date: Fri, 10 Mar 2023 11:05:26 +0100 Subject: [PATCH 25/37] Fix: envie_m4 is no longer a valid FQBN. (#57) --- .github/workflows/compile-examples.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index e052383..b2ddea9 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -71,7 +71,7 @@ jobs: platforms: | - name: arduino:samd type: mkr - - fqbn: arduino:mbed_portenta:envie_m4 + - fqbn: arduino:mbed_portenta:envie_m7:target_core=cm4 platforms: | - name: arduino:mbed_portenta type: mkr From d74611f91e3b035253751d3bac0822725ceca1e8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 4 Sep 2023 23:21:30 +0000 Subject: [PATCH 26/37] Bump actions/checkout from 3 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/check-arduino.yml | 2 +- .github/workflows/compile-bootloader.yml | 2 +- .github/workflows/compile-examples.yml | 2 +- .github/workflows/compile-firmware.yml | 2 +- .github/workflows/spell-check.yml | 2 +- .github/workflows/sync-labels.yml | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/check-arduino.yml b/.github/workflows/check-arduino.yml index 3e0d26c..adb330f 100644 --- a/.github/workflows/check-arduino.yml +++ b/.github/workflows/check-arduino.yml @@ -16,7 +16,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Arduino Lint uses: arduino/arduino-lint-action@v1 diff --git a/.github/workflows/compile-bootloader.yml b/.github/workflows/compile-bootloader.yml index 57a5b41..737318f 100644 --- a/.github/workflows/compile-bootloader.yml +++ b/.github/workflows/compile-bootloader.yml @@ -43,7 +43,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Compile bootloader uses: arduino/compile-sketches@v1 diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index b2ddea9..19fb3f8 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -99,7 +99,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Compile examples uses: arduino/compile-sketches@v1 diff --git a/.github/workflows/compile-firmware.yml b/.github/workflows/compile-firmware.yml index c650553..1a47bd7 100644 --- a/.github/workflows/compile-firmware.yml +++ b/.github/workflows/compile-firmware.yml @@ -43,7 +43,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Compile firmware uses: arduino/compile-sketches@v1 diff --git a/.github/workflows/spell-check.yml b/.github/workflows/spell-check.yml index 3f6b03f..ef7d894 100644 --- a/.github/workflows/spell-check.yml +++ b/.github/workflows/spell-check.yml @@ -16,7 +16,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Spell check uses: codespell-project/actions-codespell@master diff --git a/.github/workflows/sync-labels.yml b/.github/workflows/sync-labels.yml index 94938f3..9cde1ac 100644 --- a/.github/workflows/sync-labels.yml +++ b/.github/workflows/sync-labels.yml @@ -27,7 +27,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Download JSON schema for labels configuration file id: download-schema @@ -105,7 +105,7 @@ jobs: echo "::set-output name=flag::--dry-run" - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Download configuration files artifact uses: actions/download-artifact@v3 From ea7fe9645938ec52f77bb503d9e3f7364560030e Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 19 Feb 2024 06:59:15 +0100 Subject: [PATCH 27/37] Bump actions/upload-artifact from 3 to 4 (#59) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/compile-bootloader.yml | 2 +- .github/workflows/compile-examples.yml | 2 +- .github/workflows/compile-firmware.yml | 2 +- .github/workflows/sync-labels.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/compile-bootloader.yml b/.github/workflows/compile-bootloader.yml index 737318f..fd005c4 100644 --- a/.github/workflows/compile-bootloader.yml +++ b/.github/workflows/compile-bootloader.yml @@ -59,7 +59,7 @@ jobs: sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }} - name: Save sketches report as workflow artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: if-no-files-found: error path: ${{ env.SKETCHES_REPORTS_PATH }} diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index 19fb3f8..efd7f3d 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -119,7 +119,7 @@ jobs: sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }} - name: Save sketches report as workflow artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: if-no-files-found: error path: ${{ env.SKETCHES_REPORTS_PATH }} diff --git a/.github/workflows/compile-firmware.yml b/.github/workflows/compile-firmware.yml index 1a47bd7..4309550 100644 --- a/.github/workflows/compile-firmware.yml +++ b/.github/workflows/compile-firmware.yml @@ -59,7 +59,7 @@ jobs: sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }} - name: Save sketches report as workflow artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: if-no-files-found: error path: ${{ env.SKETCHES_REPORTS_PATH }} diff --git a/.github/workflows/sync-labels.yml b/.github/workflows/sync-labels.yml index 9cde1ac..7680b37 100644 --- a/.github/workflows/sync-labels.yml +++ b/.github/workflows/sync-labels.yml @@ -70,7 +70,7 @@ jobs: file-url: https://raw.githubusercontent.com/arduino/tooling-project-assets/main/workflow-templates/assets/sync-labels/${{ matrix.filename }} - name: Pass configuration files to next job via workflow artifact - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: path: | *.yaml From 0a71bc63a8558ce45ebb36e4f96e9dae5545959e Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 19 Feb 2024 06:59:31 +0100 Subject: [PATCH 28/37] Bump actions/download-artifact from 3 to 4 (#60) Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](https://github.com/actions/download-artifact/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/sync-labels.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sync-labels.yml b/.github/workflows/sync-labels.yml index 7680b37..2e1d6e0 100644 --- a/.github/workflows/sync-labels.yml +++ b/.github/workflows/sync-labels.yml @@ -108,7 +108,7 @@ jobs: uses: actions/checkout@v4 - name: Download configuration files artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: ${{ env.CONFIGURATIONS_ARTIFACT }} path: ${{ env.CONFIGURATIONS_FOLDER }} From b60e216c790872ac350a8b35b0703411cc36aef1 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 19 Feb 2024 06:59:46 +0100 Subject: [PATCH 29/37] Bump geekyeggo/delete-artifact from 2 to 4 (#61) Bumps [geekyeggo/delete-artifact](https://github.com/geekyeggo/delete-artifact) from 2 to 4. - [Release notes](https://github.com/geekyeggo/delete-artifact/releases) - [Changelog](https://github.com/GeekyEggo/delete-artifact/blob/main/CHANGELOG.md) - [Commits](https://github.com/geekyeggo/delete-artifact/compare/v2...v4) --- updated-dependencies: - dependency-name: geekyeggo/delete-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/sync-labels.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sync-labels.yml b/.github/workflows/sync-labels.yml index 2e1d6e0..47ac50a 100644 --- a/.github/workflows/sync-labels.yml +++ b/.github/workflows/sync-labels.yml @@ -114,7 +114,7 @@ jobs: path: ${{ env.CONFIGURATIONS_FOLDER }} - name: Remove unneeded artifact - uses: geekyeggo/delete-artifact@v2 + uses: geekyeggo/delete-artifact@v4 with: name: ${{ env.CONFIGURATIONS_ARTIFACT }} From f2985db147eed699f50110d07af2feb6fe6e83d4 Mon Sep 17 00:00:00 2001 From: Alexander Entinger Date: Mon, 19 Feb 2024 08:42:03 +0100 Subject: [PATCH 30/37] Fix regression re report-size-deltas after updating actions/upload-artifact. (#63) For more information see https://github.com/arduino/report-size-deltas/blob/main/docs/FAQ.md#size-deltas-report-workflow-triggered-by-schedule-event . --- .github/workflows/compile-examples.yml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index efd7f3d..94e89bc 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -35,42 +35,52 @@ jobs: platforms: | - name: arduino:samd type: nano + artifact-name-suffix: arduino-samd-nano_33_iot - fqbn: arduino:samd:mkr1000 platforms: | - name: arduino:samd type: mkr + artifact-name-suffix: arduino-samd-mkr1000 - fqbn: arduino:samd:mkrzero platforms: | - name: arduino:samd type: mkr + artifact-name-suffix: arduino-samd-mkrzero - fqbn: arduino:samd:mkrwifi1010 platforms: | - name: arduino:samd type: mkr + artifact-name-suffix: arduino-samd-mkrwifi1010 - fqbn: arduino:samd:mkrfox1200 platforms: | - name: arduino:samd type: mkr + artifact-name-suffix: arduino-samd-mkrfox1200 - fqbn: arduino:samd:mkrwan1300 platforms: | - name: arduino:samd type: mkr + artifact-name-suffix: arduino-samd-mkrwan1300 - fqbn: arduino:samd:mkrwan1310 platforms: | - name: arduino:samd type: mkr + artifact-name-suffix: arduino-samd-mkrwan1310 - fqbn: arduino:samd:mkrgsm1400 platforms: | - name: arduino:samd type: mkr + artifact-name-suffix: arduino-samd-mkrgsm1400 - fqbn: arduino:samd:mkrnb1500 platforms: | - name: arduino:samd type: mkr + artifact-name-suffix: arduino-samd-mkrnb1500 - fqbn: arduino:samd:mkrvidor4000 platforms: | - name: arduino:samd type: mkr + artifact-name-suffix: arduino-samd-mkrvidor4000 - fqbn: arduino:mbed_portenta:envie_m7:target_core=cm4 platforms: | - name: arduino:mbed_portenta @@ -79,6 +89,7 @@ jobs: platforms: | - name: arduino:mbed_portenta type: mkr + artifact-name-suffix: arduino-mbed_portenta-envie_m7 # make board type-specific customizations to the matrix jobs include: @@ -123,4 +134,4 @@ jobs: with: if-no-files-found: error path: ${{ env.SKETCHES_REPORTS_PATH }} - name: ${{ env.SKETCHES_REPORTS_PATH }} + name: sketches-report-${{ matrix.board.artifact-name-suffix }} From 637123400db11df4974791891a91a07d3a78b4ca Mon Sep 17 00:00:00 2001 From: Alexander Entinger Date: Mon, 19 Feb 2024 09:31:48 +0100 Subject: [PATCH 31/37] Fix: "ARDUINO_PORTENTA_H7_M4" was replaced by "ARDUINO_GENERIC_STM32H747_M4" for Arduino Portenta H7 / M4 core. (#64) Since the previous define ("ARDUINO_PORTENTA_H7_M7") no longer exists, the #ifdef is not evaluated leading to a compilation error when compiling this library for the M4 core of the Arduino Portenta H7. --- .gitignore | 1 + src/Common.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..9f11b75 --- /dev/null +++ b/.gitignore @@ -0,0 +1 @@ +.idea/ diff --git a/src/Common.h b/src/Common.h index c59c821..06c81a9 100644 --- a/src/Common.h +++ b/src/Common.h @@ -14,7 +14,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#if defined(ARDUINO_PORTENTA_H7_M7) || defined(ARDUINO_PORTENTA_H7_M4) +#if defined(ARDUINO_PORTENTA_H7_M7) || defined(ARDUINO_GENERIC_STM32H747_M4) #define RESET _RESET #endif From ddfbe07d169a59b6ce81b1cb14c7d96a7d429fa6 Mon Sep 17 00:00:00 2001 From: Alexander Entinger Date: Mon, 19 Feb 2024 09:32:09 +0100 Subject: [PATCH 32/37] Release v2.0.3. --- library.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library.properties b/library.properties index 6cf5480..c47a034 100644 --- a/library.properties +++ b/library.properties @@ -1,5 +1,5 @@ name=ArduinoMotorCarrier -version=2.0.2 +version=2.0.3 author=Arduino maintainer=Arduino sentence=Allows use of the Arduino Motor Carrier From 4ce07586bcce568386fc448f1437128310a9c94c Mon Sep 17 00:00:00 2001 From: Alexander Entinger Date: Wed, 21 Feb 2024 07:22:43 +0100 Subject: [PATCH 33/37] Fix regression: report size delta size on PR. (#65) The necessary steps have in fact been documented here: https://github.com/arduino/report-size-deltas/blob/main/docs/FAQ.md#workflow-triggered-by-pull_request-event but I have overlooked them when I fixed the upload issue. With this PR the size deltas are - once again - reported within the PR. --- .github/workflows/compile-examples.yml | 23 +++++++++++++++++++---- .github/workflows/report-size-deltas.yml | 24 ------------------------ 2 files changed, 19 insertions(+), 28 deletions(-) delete mode 100644 .github/workflows/report-size-deltas.yml diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index 94e89bc..c18e3a7 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -18,14 +18,14 @@ on: workflow_dispatch: repository_dispatch: +env: + SKETCHES_REPORTS_PATH: sketches-reports + jobs: - build: + compile: name: ${{ matrix.board.fqbn }} runs-on: ubuntu-latest - env: - SKETCHES_REPORTS_PATH: sketches-reports - strategy: fail-fast: false @@ -135,3 +135,18 @@ jobs: if-no-files-found: error path: ${{ env.SKETCHES_REPORTS_PATH }} name: sketches-report-${{ matrix.board.artifact-name-suffix }} + + report: + needs: compile + if: github.event_name == 'pull_request' + runs-on: ubuntu-latest + + steps: + - name: Download sketches reports artifacts + uses: actions/download-artifact@v4 + with: + path: ${{ env.SKETCHES_REPORTS_PATH }} + + - uses: arduino/report-size-deltas@v1 + with: + sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }} diff --git a/.github/workflows/report-size-deltas.yml b/.github/workflows/report-size-deltas.yml deleted file mode 100644 index 652be5d..0000000 --- a/.github/workflows/report-size-deltas.yml +++ /dev/null @@ -1,24 +0,0 @@ -name: Report Size Deltas - -# See: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows -on: - push: - paths: - - ".github/workflows/report-size-deltas.yml" - schedule: - # Run at the minimum interval allowed by GitHub Actions. - # Note: GitHub Actions periodically has outages which result in workflow failures. - # In this event, the workflows will start passing again once the service recovers. - - cron: "*/5 * * * *" - workflow_dispatch: - repository_dispatch: - -jobs: - report: - runs-on: ubuntu-latest - steps: - - name: Comment size deltas reports to PRs - uses: arduino/report-size-deltas@v1 - with: - # The name of the workflow artifact created by the sketch compilation workflow - sketches-reports-source: sketches-reports From 8685abf02e5950b1576d4f1335e8a1eb664dcb17 Mon Sep 17 00:00:00 2001 From: Alexander Entinger Date: Wed, 21 Feb 2024 19:06:30 +0100 Subject: [PATCH 34/37] Revert "Fix regression: report size delta size on PR. (#65)" This reverts commit 4ce07586bcce568386fc448f1437128310a9c94c. --- .github/workflows/compile-examples.yml | 23 ++++------------------- .github/workflows/report-size-deltas.yml | 24 ++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 19 deletions(-) create mode 100644 .github/workflows/report-size-deltas.yml diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index c18e3a7..94e89bc 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -18,14 +18,14 @@ on: workflow_dispatch: repository_dispatch: -env: - SKETCHES_REPORTS_PATH: sketches-reports - jobs: - compile: + build: name: ${{ matrix.board.fqbn }} runs-on: ubuntu-latest + env: + SKETCHES_REPORTS_PATH: sketches-reports + strategy: fail-fast: false @@ -135,18 +135,3 @@ jobs: if-no-files-found: error path: ${{ env.SKETCHES_REPORTS_PATH }} name: sketches-report-${{ matrix.board.artifact-name-suffix }} - - report: - needs: compile - if: github.event_name == 'pull_request' - runs-on: ubuntu-latest - - steps: - - name: Download sketches reports artifacts - uses: actions/download-artifact@v4 - with: - path: ${{ env.SKETCHES_REPORTS_PATH }} - - - uses: arduino/report-size-deltas@v1 - with: - sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }} diff --git a/.github/workflows/report-size-deltas.yml b/.github/workflows/report-size-deltas.yml new file mode 100644 index 0000000..652be5d --- /dev/null +++ b/.github/workflows/report-size-deltas.yml @@ -0,0 +1,24 @@ +name: Report Size Deltas + +# See: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows +on: + push: + paths: + - ".github/workflows/report-size-deltas.yml" + schedule: + # Run at the minimum interval allowed by GitHub Actions. + # Note: GitHub Actions periodically has outages which result in workflow failures. + # In this event, the workflows will start passing again once the service recovers. + - cron: "*/5 * * * *" + workflow_dispatch: + repository_dispatch: + +jobs: + report: + runs-on: ubuntu-latest + steps: + - name: Comment size deltas reports to PRs + uses: arduino/report-size-deltas@v1 + with: + # The name of the workflow artifact created by the sketch compilation workflow + sketches-reports-source: sketches-reports From 1a8727befb7c3a79632f29d670f3752e2bcd5b07 Mon Sep 17 00:00:00 2001 From: Alexander Entinger Date: Wed, 21 Feb 2024 19:06:53 +0100 Subject: [PATCH 35/37] Correct workflow artifact name pattern in size deltas report workflow The "sketches-reports-source" input of the "arduino/report-size-deltas" GitHub Actions action defines the regular expression that matches the names of the sketches report workflow artifacts produced by the "Compile Examples" workflow. The key string in the names of these artifacts was set to "sketches-report" when the "Compile Examples" workflow was adjusted for compatibility with the breaking changes introduced by updating to version 4.x of the workflow's "actions/upload-artifact" GitHub Actions action dependency. The pattern set in the size deltas report workflow was "sketches-reports". The "s" at the end of that pattern caused it to no longer match against the key string in the artifact names after that adjustment of the "Compile Examples" workflow, resulting in size deltas reports no longer being generated by the workflow. Although a minimal fix would be to simply remove the "s" from the end of the pattern, the decision was made to use a more strict regular expression. This will make it easier for maintainers and contributors to understand that this value is a regular expression and the exact nature of how that regular expression functions (which is less clear when relying on the "arduino/report-size-deltas" action's partial pattern matching behavior). --- .github/workflows/report-size-deltas.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/report-size-deltas.yml b/.github/workflows/report-size-deltas.yml index 652be5d..39e2a0a 100644 --- a/.github/workflows/report-size-deltas.yml +++ b/.github/workflows/report-size-deltas.yml @@ -20,5 +20,5 @@ jobs: - name: Comment size deltas reports to PRs uses: arduino/report-size-deltas@v1 with: - # The name of the workflow artifact created by the sketch compilation workflow - sketches-reports-source: sketches-reports + # Regex matching the names of the workflow artifacts created by the "Compile Examples" workflow + sketches-reports-source: ^sketches-report-.+ From 32effa48a800ed90c527f59db4d132568f8391eb Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 19 Mar 2024 14:53:30 +0100 Subject: [PATCH 36/37] Bump geekyeggo/delete-artifact from 4 to 5 (#67) Bumps [geekyeggo/delete-artifact](https://github.com/geekyeggo/delete-artifact) from 4 to 5. - [Release notes](https://github.com/geekyeggo/delete-artifact/releases) - [Changelog](https://github.com/GeekyEggo/delete-artifact/blob/main/CHANGELOG.md) - [Commits](https://github.com/geekyeggo/delete-artifact/compare/v4...v5) --- updated-dependencies: - dependency-name: geekyeggo/delete-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/sync-labels.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sync-labels.yml b/.github/workflows/sync-labels.yml index 47ac50a..53a9f54 100644 --- a/.github/workflows/sync-labels.yml +++ b/.github/workflows/sync-labels.yml @@ -114,7 +114,7 @@ jobs: path: ${{ env.CONFIGURATIONS_FOLDER }} - name: Remove unneeded artifact - uses: geekyeggo/delete-artifact@v4 + uses: geekyeggo/delete-artifact@v5 with: name: ${{ env.CONFIGURATIONS_ARTIFACT }} From c524ab084b32f99b271c99b2294a4ae05f8ef1e6 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 8 Oct 2024 23:36:35 +0000 Subject: [PATCH 37/37] Bump arduino/arduino-lint-action from 1 to 2 Bumps [arduino/arduino-lint-action](https://github.com/arduino/arduino-lint-action) from 1 to 2. - [Release notes](https://github.com/arduino/arduino-lint-action/releases) - [Commits](https://github.com/arduino/arduino-lint-action/compare/v1...v2) --- updated-dependencies: - dependency-name: arduino/arduino-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/check-arduino.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check-arduino.yml b/.github/workflows/check-arduino.yml index adb330f..e818685 100644 --- a/.github/workflows/check-arduino.yml +++ b/.github/workflows/check-arduino.yml @@ -19,7 +19,7 @@ jobs: uses: actions/checkout@v4 - name: Arduino Lint - uses: arduino/arduino-lint-action@v1 + uses: arduino/arduino-lint-action@v2 with: compliance: specification library-manager: update