forked from greenplum-db/gpdb-archive
-
Notifications
You must be signed in to change notification settings - Fork 23
ADBDEV-7104: FOR CI only #1361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
whitehawk
wants to merge
75
commits into
adb-6.x-dev
Choose a base branch
from
ADBDEV-7104-re
base: adb-6.x-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
ADBDEV-7104: FOR CI only #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for RETURNING operator for ORCA optimizer returningList from query transforms into LogicalProject that wraps around logical dml node in dxl query dml nodes inside ORCA were changed to provide required columns for this project node nodeDML also was changed to return modified tuples to print them on coordinator through projection
…t planner's to original
output is first because most of other nodes expects it fixed serializers, readers Also small cleanup of unused changes
SELECT on table with no columns is accepted but RETURNING cannot have zero columns. The only way to output from DML node is by using RETURNING. So to require output for SELECT with zero columns tighten condition for only DML operations
…de doesn't return enougn columns problem occurs in case DML returns modified columns with replicated distribution and columns from subplan, which selects data from other table Subplan inside ORCA is planned as NLJoin On Expr2DXL stage subplan is pushed to projlist of nearest Result node above join node, join node itself is not needed so it is not added to DXL tree Problem is that GatherMotion is added above DML with replicated distribution to return data to qdir But this motion is under nearest Result node so when subplan is executed, its data has replicated distribution and there is no other motion to gather it This commit adds intermediate Result node right before motion, after join, in case when join requires more columns than child node can derive This will cause subplan to execute where is was meant to be executed while planning in ORCA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADBDEV-7104: FOR CI only