Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 41e1e8e

Browse files
authored
fix: retry strategy being ignored by daemoned nodes. Fix #14715 (#14782)
Signed-off-by: Eduardo Rodrigues <[email protected]>
1 parent b47c0b0 commit 41e1e8e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

workflow/controller/operator.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2203,7 +2203,7 @@ func (woc *wfOperationCtx) executeTemplate(ctx context.Context, nodeName string,
22032203
childNodeIDs, lastChildNode := getChildNodeIdsAndLastRetriedNode(retryParentNode, woc.wf.Status.Nodes)
22042204

22052205
// The retry node might have completed by now.
2206-
if retryParentNode.Fulfilled() && woc.childrenFulfilled(retryParentNode) { // if retry node is daemoned we want to check those explicitly
2206+
if retryParentNode.Fulfilled() && (woc.childrenFulfilled(retryParentNode) || (retryParentNode.IsDaemoned() && retryParentNode.FailedOrError())) { // if retry node is daemoned we want to check those explicitly
22072207
// If retry node has completed, set the output of the last child node to its output.
22082208
// Runtime parameters (e.g., `status`, `resourceDuration`) in the output will be used to emit metrics.
22092209
if lastChildNode != nil {

0 commit comments

Comments
 (0)