remove Cython version check, fixes python-llfuse#81

ThomasWaldmann · ThomasWaldmann · commit 8c0160545ce0 · 2023-05-21T01:40:04.000+02:00
distutils Version classes are deprecated.

I decided to remove the Cython version check completely,
it is not as simple as checking a minimum version anyway.

E.g. we can work with Cython 0.29.x and also 3.0.0b2,
but earlier 3.0.0 releases are of unknown compatibility.

Also, latest Python 3.12-dev versions require 0.29.34,
while older Pythons are happy with stuff compiled by earlier
0.29.x releases.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -46,6 +46,4 @@ jobs:
         run: pip install "Cython==3.0.0b2"
 
       - name: Test
-        run: |
-          cython --version
-          test/ci-test.sh
+        run: test/ci-test.sh
diff --git a/setup.py b/setup.py
@@ -34,7 +34,6 @@
 
 import setuptools
 from setuptools import Extension
-from distutils.version import LooseVersion
 
 basedir = os.path.abspath(os.path.dirname(__file__))
 sys.path.insert(0, os.path.join(basedir, 'util'))
@@ -218,11 +217,7 @@ def run(self):
                                               stderr=subprocess.STDOUT)
         except OSError:
             raise SystemExit('Cython needs to be installed for this command')
-
-        hit = re.match('^Cython version (.+)$', version)
-        if not hit or LooseVersion(hit.group(1)) < "0.29":
-            # in fact, we need a very recent Cython version to support the latest pythons
-            raise SystemExit('Need Cython 0.29 or newer, found ' + version)
+        print(f"Using {version.strip()}.")
 
         cmd = ['cython', '-Wextra', '--force', '-3', '--fast-fail',
                '--directive', 'embedsignature=True', '--include-dir',
