Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add kontent.ai CDN#19

Merged
ascorbic merged 7 commits into
ascorbic:mainfrom
thomasledoux1:feature/add-kontentai
Mar 6, 2023
Merged

feat: add kontent.ai CDN#19
ascorbic merged 7 commits into
ascorbic:mainfrom
thomasledoux1:feature/add-kontentai

Conversation

@ref-thomasledoux1

Copy link
Copy Markdown
Contributor

Added Kontent.ai CDN support.
Not sure how to run the tests locally, so couldn't verify this.

@ref-thomasledoux1

Copy link
Copy Markdown
Contributor Author

@ascorbic not sure if you get notified automatically, can't assign to you.

@ascorbic

ascorbic commented Mar 6, 2023

Copy link
Copy Markdown
Owner

Hey. Is there a way of ensuring that the API uses a "cover" cover strategy when resizing? This isn't giving the expected aspect ratio: https://assets-us-01.kc-usercontent.com/b744f382-bfc7-434d-93e7-a65d51249bc7/cc0afdc7-23d7-4fde-be2c-f58ad54d2934/daylight.jpg?w=800&h=300

@ascorbic

ascorbic commented Mar 6, 2023

Copy link
Copy Markdown
Owner

To run test tests locally you'll need the deno CLI installed, and then you can run deno test src

@ref-thomasledoux1

Copy link
Copy Markdown
Contributor Author

Hey @ascorbic I ran the tests locally now, should be passing now.
Also added a test for the "fit" behaviour.

@ascorbic

ascorbic commented Mar 6, 2023

Copy link
Copy Markdown
Owner

@ref-thomasledoux1

Copy link
Copy Markdown
Contributor Author

Ok, their docs weren’t really clear on this. Will adapt the logic.

@ascorbic

ascorbic commented Mar 6, 2023

Copy link
Copy Markdown
Owner

Yeah. I ended up just randomly trying values!

@ref-thomasledoux1

Copy link
Copy Markdown
Contributor Author

Updated the code + tests

@ascorbic ascorbic left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for this.

@ascorbic ascorbic changed the title Adding kontent.ai CDN feat: add kontent.ai CDN Mar 6, 2023
@ascorbic ascorbic enabled auto-merge (squash) March 6, 2023 20:09
@ascorbic ascorbic merged commit 7475b58 into ascorbic:main Mar 6, 2023
@mixie-bot mixie-bot Bot mentioned this pull request Dec 7, 2024
@mixie-bot mixie-bot Bot mentioned this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants