feat: add Directus support#46
Merged
Merged
Conversation
ascorbic
reviewed
Apr 19, 2023
ascorbic
reviewed
Apr 22, 2023
ascorbic
left a comment
Owner
There was a problem hiding this comment.
Thanks! I wanted to add support for manually setting the CDN to the playground so I coiuld tests this there. I did that today and it works great!
Owner
|
@danestves the sample URL that you provided here is no longer resolving, menaing the Directus tests no longer pass. Would you have a stable sample image URL it could be switched for? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internally at Kazel we use a custom transformer to display the images of our backend to our frontend, I moved all the code to here since there is an issue open about it, added tests and an example image which you can test.
Closes #36