Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add support for imageengine cdn#66

Merged
ascorbic merged 7 commits into
ascorbic:mainfrom
RohanRaina513:main
Jul 4, 2023
Merged

feat: add support for imageengine cdn#66
ascorbic merged 7 commits into
ascorbic:mainfrom
RohanRaina513:main

Conversation

@RohanRaina513

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread data/domains.json Outdated
"ip.keycdn.com": "keycdn",
"assets.caisy.io": "bunny"
"assets.caisy.io": "bunny",
"cdn.imageengine.io": "imageengine"

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also have cdn.imgeng.in in subdomains.json?

@ascorbic

ascorbic commented May 29, 2023

Copy link
Copy Markdown
Owner

Thanks for the contribution! The demo images don't seem to be working. Can you check the URLs are correct?

Comment thread demo/src/examples.json Outdated
@ascorbic

Copy link
Copy Markdown
Owner

@RohanRaina513 Thanks for updating this. The image is giving me an error in the playground if you select ImageEngine: https://deploy-preview-66--unpic-playground.netlify.app/

@RohanRaina513

Copy link
Copy Markdown
Contributor Author

@ascorbic Thanks for pointing it out. This commit should resolve the playground error

@ascorbic

ascorbic commented Jul 1, 2023

Copy link
Copy Markdown
Owner

Hey! Thanks for fixing that, but it seems that we do need the fit arg. Right now it's giving the wrong aspect ratio: if I choose dimensions with a different aspect ratio it doesn't return the correct dimensions. Try it by changing the height in the playground to 300 and you'll see the image go very low res because it's generated the wrong aspect ratio and needed to stretch it to fit.

@ascorbic

ascorbic commented Jul 4, 2023

Copy link
Copy Markdown
Owner

@RohanRaina513 thanks for updating this. It looks like it's working! Are you ready for me to merge this, or is there more to do?

@RohanRaina513

Copy link
Copy Markdown
Contributor Author

@RohanRaina513 thanks for updating this. It looks like it's working! Are you ready for me to merge this, or is there more to do?

@ascorbic Nothing more to be added. Kindly go ahead with the merge

@ascorbic ascorbic merged commit 788633e into ascorbic:main Jul 4, 2023
@mixie-bot mixie-bot Bot mentioned this pull request Jul 4, 2023
@mixie-bot mixie-bot Bot mentioned this pull request Dec 7, 2024
@mixie-bot mixie-bot Bot mentioned this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants