feat: support Astro _image endpoint#94
Conversation
ascorbic
left a comment
There was a problem hiding this comment.
Hey! Thanks for this. We just need a few things to get this ready to merge.
As well as the individual comments, framework transformers need to implement delegateUrl. This is needed so that if the user passes a URL with an href that matches another CDN, we use that instead of the local server. Take a look at the Next.js tests for examples.
Sure! I think the |
|
Just wanted to say thank you for your help reviewing this PR @ascorbic π great suggestions |
|
I fixed those issues and squashed to a single commit π |
|
Hi @ascorbic π please let me know if thereβs anything else I need to fix with this PRβthanks again for reviewing π |
|
@ascorbic and @jlarmstrongiv are there any blockers for this PR? I found unpic-img has an astro component, and wanted to use it with the astro assets image endpoint in my project |
|
Thank you @ascorbic ! Your suggestions were very helpful π |
Closes #93