fix: completion bash #1886
Merged
fix: completion bash #1886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @jn-jairo thanks for the PR! It looks like these changes failed the Bash lint check. Can you adjust the formatting? |
Contributor
Author
|
Updated with the correct code style. |
Stratus3D
approved these changes
Feb 6, 2025
Member
|
Thanks @jn-jairo ! This fix should ship sometime this week. |
Merged
Member
|
Want to take a stab at doing this for zsh @jn-jairo ? |
Contributor
Author
Sorry, I don't use zsh. I looked at the code but it's not as simple as the bash one. I'm not a specialist at completion script, I managed to edit the bash one because that one is pretty simple. |
Member
|
Thanks @jn-jairo , I'm no expert at completion scripts in any shell 😆 . Going to try to fix the zsh and fish ones tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rewrite of the completion bash removing the hyphenated commands and adapting the other changes in command line.
Fixes: #1867