Remove possible race condition from test code

olabini · olabini · commit 533d69c5c95a · 2011-02-07T16:53:58.000-04:00
diff --git a/src/test/java/dnode/DNodeTest.java b/src/test/java/dnode/DNodeTest.java
@@ -74,8 +74,8 @@ public void call(Object... args) {
                 }
             }
         });
-        thread.start();
         synchronized (signals) {
+            thread.start();
             signals.wait();
         }
     }
@@ -94,8 +94,7 @@ private String runClient(String method) throws IOException, InterruptedException
         int exit = client.waitFor();
         if (exit != 0)
             throw new AssertionFailedError("Exit value from external process was " + exit +
-                    " (with stdout/stderr: " + result + ")");
+                                           " (with stdout/stderr: " + result + ")");
         return result.toString();
     }
-
 }

Original file line number	Diff line number	Diff line change
`@@ -74,8 +74,8 @@ public void call(Object... args) {`
`74`	`74`	`}`
`75`	`75`	`}`
`76`	`76`	`});`
`77`		`- thread.start();`
`78`	`77`	`synchronized (signals) {`
	`78`	`+ thread.start();`
`79`	`79`	`signals.wait();`
`80`	`80`	`}`
`81`	`81`	`}`
`@@ -94,8 +94,7 @@ private String runClient(String method) throws IOException, InterruptedException`
`94`	`94`	`int exit = client.waitFor();`
`95`	`95`	`if (exit != 0)`
`96`	`96`	`throw new AssertionFailedError("Exit value from external process was " + exit +`
`97`		`- " (with stdout/stderr: " + result + ")");`
	`97`	`+ " (with stdout/stderr: " + result + ")");`
`98`	`98`	`return result.toString();`
`99`	`99`	`}`
`100`		`-`
`101`	`100`	`}`