🐛 Version anchors now can be selected and triggers the onclick function

Santiago Barragan · Santiago Barragan · commit 7b4905e7312a · 2023-12-30T22:45:10.000-05:00
diff --git a/.github/actions.py b/.github/actions.py
@@ -136,7 +136,7 @@ def update(pkg_name, version):
     original_div = soup.find('section', class_='versions').findAll('div')[-1]
     new_div = copy.copy(original_div)
     anchor = new_div.find('a')
-    anchor['onclick'] = f"load_readme('{version}', scroll_to_div=true)"
+    new_div['onclick'] = f"load_readme('{version}', scroll_to_div=true);"
     new_div['id'] = norm_version
     new_div['class'] = ""
     if not is_stable(version):
diff --git a/pkg_template.html b/pkg_template.html
@@ -79,8 +79,8 @@
           _author
         </p>
         <section class="versions" id="versions">
-          <div id="_version">
-            <a href="_link" onclick="load_readme('_version', scroll_to_div=true)">
+          <div id="_version" onclick="load_readme('_version', scroll_to_div=true)">
+            <a href="_link">
               _version
             </a>
           </div>
diff --git a/static/package_page.js b/static/package_page.js
@@ -1,4 +1,6 @@
 function load_readme(version, scroll_to_div=false){
+  addDynamicClickDelegation(`${version}`);
+
   let urlVersion = url_readme_main.replace('main', version);
   fetch(urlVersion)
   .then(response => {
@@ -35,4 +37,29 @@ function redirectToIndex() {
   window.location.href = "../index.html";
 }
 
+function addDynamicClickDelegation(parentId) {
+  const parentDiv = document.getElementById(parentId);
+
+  if (parentDiv) {
+      parentDiv.addEventListener('click', function (event) {
+          if (event.target !== this) {
+              event.stopPropagation();
+              this.click(); // Trigger the parent div's onclick function
+          }
+      });
+  }
+}
+
+function removeHrefFromAnchors() {
+  var versionsSection = document.getElementById('versions');
+  if (versionsSection) {
+      var anchors = versionsSection.getElementsByTagName('a');
+      for (var i = 0; i < anchors.length; i++) {
+          anchors[i].removeAttribute('href');
+      }
+  }
+}
 
+window.onload = function() {
+  removeHrefFromAnchors();
+};
