From 58c33818d3476c7720f79a41466f5abdc163ba4f Mon Sep 17 00:00:00 2001 From: Sean Bright Date: Sat, 17 Aug 2024 16:12:11 -0400 Subject: [PATCH 1/2] FastScannerRandomTest.java: Use our `toHexString()` instead of Logback's. Fixes the failed tests occurring on #613 --- .../util/internal/streamreader/FastScannerRandomTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/java/org/asteriskjava/util/internal/streamreader/FastScannerRandomTest.java b/src/test/java/org/asteriskjava/util/internal/streamreader/FastScannerRandomTest.java index eadce8739..328414419 100644 --- a/src/test/java/org/asteriskjava/util/internal/streamreader/FastScannerRandomTest.java +++ b/src/test/java/org/asteriskjava/util/internal/streamreader/FastScannerRandomTest.java @@ -1,6 +1,6 @@ package org.asteriskjava.util.internal.streamreader; -import ch.qos.logback.core.encoder.ByteArrayUtil; +import org.asteriskjava.manager.internal.ManagerUtil; import org.asteriskjava.util.internal.SocketConnectionFacadeImpl; import org.junit.jupiter.api.Test; @@ -72,8 +72,8 @@ void compare(String testData, Pattern pattern) throws IOException { if (!fastResult.equals(scannerResult)) { - System.out.println("Expected " + ByteArrayUtil.toHexString(scannerResult.getBytes())); - System.out.println("Got " + ByteArrayUtil.toHexString(fastResult.getBytes())); + System.out.println("Expected " + ManagerUtil.toHexString(scannerResult.getBytes())); + System.out.println("Got " + ManagerUtil.toHexString(fastResult.getBytes())); System.out.println("Error " + ctr); System.out.println(""); From 8e8536655b3c8ddba25348b9aa1d0519469b330f Mon Sep 17 00:00:00 2001 From: Sean Bright Date: Sun, 18 Aug 2024 16:00:29 -0400 Subject: [PATCH 2/2] pom.xml: Drop Logback dependency entirely. --- .github/dependabot.yml | 4 ---- pom.xml | 6 ------ 2 files changed, 10 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index d5a770378..3660fe492 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -6,10 +6,6 @@ updates: interval: "daily" labels: - "kind/dependencies" - ignore: - # As long as we support Java 8 - - dependency-name: "logback-classic" - update-types: [ "version-update:semver-major", "version-update:semver-minor" ] - package-ecosystem: "github-actions" directory: "/" schedule: diff --git a/pom.xml b/pom.xml index b889385e3..43927f016 100644 --- a/pom.xml +++ b/pom.xml @@ -129,12 +129,6 @@ 4.10.0 test - - ch.qos.logback - logback-classic - 1.3.12 - test -