From 5fa04cf2f2d54c4a1cd38a2780900fc2307cab4c Mon Sep 17 00:00:00 2001 From: dylwil3 Date: Fri, 22 Nov 2024 15:03:59 -0600 Subject: [PATCH 1/7] too-many-public-methods --- .../src/rules/pylint/rules/too_many_public_methods.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/crates/ruff_linter/src/rules/pylint/rules/too_many_public_methods.rs b/crates/ruff_linter/src/rules/pylint/rules/too_many_public_methods.rs index 26fca2d0786dc..5da094aacdd7c 100644 --- a/crates/ruff_linter/src/rules/pylint/rules/too_many_public_methods.rs +++ b/crates/ruff_linter/src/rules/pylint/rules/too_many_public_methods.rs @@ -105,6 +105,10 @@ pub(crate) fn too_many_public_methods( class_def: &ast::StmtClassDef, max_methods: usize, ) { + // https://github.com/astral-sh/ruff/issues/14535 + if checker.source_type.is_stub() { + return; + } let methods = class_def .body .iter() From 72b31222090a31c197be653993762a4c5bf6180c Mon Sep 17 00:00:00 2001 From: dylwil3 Date: Fri, 22 Nov 2024 15:04:18 -0600 Subject: [PATCH 2/7] too-many-positional-arguments --- .../src/rules/pylint/rules/too_many_positional_arguments.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/crates/ruff_linter/src/rules/pylint/rules/too_many_positional_arguments.rs b/crates/ruff_linter/src/rules/pylint/rules/too_many_positional_arguments.rs index da30e224b806b..f0da07a6c0f0e 100644 --- a/crates/ruff_linter/src/rules/pylint/rules/too_many_positional_arguments.rs +++ b/crates/ruff_linter/src/rules/pylint/rules/too_many_positional_arguments.rs @@ -60,6 +60,10 @@ pub(crate) fn too_many_positional_arguments( checker: &mut Checker, function_def: &ast::StmtFunctionDef, ) { + // https://github.com/astral-sh/ruff/issues/14535 + if checker.source_type.is_stub() { + return; + } let semantic = checker.semantic(); // Count the number of positional arguments. From 0dcc9ad2cd3bf0029a7b32cafb4af3e8066c5e9c Mon Sep 17 00:00:00 2001 From: dylwil3 Date: Fri, 22 Nov 2024 15:04:36 -0600 Subject: [PATCH 3/7] too-many-arguments --- .../ruff_linter/src/rules/pylint/rules/too_many_arguments.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/crates/ruff_linter/src/rules/pylint/rules/too_many_arguments.rs b/crates/ruff_linter/src/rules/pylint/rules/too_many_arguments.rs index 9b331571fb6cf..3b643abc353a7 100644 --- a/crates/ruff_linter/src/rules/pylint/rules/too_many_arguments.rs +++ b/crates/ruff_linter/src/rules/pylint/rules/too_many_arguments.rs @@ -59,6 +59,10 @@ impl Violation for TooManyArguments { /// PLR0913 pub(crate) fn too_many_arguments(checker: &mut Checker, function_def: &ast::StmtFunctionDef) { + // https://github.com/astral-sh/ruff/issues/14535 + if checker.source_type.is_stub() { + return; + } let semantic = checker.semantic(); let num_arguments = function_def From eca3d406f6a45b723d42a3f0efc005d937056529 Mon Sep 17 00:00:00 2001 From: dylwil3 Date: Fri, 22 Nov 2024 15:04:48 -0600 Subject: [PATCH 4/7] slots --- .../flake8_slots/rules/no_slots_in_namedtuple_subclass.rs | 4 ++++ .../src/rules/flake8_slots/rules/no_slots_in_str_subclass.rs | 4 ++++ .../rules/flake8_slots/rules/no_slots_in_tuple_subclass.rs | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/crates/ruff_linter/src/rules/flake8_slots/rules/no_slots_in_namedtuple_subclass.rs b/crates/ruff_linter/src/rules/flake8_slots/rules/no_slots_in_namedtuple_subclass.rs index dd84fd04dcfe5..6e8bcf50ce4a1 100644 --- a/crates/ruff_linter/src/rules/flake8_slots/rules/no_slots_in_namedtuple_subclass.rs +++ b/crates/ruff_linter/src/rules/flake8_slots/rules/no_slots_in_namedtuple_subclass.rs @@ -78,6 +78,10 @@ pub(crate) fn no_slots_in_namedtuple_subclass( stmt: &Stmt, class: &StmtClassDef, ) { + // https://github.com/astral-sh/ruff/issues/14535 + if checker.source_type.is_stub() { + return; + } let Some(Arguments { args: bases, .. }) = class.arguments.as_deref() else { return; }; diff --git a/crates/ruff_linter/src/rules/flake8_slots/rules/no_slots_in_str_subclass.rs b/crates/ruff_linter/src/rules/flake8_slots/rules/no_slots_in_str_subclass.rs index ea821ec352a17..7479dc7821e58 100644 --- a/crates/ruff_linter/src/rules/flake8_slots/rules/no_slots_in_str_subclass.rs +++ b/crates/ruff_linter/src/rules/flake8_slots/rules/no_slots_in_str_subclass.rs @@ -50,6 +50,10 @@ impl Violation for NoSlotsInStrSubclass { /// SLOT000 pub(crate) fn no_slots_in_str_subclass(checker: &mut Checker, stmt: &Stmt, class: &StmtClassDef) { + // https://github.com/astral-sh/ruff/issues/14535 + if checker.source_type.is_stub() { + return; + } let Some(Arguments { args: bases, .. }) = class.arguments.as_deref() else { return; }; diff --git a/crates/ruff_linter/src/rules/flake8_slots/rules/no_slots_in_tuple_subclass.rs b/crates/ruff_linter/src/rules/flake8_slots/rules/no_slots_in_tuple_subclass.rs index 4300d333ac622..5cf1dacb774d9 100644 --- a/crates/ruff_linter/src/rules/flake8_slots/rules/no_slots_in_tuple_subclass.rs +++ b/crates/ruff_linter/src/rules/flake8_slots/rules/no_slots_in_tuple_subclass.rs @@ -51,6 +51,10 @@ impl Violation for NoSlotsInTupleSubclass { /// SLOT001 pub(crate) fn no_slots_in_tuple_subclass(checker: &mut Checker, stmt: &Stmt, class: &StmtClassDef) { + // https://github.com/astral-sh/ruff/issues/14535 + if checker.source_type.is_stub() { + return; + } let Some(Arguments { args: bases, .. }) = class.arguments.as_deref() else { return; }; From ac4cd7e2bf5023282527cb76eeb03be8ac004864 Mon Sep 17 00:00:00 2001 From: dylwil3 Date: Fri, 22 Nov 2024 15:05:02 -0600 Subject: [PATCH 5/7] boolean trap --- .../rules/boolean_default_value_positional_argument.rs | 4 ++++ .../rules/boolean_positional_value_in_call.rs | 4 ++++ .../rules/boolean_type_hint_positional_argument.rs | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_default_value_positional_argument.rs b/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_default_value_positional_argument.rs index 760577848f661..5c838330409a7 100644 --- a/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_default_value_positional_argument.rs +++ b/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_default_value_positional_argument.rs @@ -106,6 +106,10 @@ pub(crate) fn boolean_default_value_positional_argument( decorator_list: &[Decorator], parameters: &Parameters, ) { + // https://github.com/astral-sh/ruff/issues/14535 + if checker.source_type.is_stub() { + return; + } // Allow Boolean defaults in explicitly-allowed functions. if is_allowed_func_def(name) { return; diff --git a/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_positional_value_in_call.rs b/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_positional_value_in_call.rs index 87eb740c2cd14..35b7062295d88 100644 --- a/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_positional_value_in_call.rs +++ b/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_positional_value_in_call.rs @@ -52,6 +52,10 @@ impl Violation for BooleanPositionalValueInCall { } pub(crate) fn boolean_positional_value_in_call(checker: &mut Checker, call: &ast::ExprCall) { + // https://github.com/astral-sh/ruff/issues/14535 + if checker.source_type.is_stub() { + return; + } if allow_boolean_trap(call, checker) { return; } diff --git a/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_type_hint_positional_argument.rs b/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_type_hint_positional_argument.rs index 1f7ec1b852a1f..6d756ec37b184 100644 --- a/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_type_hint_positional_argument.rs +++ b/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_type_hint_positional_argument.rs @@ -115,6 +115,10 @@ pub(crate) fn boolean_type_hint_positional_argument( decorator_list: &[Decorator], parameters: &Parameters, ) { + // https://github.com/astral-sh/ruff/issues/14535 + if checker.source_type.is_stub() { + return; + } // Allow Boolean type hints in explicitly-allowed functions. if is_allowed_func_def(name) { return; From f3c97571f7ac6fc261b8c3db429157c7f2f1c0f6 Mon Sep 17 00:00:00 2001 From: dylwil3 Date: Fri, 22 Nov 2024 15:05:16 -0600 Subject: [PATCH 6/7] bad-dunder-name --- .../src/rules/pylint/rules/bad_dunder_method_name.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/crates/ruff_linter/src/rules/pylint/rules/bad_dunder_method_name.rs b/crates/ruff_linter/src/rules/pylint/rules/bad_dunder_method_name.rs index 95dc16ab9cd6f..8e83c07cc1cdc 100644 --- a/crates/ruff_linter/src/rules/pylint/rules/bad_dunder_method_name.rs +++ b/crates/ruff_linter/src/rules/pylint/rules/bad_dunder_method_name.rs @@ -57,6 +57,10 @@ impl Violation for BadDunderMethodName { /// PLW3201 pub(crate) fn bad_dunder_method_name(checker: &mut Checker, method: &ast::StmtFunctionDef) { + // https://github.com/astral-sh/ruff/issues/14535 + if checker.source_type.is_stub() { + return; + } // If the name isn't a dunder, skip it. if !method.name.starts_with('_') || !method.name.ends_with('_') { return; From 3f7a00db34eaa8fcad117dcad5fdc788f31d67c0 Mon Sep 17 00:00:00 2001 From: dylwil3 Date: Sat, 23 Nov 2024 01:36:33 -0600 Subject: [PATCH 7/7] omit FBT003 --- .../rules/boolean_positional_value_in_call.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_positional_value_in_call.rs b/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_positional_value_in_call.rs index 35b7062295d88..87eb740c2cd14 100644 --- a/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_positional_value_in_call.rs +++ b/crates/ruff_linter/src/rules/flake8_boolean_trap/rules/boolean_positional_value_in_call.rs @@ -52,10 +52,6 @@ impl Violation for BooleanPositionalValueInCall { } pub(crate) fn boolean_positional_value_in_call(checker: &mut Checker, call: &ast::ExprCall) { - // https://github.com/astral-sh/ruff/issues/14535 - if checker.source_type.is_stub() { - return; - } if allow_boolean_trap(call, checker) { return; }