pr changes addressed

aswarner · aswarner · commit f23d9e01bdc0 · 2022-04-11T15:45:49.000-04:00
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -2950,8 +2950,6 @@ def _update_title_position(self, renderer):
             _log.debug('title position was updated manually, not adjusting')
             return
 
-        titles = []
-
         titles = [self.title, self._left_title, self._right_title]
 
         for title in titles:
@@ -3004,14 +3002,15 @@ def _update_title_position(self, renderer):
                         (0., 2 * top - title.get_window_extent(renderer).ymin))
                     title.set_position((x, y))
 
-        grouped_axs = self.figure._align_title_groups.get_siblings(self)
         ymax = max(title.get_position()[1] for title in titles)
         for title in titles:
             # now line up all the titles at the highest baseline.
             x, _ = title.get_position()
             title.set_position((x, ymax))
 
         # Align bboxes of grouped axes to highest in group
+        grouped_axs = self.figure._align_label_groups['title'] \
+                          .get_siblings(self)
         bb_ymax = None
         ax_max = None
         for ax in grouped_axs:
diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py
@@ -173,8 +173,8 @@ def __init__(self, **kwargs):
         # groupers to keep track of x and y labels we want to align.
         # see self.align_xlabels and self.align_ylabels and
         # axis._get_tick_boxes_siblings
-        self._align_label_groups = {"x": cbook.Grouper(), "y": cbook.Grouper()}
-        self._align_title_groups = cbook.Grouper()
+        self._align_label_groups = {"x": cbook.Grouper(), "y": cbook.Grouper(),
+                                    "title": cbook.Grouper()}
 
         self.figure = self
         # list of child gridspecs for this figure
@@ -1294,7 +1294,7 @@ def align_titles(self, axs=None):
                             rowspanc = axc.get_subplotspec().rowspan
                             if rowspan.start == rowspanc.start or \
                                rowspan.stop == rowspanc.stop:
-                                self._align_title_groups.join(ax, axc)
+                                self._align_label_groups['title'].join(ax, axc)
 
     def align_ylabels(self, axs=None):
         """
@@ -2903,6 +2903,7 @@ def draw(self, renderer):
 
         artists = self._get_draw_artists(renderer)
         try:
+
             renderer.open_group('figure', gid=self.get_gid())
             if self.axes and self.get_layout_engine() is not None:
                 try:
