Do not apply compression when StatusCode is set to 204 or 304.

birkirb · birkirb · commit f0e45747fa66 · 2015-03-04T14:48:16.000+01:00
Some http clients will react unfavoriably to compression when there
must not be any response body.
diff --git a/compress.go b/compress.go
@@ -45,13 +45,15 @@ type CompressResponseWriter struct {
 
 func CompressFilter(c *Controller, fc []Filter) {
 	if Config.BoolDefault("results.compressed", false) {
-		writer := CompressResponseWriter{c.Response.Out, nil, "", false, make(chan bool, 1), nil, false}
-		writer.DetectCompressionType(c.Request, c.Response)
-		w, ok := c.Response.Out.(http.CloseNotifier)
-		if ok {
-			writer.parentNotify = w.CloseNotify()
+		if c.Response.Status != http.StatusNoContent && c.Response.Status != http.StatusNotModified {
+			writer := CompressResponseWriter{c.Response.Out, nil, "", false, make(chan bool, 1), nil, false}
+			writer.DetectCompressionType(c.Request, c.Response)
+			w, ok := c.Response.Out.(http.CloseNotifier)
+			if ok {
+				writer.parentNotify = w.CloseNotify()
+			}
+			c.Response.Out = &writer
 		}
-		c.Response.Out = &writer
 	}
 	fc[0](c, fc[1:])
 }
