Suppress repo update when typing commit message

kuychaco · kuychaco · commit ade7de86d60b · 2018-10-24T13:33:28.000-07:00
See #1464 (for performance)
diff --git a/lib/controllers/commit-controller.js b/lib/controllers/commit-controller.js
@@ -123,9 +123,9 @@ export default class CommitController extends React.Component {
     return this.props.commit(msg.trim(), {amend, coAuthors, verbatim});
   }
 
-  setCommitMessage(message) {
+  setCommitMessage(message, options) {
     if (!this.props.repository.isPresent()) { return; }
-    this.props.repository.setCommitMessage(message);
+    this.props.repository.setCommitMessage(message, options);
   }
 
   getCommitMessage() {
@@ -140,7 +140,7 @@ export default class CommitController extends React.Component {
     if (!this.props.repository.isPresent()) {
       return;
     }
-    this.setCommitMessage(newMessage);
+    this.setCommitMessage(newMessage, {suppressUpdate: true});
   }
 
   getCommitMessageEditors() {
diff --git a/lib/models/repository-states/present.js b/lib/models/repository-states/present.js
@@ -49,9 +49,11 @@ export default class Present extends State {
     }
   }
 
-  setCommitMessage(message) {
+  setCommitMessage(message, {suppressUpdate} = {suppressUpdate: false}) {
     this.commitMessage = message;
-    this.didUpdate();
+    if (!suppressUpdate) {
+      this.didUpdate();
+    }
   }
 
   setCommitMessageTemplate(template) {

Original file line number	Diff line number	Diff line change
`@@ -123,9 +123,9 @@ export default class CommitController extends React.Component {`
`123`	`123`	`return this.props.commit(msg.trim(), {amend, coAuthors, verbatim});`
`124`	`124`	`}`
`125`	`125`
`126`		`- setCommitMessage(message) {`
	`126`	`+ setCommitMessage(message, options) {`
`127`	`127`	`if (!this.props.repository.isPresent()) { return; }`
`128`		`- this.props.repository.setCommitMessage(message);`
	`128`	`+ this.props.repository.setCommitMessage(message, options);`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`getCommitMessage() {`
`@@ -140,7 +140,7 @@ export default class CommitController extends React.Component {`
`140`	`140`	`if (!this.props.repository.isPresent()) {`
`141`	`141`	`return;`
`142`	`142`	`}`
`143`		`- this.setCommitMessage(newMessage);`
	`143`	`+ this.setCommitMessage(newMessage, {suppressUpdate: true});`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`getCommitMessageEditors() {`
Original file line number	Diff line number	Diff line change
`@@ -49,9 +49,11 @@ export default class Present extends State {`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`
`52`		`- setCommitMessage(message) {`
	`52`	`+ setCommitMessage(message, {suppressUpdate} = {suppressUpdate: false}) {`
`53`	`53`	`this.commitMessage = message;`
`54`		`- this.didUpdate();`
	`54`	`+ if (!suppressUpdate) {`
	`55`	`+ this.didUpdate();`
	`56`	`+ }`
`55`	`57`	`}`
`56`	`58`
`57`	`59`	`setCommitMessageTemplate(template) {`