From 5e1c148f9974154fd49f8f8f76b024e19c5bda7e Mon Sep 17 00:00:00 2001 From: Gordon Woodhull Date: Sat, 11 Jan 2014 23:31:39 -0500 Subject: [PATCH 1/3] line break --- dcplot.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dcplot.js b/dcplot.js index 9061023..864c5df 100644 --- a/dcplot.js +++ b/dcplot.js @@ -435,7 +435,8 @@ function dcplot(frame, groupname, definition) { // abstract this into a plugin - this is RCloud-specific (rserve.js) function get_levels(dim) { var levels = null; - if(_.isFunction(dim)) levels = dim.attrs.r_attributes.levels; + if(_.isFunction(dim)) + levels = dim.attrs.r_attributes.levels; else if(_.has(dims, dim) && mhas(accessor(dims[dim]), 'attrs', 'r_attributes', 'levels')) levels = accessor(dims[dim]).attrs.r_attributes.levels; return levels; From 8bb60509fb9641bbc6ae2d9a1fc51b87a1e9ca21 Mon Sep 17 00:00:00 2001 From: Gordon Woodhull Date: Tue, 14 Jan 2014 13:33:53 -0500 Subject: [PATCH 2/3] extinct comment --- dataframe.js | 1 - 1 file changed, 1 deletion(-) diff --git a/dataframe.js b/dataframe.js index 27bfdcf..f9e1163 100644 --- a/dataframe.js +++ b/dataframe.js @@ -1,6 +1,5 @@ /* an attempt to wrap dataframe access in an abstract interface that should work for other data too (?) - note: test on array-of-records data! */ var dataframe = { cols: function(data) { From d38553799b6bc4a2f9d805e783b8eaff0ae5df6e Mon Sep 17 00:00:00 2001 From: Gordon Woodhull Date: Thu, 16 Jan 2014 00:32:08 -0500 Subject: [PATCH 3/3] fix size accessor --- dcplot.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dcplot.js b/dcplot.js index 864c5df..7626cba 100644 --- a/dcplot.js +++ b/dcplot.js @@ -817,7 +817,7 @@ function dcplot(frame, groupname, definition) { if(_.has(defn, 'wedge')) chart.keyAccessor(key_value(defn.wedge)); if(_.has(defn, 'size')) - chart.keyAccessor(key_value(defn.size)); + chart.valueAccessor(key_value(defn.size)); if(_.has(defn, 'radius')) chart.radius(defn.radius);