Use java.util.Base64 for encoding and decoding #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damieng
previously approved these changes
Mar 3, 2020
damieng
approved these changes
Mar 5, 2020
|
@jimmyjames Do you have a timeline for when you expect to release v4? |
|
Has this been included in any release yet? |
|
We've had to pause on v4 work, but there is good news. We are going to bump the min Java version to 8 in an upcoming minor release, prior to the end of the year (see #457 for more info). Once that is complete, this (and other changes that require Java 8) can be included in the current release stream. Given that, makes sense to open a new issue to apply this change on master once that Java 8 change is made, so created that in #461 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
These changes enable us to use standard Java Base64 encoding/decoding available since JDK8. This allows us to remove a third-party dependency, is more idiomatic Java, and may offer performance improvements over the Apache library.
commons-codecdependencyReferences
Testing
Tests updated to use
java.util.Base64encoding and decoding.Checklist