Fix date serialization for list/map claims #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyjames
commented
Mar 11, 2020
jimmyjames
commented
Mar 11, 2020
stevehobbsdev
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Custom list and map claims may include
java.util.Dateas well asjava.time.Instantvalues forNumericDatevalues. When serializing these lists/maps, we need to account forDatevalues and serialize to the number of seconds since the epoch.References
JWT Specification - NumericDate definition
Testing
Relevant tests updated to expect
java.util.Dateclaims to be serialized to the number of seconds since the epoch.Checklist