Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 9775a13

Browse files
jonathanp-oktaCopilot
andcommitted
fix: improve error handling and default values in debugger steps.
Co-authored-by: Copilot <[email protected]>
1 parent 2a57cef commit 9775a13

3 files changed

Lines changed: 14 additions & 10 deletions

File tree

app/api/code_to_token/route.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export async function POST(request: NextRequest) {
5959
} catch (error: unknown) {
6060
console.error("Error fetching token:", error);
6161
return NextResponse.json(
62-
{ message: error.message },
62+
{ message: error instanceof Error ? error.message : "An unexpected error occurred." },
6363
{ status: 500 },
6464
);
6565
}

src/features/debugger/components/steps/debugger-steps.component.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export const DebuggerSteps = () => {
5656

5757
const requestDataStepTwo: RequestData = useMemo(() => {
5858
return {
59-
url: debuggerStepsData.tokenEndpoint,
59+
url: debuggerStepsData.tokenEndpoint ?? "",
6060
method: "POST",
6161
isEditable: false,
6262
params: [
@@ -66,21 +66,21 @@ export const DebuggerSteps = () => {
6666
},
6767
{
6868
key: "client_id",
69-
value: authData?.clientID,
69+
value: authData?.clientID ?? "",
7070
isEditable: true,
7171
},
7272
{
7373
key: "client_secret",
74-
value: authData?.clientSecret,
74+
value: authData?.clientSecret ?? "",
7575
isEditable: true,
7676
},
7777
{
7878
key: "redirect_uri",
79-
value: authData?.redirectURI,
79+
value: authData?.redirectURI ?? "",
8080
},
8181
{
8282
key: "code",
83-
value: authData?.authCode
83+
value: authData?.authCode ?? ""
8484
}
8585
],
8686
};
@@ -97,7 +97,7 @@ export const DebuggerSteps = () => {
9797
label: "Exchange Code from Token",
9898
render: () => (
9999
<StepTwo
100-
authCode={authData?.authCode}
100+
authCode={authData?.authCode ?? ""}
101101
requestData={requestDataStepTwo}
102102
setDebuggerStepsData={setDebuggerStepsData}
103103
setCurrentStepIndex={setCurrentStepIndex}

src/features/debugger/components/steps/step-two/step-two.component.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export const StepTwo = ({
2020
const [exchangeResult, setExchangeResult] = useState<string | null>(null);
2121
const [errorMessage, setErrorMessage] = useState<string | null>(null);
2222
const bodyFromRequestData = () => {
23-
const body = {
23+
const body: Record<string, string> = {
2424
tokenEndpoint: requestData.url,
2525
};
2626
requestData.params.forEach((param) => {
@@ -59,9 +59,13 @@ export const StepTwo = ({
5959
const statusString = `HTTP/1.1 ${data.result.response.statusCode}`;
6060
const jsonResponseString = `Content-Type: application/json\n${JSON.stringify(result, null, 2)}`;
6161
setExchangeResult(`${statusString}\n${jsonResponseString}`);
62-
} catch (error) {
62+
} catch (error: unknown) {
6363
const statusString = `HTTP/1.1 500`;
64-
const [errorTitle, errorDescription] = error.message.split(":");
64+
const message =
65+
error instanceof Error
66+
? error.message
67+
: "Error in exchange, please try again";
68+
const [errorTitle, errorDescription] = message.split(":");
6569
const errorObject = {
6670
error: errorTitle ? errorTitle : "Error",
6771
error_description: errorDescription

0 commit comments

Comments
 (0)