add in destroy and terminatePendingState as default

vanessayuenn · vanessayuenn · commit dd23f0a87865 · 2019-02-26T17:58:31.000+08:00
diff --git a/lib/items/changed-file-item.js b/lib/items/changed-file-item.js
@@ -48,17 +48,6 @@ export default class ChangedFileItem extends ItemComponent {
     return title;
   }
 
-  terminatePendingState() {
-    if (!this.hasTerminatedPendingState) {
-      this.emitter.emit('did-terminate-pending-state');
-      this.hasTerminatedPendingState = true;
-    }
-  }
-
-  onDidTerminatePendingState(callback) {
-    return this.emitter.on('did-terminate-pending-state', callback);
-  }
-
   render() {
     const repository = this.props.workdirContextPool.getContext(this.props.workingDirectory).getRepository();
 
diff --git a/lib/items/github-tab-item.js b/lib/items/github-tab-item.js
@@ -60,4 +60,12 @@ export default class GitHubTabItem extends ItemComponent {
   restoreFocus() {
     // No-op
   }
+
+  destroy() {
+    return false;
+  }
+
+  terminatePendingState() {
+    return false;
+  }
 }
diff --git a/lib/items/item-component.js b/lib/items/item-component.js
@@ -38,6 +38,17 @@ export default class ItemComponent extends React.Component {
     return this.emitter.on('did-destroy', callback);
   }
 
+  terminatePendingState() {
+    if (!this.hasTerminatedPendingState) {
+      this.emitter.emit('did-terminate-pending-state');
+      this.hasTerminatedPendingState = true;
+    }
+  }
+
+  onDidTerminatePendingState(callback) {
+    return this.emitter.on('did-terminate-pending-state', callback);
+  }
+
   serialize() {
     return {};
   }

Original file line number	Diff line number	Diff line change
`@@ -60,4 +60,12 @@ export default class GitHubTabItem extends ItemComponent {`
`60`	`60`	`restoreFocus() {`
`61`	`61`	`// No-op`
`62`	`62`	`}`
	`63`	`+`
	`64`	`+ destroy() {`
	`65`	`+ return false;`
	`66`	`+ }`
	`67`	`+`
	`68`	`+ terminatePendingState() {`
	`69`	`+ return false;`
	`70`	`+ }`
`63`	`71`	`}`