Adapt for couchbase 4.0.0 #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Darn, I'm not sure how I missed this all this time. I like what's here. I'm working on adding health checks in #2. My thinking is to wrap that up, then resolve the conflicts I've created against this and integrate the changes in https://github.com/misterbisson/triton-couchbase/pull/2/files#diff-c51d61b06f43189c9c52d541086bd1b0, then this can become the new default. |
Contributor
Author
|
For the couchbase benchmarking, we have both versions of CB. Do we want to maybe update this so that we can build either, or perhaps just keep this on its own branch? |
This was referenced Oct 12, 2015
Contributor
|
This is part of #5 |
misterbisson
added a commit
that referenced
this pull request
Oct 13, 2015
Merged
Contributor
|
Closing this in favor of #8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@misterbisson @max123 this PR makes this Docker container work for couchbase 4.0. It also includes ensuring that the data, query, and index services are all up and running on all nodes during cluster-init and add-node steps.