Couchbase 4 image #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I started to do #7, but backed off to keep it simple
Closed
bin/triton-bootstrap
Outdated
Contributor
There was a problem hiding this comment.
it looks like we're using -u to authenticate here. do we need these querystring params? And if so, should we swap them for the values in $COUCHBASE_USER:$COUCHBASE_PASS?
Contributor
Author
There was a problem hiding this comment.
This is the moment that we're adding an unconfigured node to an already configured cluster. So we have to speak to the configured cluster using the user selected u/p, but tell it to add the new node using the factory default u/p.
It's worth adding that as a code comment, good call.
Contributor
|
LGTM. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in github at
misterbisson/triton-couchbase:enterprise-4.0.0-r1. The https://github.com/misterbisson/clustered-couchbase-in-containers project tests successfully with that tag.