Add additional headers #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, X-Real-IP, X-Forwarded-For
tgross
reviewed
Nov 7, 2016
| "interfaces": ["eth0"] | ||
| }, | ||
| { | ||
| "name": "nginx-public-ssl", |
Contributor
There was a problem hiding this comment.
I'm not sure I understand this bit: why do we have two health checks of the same port?
Contributor
Author
There was a problem hiding this comment.
One test is on the private interface, one is on the public interface.
Contributor
There was a problem hiding this comment.
Gotcha, and I'm seeing that I also missed that one does the acme init too.
Contributor
|
For some reason we never merged this. Any reason not to @jasonpincin @misterbisson? |
Contributor
Author
|
No reason other than maybe I didn't see a LGTM? |
Contributor
|
🏡 🚶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional "best practice" headers on the proxied request:
X-Forwarded-ProtoX-Real-IPX-Forwarded-ForAlso removed some redundancy within the config to further simplify and streamline it.