Revert "Fix Collection::implode with \Stringable objects (laravel#54630)" (laravel#54691)

crynobone · web-flow · commit ca54da6fa17a · 2025-02-19T09:59:05.000-06:00
This reverts commit 9626c3d.
diff --git a/src/Illuminate/Collections/Collection.php b/src/Illuminate/Collections/Collection.php
@@ -628,7 +628,7 @@ public function implode($value, $glue = null)
 
         $first = $this->first();
 
-        if (is_array($first) || (is_object($first) && ! $first instanceof \Stringable)) {
+        if (is_array($first) || (is_object($first) && ! $first instanceof Stringable)) {
             return implode($glue ?? '', $this->pluck($value)->all());
         }
 
diff --git a/tests/Support/SupportCollectionTest.php b/tests/Support/SupportCollectionTest.php
@@ -24,7 +24,6 @@
 use PHPUnit\Framework\TestCase;
 use ReflectionClass;
 use stdClass;
-use Symfony\Component\String\ByteString;
 use Symfony\Component\VarDumper\VarDumper;
 use Traversable;
 use UnexpectedValueException;
@@ -2332,13 +2331,6 @@ public function testImplode($collection)
         $this->assertSame('taylor-foo,dayle-bar', $data->implode(fn ($user) => $user['name'].'-'.$user['email'], ','));
     }
 
-    #[DataProvider('collectionClassProvider')]
-    public function testImplodeStringable($collection)
-    {
-        $data = new $collection([new ByteString('taylor'), new ByteString('dayle')]);
-        $this->assertSame('taylordayle', $data->implode(''));
-    }
-
     #[DataProvider('collectionClassProvider')]
     public function testTake($collection)
     {

Original file line number	Diff line number	Diff line change
`@@ -628,7 +628,7 @@ public function implode($value, $glue = null)`
`628`	`628`
`629`	`629`	`$first = $this->first();`
`630`	`630`
`631`		`- if (is_array($first) \|\| (is_object($first) && ! $first instanceof \Stringable)) {`
	`631`	`+ if (is_array($first) \|\| (is_object($first) && ! $first instanceof Stringable)) {`
`632`	`632`	`return implode($glue ?? '', $this->pluck($value)->all());`
`633`	`633`	`}`
`634`	`634`