fix/when s_preservePathSeparators enabled #3619
Merged
+44
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
reviewed
Nov 10, 2025
|
|
||
| auto putObjectRequest = PutObjectRequest() | ||
| .WithBucket("velvetunderground") | ||
| .WithKey("////stephanie////says////////////that////////she//wants///////to/know.txt"); |
Contributor
There was a problem hiding this comment.
i dont think we want to remove this test case. Its still a valuable test case, i think we just want to add more test cases. additionally can you add a test case for .txt// to make sure that it works for many slashes and not just one
25e0bcf to
58f1f33
Compare
sbiscigl
approved these changes
Nov 11, 2025
| } | ||
|
|
||
| if (m_pathSegments.empty() || m_pathHasTrailingSlash) | ||
| if (m_pathSegments.empty()) |
Contributor
There was a problem hiding this comment.
why did you change this?
if (m_pathSegments.empty() || m_pathHasTrailingSlash)
{
path.push_back('/');
}it is functionally the same as
if (m_pathSegments.empty())
{
path.push_back('/');
}
else if (m_pathHasTrailingSlash)
{
path.push_back('/');
}
Contributor
Author
There was a problem hiding this comment.
You're right - this was a mistake while trying to change the code back. Updating now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3618
Description of changes: Fixed trailing slash preservation logic in URI parsing to correctly handle both S3 object keys with trailing slashes and SNS signature compatibility when s_
preservePathSeparators is enabled.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.