Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Docs: change module name in shared logger example to match import #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
peterschutt opened this issue Jul 7, 2022 · 3 comments
Closed
1 task done

Docs: change module name in shared logger example to match import #1285

peterschutt opened this issue Jul 7, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@peterschutt
Copy link
Contributor

peterschutt commented Jul 7, 2022 •
edited
Loading

What were you searching in the docs?

Reading example.

Is this related to an existing documentation section?

https://github.com/awslabs/aws-lambda-powertools-python/blob/2ded8a6481836da7bdccf7a005fbe31bdf9dbd68/docs/core/logger.md?plain=1#L301-L305

How can we improve?

Always a great experience with this lib, thanks!

Got a suggestion in mind?

Possibly this should change to === "logger_reuse_payment.py" so that the tab title lines up with the module import name.

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@peterschutt peterschutt added documentation Improvements or additions to documentation triage Pending triage from maintainers labels Jul 7, 2022
@heitorlessa
Copy link
Contributor

I'm glad you brought it up, as I thought it would've been too much of an OCD from my side :D Changing all snippets to match their filenames so it's easier for anyone to go and explore.

@heitorlessa heitorlessa mentioned this issue Jul 8, 2022
Merged
7 tasks
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Jul 8, 2022
@heitorlessa
Copy link
Contributor

Now live ;) Closing and thanks again for flagging it

image

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heitorlessa @peterschutt