Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Maintenance: Shorten feedback loop in E2E tests upon function invocation errors #2911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
heitorlessa opened this issue Aug 2, 2023 · 2 comments · Fixed by #2912
Closed
1 of 2 tasks

Maintenance: Shorten feedback loop in E2E tests upon function invocation errors #2911

heitorlessa opened this issue Aug 2, 2023 · 2 comments · Fixed by #2912
Labels
internal Maintenance changes triage Pending triage from maintainers

Comments

@heitorlessa
Copy link
Contributor

heitorlessa commented Aug 2, 2023 •
edited
Loading

Why is this needed?

Last night we had a regression in the new Metrics provider (#2909) and debugging took longer than necessary since Logs faced eventual consistency errors.

Our E2E utils get_lambda_response doesn't fail fast if the invoked function had an error it couldn't handle, since it's synchronous.

image

Which area does this relate to?

No response

Solution

Add a new option to get_lambda_response to fail fast by default unless required to ignore an error (e.g., testing race conditions, timeouts, etc.).

Acknowledgment
@heitorlessa heitorlessa added triage Pending triage from maintainers internal Maintenance changes labels Aug 2, 2023
@heitorlessa heitorlessa mentioned this issue Aug 2, 2023
Merged
9 tasks
@heitorlessa heitorlessa linked a pull request Aug 2, 2023 that will close this issue
refactor(e2e): support fail fast in get_lambda_response #2912
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from Triage to Coming soon in Powertools for AWS Lambda (Python) Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Aug 2, 2023
@leandrodamascena leandrodamascena moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Aug 15, 2023
@github-actions
Copy link
Contributor

This is now released under 2.23.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal Maintenance changes triage Pending triage from maintainers
Projects
Powertools for AWS Lambda (Python)
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(e2e): support fail fast in get_lambda_response heitorlessa/aws-lambda-powertools-python
1 participant
@heitorlessa