Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: awslabs/aws-elasticache-cluster-client-memcached-for-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.2.2
Choose a base ref
...
head repository: awslabs/aws-elasticache-cluster-client-memcached-for-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.2.3
Choose a head ref
  • 9 commits
  • 9 files changed
  • 7 contributors

Commits on Apr 3, 2024

  1. Configuration menu
    Copy the full SHA
    262991a View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2025

  1. Fix ConcurrentModificationException for getStats Op

    If the result of MemcachedClient.getStats() is immediately iterated
    over, a ConcurrentModificationException can be thrown if the
    operationTimeout value has been exceeded before mutations to the
    Map have completed.
    
    Example:
    
    * blatch.await(operationTimeout, TimeUnit.MILLISECONDS); returns
      false after waiting `operationTimeout`, resulting in
      MemcachedClient.getStats() returning the `rv` Map.
    * While the caller starts to iterate over the Map, the
      StatsOperation.Callback's gotStat mutates the Map, resulting in
      a ConcurrentModificationException.
    
    How to Reproduce:
    
    ```
    public static void main(String[] args) throws Exception {
      ConnectionFactory connectionFactory = new ConnectionFactoryBuilder()
        .setProtocol(Protocol.TEXT)
        .setFailureMode(FailureMode.Cancel)
        .setOpTimeout(1)
        .build();
      MemcachedClient client = new MemcachedClient(
        connectionFactory, AddrUtil.getAddresses("localhost:11211"));
      while(true) {
        Map<SocketAddress, Map<String, String>> allStats = client.getStats();
        if (allStats.isEmpty()) continue;
        Map<String, String> stats = allStats.entrySet().iterator().next().getValue();
        for(Entry<String,String> stat : stats.entrySet()) {
          System.out.println(stat.getKey() + " => " + stat.getValue());
        }
      }
    }
    ```
    
    Output:
    
    ```
    2017-11-02 14:37:52.269 WARN net.spy.memcached.MemcachedClient:  Unsuccessful stat fetch: {OperationStatus success=false:  timed out}
    Exception in thread "main" java.util.ConcurrentModificationException
    	at java.util.HashMap$HashIterator.nextEntry(HashMap.java:922)
    	at java.util.HashMap$EntryIterator.next(HashMap.java:962)
    	at java.util.HashMap$EntryIterator.next(HashMap.java:960)
    	at com.xxx.xxx.xxx.xxx.xxx.StatsBug.main(StatsBug.java:31)
      ```
    
    Notes:
    
    * Written in a way to be completely backwards compatible.
    * Guarantees that the caller only sees the entire stats result for a
      SocketAddress, or no result at all. Converting the Maps to
      ConcurrentHashMaps alone would result in partially complete
      Maps.
    
    Change-Id: If51e074a13f809581c8bad119b393edb2c4d4788
    Reviewed-on: http://review.couchbase.org/91953
    Reviewed-by: Matt Ingenthron <[email protected]>
    Tested-by: Matt Ingenthron <[email protected]>
    amcrn authored and QuChen88 committed Jan 31, 2025
    Configuration menu
    Copy the full SHA
    a215b82 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2025

  1. Configuration menu
    Copy the full SHA
    abd3ba5 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #46 from YueTang-Vanessa/master

    Update README with troubleshooting Memcached client issues
    QuChen88 authored Feb 24, 2025
    Configuration menu
    Copy the full SHA
    c57e78c View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2025

  1. Configuration menu
    Copy the full SHA
    2ecbf93 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #47 from EranAs/fix-reconnects-on-dns-failures

    fix: reconnects keeps retrying on DNS resolution failures
    QuChen88 authored Mar 12, 2025
    Configuration menu
    Copy the full SHA
    ed02a25 View commit details
    Browse the repository at this point in the history
  3. Propagate TimeoutExceptions from OperationFutures as `OperationTi…

    …meoutException`s
    
    fixes #48
    Jovan Attisha 🥃 committed Mar 12, 2025
    Configuration menu
    Copy the full SHA
    ea8a14f View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2025

  1. Merge pull request #49 from jattisha/master

    Propagate `TimeoutException`s from `OperationFuture`s as `OperationTimeoutException`s
    chinguyen21 authored Apr 26, 2025
    Configuration menu
    Copy the full SHA
    6c22307 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2025

  1. Bump version to 1.2.3

    YueTang-Vanessa committed Jun 30, 2025
    Configuration menu
    Copy the full SHA
    48d18f4 View commit details
    Browse the repository at this point in the history
Loading