Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 9097c69

Browse files
ajtmsajtms
authored
Resolving 2023-05-01 swagger validation errors for Azure Firewall examples. (Azure#27403)
* Added missing id property to some example resources. Added headers with locations to long-running operation examples. * Added some missing information on some response object typings regarding the location property used in long-running operations. * Fixed a possible typo 'azure-async-operation' to 'azure-asyncoperation' (removed a hyphen). * Ran prettier against azureFirewall.json
1 parent 9381354 commit 9097c69

19 files changed

+90
-7
lines changed

‎specification/network/resource-manager/Microsoft.Network/stable/2023-05-01/azureFirewall.json‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,13 @@
6565
],
6666
"responses": {
6767
"202": {
68-
"description": "Accepted and the operation will complete asynchronously."
68+
"description": "Accepted and the operation will complete asynchronously.",
69+
"headers": {
70+
"Location": {
71+
"description": "The URL of the resource used to check the status of the asynchronous operation.",
72+
"type": "string"
73+
}
74+
}
6975
},
7076
"204": {
7177
"description": "Request successful. Resource with the specified name does not exist."
@@ -484,6 +490,7 @@
484490
"description": "Accepted and the operation will complete asynchronously.",
485491
"headers": {
486492
"Location": {
493+
"description": "The URL of the resource used to check the status of the asynchronous operation.",
487494
"type": "string"
488495
}
489496
}

‎specification/network/resource-manager/Microsoft.Network/stable/2023-05-01/examples/AzureFirewallDelete.json‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,11 @@
77
},
88
"responses": {
99
"200": {},
10-
"202": {},
10+
"202": {
11+
"headers": {
12+
"location": "https://management.azure.com/subscriptions/subid/providers/Microsoft.Network/locations/eastus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2023-05-01&t=1234567890&c=abc-123&s=def-456&h=xyz-789"
13+
}
14+
},
1115
"204": {}
1216
}
1317
}

‎specification/network/resource-manager/Microsoft.Network/stable/2023-05-01/examples/AzureFirewallGet.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
"applicationRuleCollections": [
4545
{
4646
"name": "apprulecoll",
47+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/applicationRuleCollections/apprulecoll",
4748
"properties": {
4849
"priority": 110,
4950
"action": {
@@ -74,6 +75,7 @@
7475
"natRuleCollections": [
7576
{
7677
"name": "natrulecoll",
78+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/natRuleCollections/natrulecoll",
7779
"properties": {
7880
"priority": 112,
7981
"action": {
@@ -123,6 +125,7 @@
123125
"networkRuleCollections": [
124126
{
125127
"name": "netrulecoll",
128+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/networkRuleCollections/netrulecoll",
126129
"properties": {
127130
"priority": 112,
128131
"action": {

‎specification/network/resource-manager/Microsoft.Network/stable/2023-05-01/examples/AzureFirewallGetWithAdditionalProperties.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
"applicationRuleCollections": [
4545
{
4646
"name": "apprulecoll",
47+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/applicationRuleCollections/apprulecoll",
4748
"properties": {
4849
"priority": 110,
4950
"action": {
@@ -74,6 +75,7 @@
7475
"natRuleCollections": [
7576
{
7677
"name": "natrulecoll",
78+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/natRuleCollections/natrulecoll",
7779
"properties": {
7880
"priority": 112,
7981
"action": {
@@ -123,6 +125,7 @@
123125
"networkRuleCollections": [
124126
{
125127
"name": "netrulecoll",
128+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/networkRuleCollections/netrulecoll",
126129
"properties": {
127130
"priority": 112,
128131
"action": {

‎specification/network/resource-manager/Microsoft.Network/stable/2023-05-01/examples/AzureFirewallGetWithIpGroups.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
"applicationRuleCollections": [
4545
{
4646
"name": "apprulecoll",
47+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/applicationRuleCollections/apprulecoll",
4748
"properties": {
4849
"priority": 110,
4950
"action": {
@@ -73,6 +74,7 @@
7374
"natRuleCollections": [
7475
{
7576
"name": "natrulecoll",
77+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/natRuleCollections/natrulecoll",
7678
"properties": {
7779
"priority": 112,
7880
"action": {
@@ -122,6 +124,7 @@
122124
"networkRuleCollections": [
123125
{
124126
"name": "netrulecoll",
127+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/networkRuleCollections/netrulecoll",
125128
"properties": {
126129
"priority": 112,
127130
"action": {

‎specification/network/resource-manager/Microsoft.Network/stable/2023-05-01/examples/AzureFirewallGetWithMgmtSubnet.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
"applicationRuleCollections": [
5959
{
6060
"name": "apprulecoll",
61+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/applicationRuleCollections/apprulecoll",
6162
"properties": {
6263
"priority": 110,
6364
"action": {
@@ -88,6 +89,7 @@
8889
"natRuleCollections": [
8990
{
9091
"name": "natrulecoll",
92+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/natRuleCollections/natrulecoll",
9193
"properties": {
9294
"priority": 112,
9395
"action": {
@@ -137,6 +139,7 @@
137139
"networkRuleCollections": [
138140
{
139141
"name": "netrulecoll",
142+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/networkRuleCollections/netrulecoll",
140143
"properties": {
141144
"priority": 112,
142145
"action": {

‎specification/network/resource-manager/Microsoft.Network/stable/2023-05-01/examples/AzureFirewallGetWithZones.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
"applicationRuleCollections": [
4949
{
5050
"name": "apprulecoll",
51+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/applicationRuleCollections/apprulecoll",
5152
"properties": {
5253
"priority": 110,
5354
"action": {
@@ -78,6 +79,7 @@
7879
"natRuleCollections": [
7980
{
8081
"name": "natrulecoll",
82+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/natRuleCollections/natrulecoll",
8183
"properties": {
8284
"priority": 112,
8385
"action": {
@@ -127,6 +129,7 @@
127129
"networkRuleCollections": [
128130
{
129131
"name": "netrulecoll",
132+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/networkRuleCollections/netrulecoll",
130133
"properties": {
131134
"priority": 112,
132135
"action": {

‎specification/network/resource-manager/Microsoft.Network/stable/2023-05-01/examples/AzureFirewallListByResourceGroup.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@
5555
"applicationRuleCollections": [
5656
{
5757
"name": "apprulecoll",
58+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/applicationRuleCollections/apprulecoll",
5859
"properties": {
5960
"priority": 110,
6061
"action": {
@@ -85,6 +86,7 @@
8586
"natRuleCollections": [
8687
{
8788
"name": "natrulecoll",
89+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/natRuleCollections/natrulecoll",
8890
"properties": {
8991
"priority": 112,
9092
"action": {
@@ -134,6 +136,7 @@
134136
"networkRuleCollections": [
135137
{
136138
"name": "netrulecoll",
139+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/networkRuleCollections/netrulecoll",
137140
"properties": {
138141
"priority": 112,
139142
"action": {

‎specification/network/resource-manager/Microsoft.Network/stable/2023-05-01/examples/AzureFirewallListBySubscription.json‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
"applicationRuleCollections": [
5555
{
5656
"name": "apprulecoll",
57+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/applicationRuleCollections/apprulecoll",
5758
"properties": {
5859
"priority": 110,
5960
"action": {
@@ -84,6 +85,7 @@
8485
"natRuleCollections": [
8586
{
8687
"name": "natrulecoll",
88+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/natRuleCollections/natrulecoll",
8789
"properties": {
8890
"priority": 112,
8991
"action": {
@@ -133,6 +135,7 @@
133135
"networkRuleCollections": [
134136
{
135137
"name": "netrulecoll",
138+
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/azureFirewalls/azurefirewall/networkRuleCollections/netrulecoll",
136139
"properties": {
137140
"priority": 112,
138141
"action": {

‎specification/network/resource-manager/Microsoft.Network/stable/2023-05-01/examples/AzureFirewallListLearnedIPPrefixes.json‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@
66
"azureFirewallName": "azureFirewall1"
77
},
88
"responses": {
9-
"202": {},
9+
"202": {
10+
"headers": {
11+
"location": "https://management.azure.com/subscriptions/subid/providers/Microsoft.Network/locations/eastus/operationResults/00000000-0000-0000-0000-000000000000?api-version=2023-05-01&t=638385313328642925&c=abc-123&s=def-456&h=xyz-789"
12+
}
13+
},
1014
"200": {
1115
"body": {
1216
"ipPrefixes": [

0 commit comments

Comments
 (0)