test: add test on import { "foo" }

JLHwung · JLHwung · commit 6e0d7bf88295 · 2020-10-09T14:36:53.000-04:00
diff --git a/packages/babel-parser/src/parser/error-message.js b/packages/babel-parser/src/parser/error-message.js
@@ -56,7 +56,7 @@ export const ErrorMessages = Object.freeze({
     "Illegal 'use strict' directive in function with non-simple parameter list",
   IllegalReturn: "'return' outside of function",
   ImportBindingIsString:
-    "Can not use string literal as an imported binding.\n- Did you mean `import { %0 as foo }`?",
+    'Can not use string literal as an imported binding.\n- Did you mean `import { "%0" as foo }`?',
   ImportCallArgumentTrailingComma:
     "Trailing comma is disallowed inside import(...) arguments",
   ImportCallArity: "import() requires exactly %0",
diff --git a/packages/babel-parser/src/parser/statement.js b/packages/babel-parser/src/parser/statement.js
@@ -2261,7 +2261,7 @@ export default class StatementParser extends ExpressionParser {
         throw this.raise(
           specifier.start,
           Errors.ImportBindingIsString,
-          imported.extra.raw,
+          imported.value,
         );
       }
       this.checkReservedWord(imported.name, specifier.start, true, true);
diff --git a/packages/babel-parser/test/fixtures/experimental/module-string-names/import-local-is-string/input.js b/packages/babel-parser/test/fixtures/experimental/module-string-names/import-local-is-string/input.js
@@ -0,0 +1 @@
+import { "foo" } from "foo";
diff --git a/packages/babel-parser/test/fixtures/experimental/module-string-names/import-local-is-string/options.json b/packages/babel-parser/test/fixtures/experimental/module-string-names/import-local-is-string/options.json
@@ -0,0 +1,7 @@
+{
+  "sourceType": "module",
+  "plugins": [
+    "moduleStringNames"
+  ],
+  "throws": "Can not use string literal as an imported binding.\n- Did you mean `import { \"foo\" as foo }`? (1:9)"
+}

Original file line number	Diff line number	Diff line change
`@@ -2261,7 +2261,7 @@ export default class StatementParser extends ExpressionParser {`
`2261`	`2261`	`throw this.raise(`
`2262`	`2262`	`specifier.start,`
`2263`	`2263`	`Errors.ImportBindingIsString,`
`2264`		`- imported.extra.raw,`
	`2264`	`+ imported.value,`
`2265`	`2265`	`);`
`2266`	`2266`	`}`
`2267`	`2267`	`this.checkReservedWord(imported.name, specifier.start, true, true);`