Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit f9a7db2

Browse files
liuxingbaoyuliuxingbaoyu
committed
review
1 parent 7a9a481 commit f9a7db2

7 files changed

Lines changed: 62 additions & 53 deletions

File tree

‎packages/babel-traverse/scripts/generators/asserts.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ export default function generateAsserts() {
88
import type * as t from "@babel/types";
99
import type NodePath from "../index";
1010
11-
type Opts<Object> = Partial<{
12-
[Prop in keyof Object]: Object[Prop] extends t.Node
13-
? t.Node | Object[Prop]
14-
: Object[Prop] extends t.Node[]
15-
? t.Node[] | Object[Prop]
16-
: Object[Prop];
11+
type Opts<Obj> = Partial<{
12+
[Prop in keyof Obj]: Obj[Prop] extends t.Node
13+
? t.Node
14+
: Obj[Prop] extends t.Node[]
15+
? t.Node[]
16+
: Obj[Prop];
1717
}>;
1818
1919
export interface NodePathAssertions {`;

‎packages/babel-traverse/scripts/generators/validators.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ import type * as t from "@babel/types";
99
import type NodePath from "../index";
1010
import type { VirtualTypeNodePathValidators } from "../lib/virtual-types-validator";
1111
12-
type Opts<Object> = Partial<{
13-
[Prop in keyof Object]: Object[Prop] extends t.Node
14-
? t.Node | Object[Prop]
15-
: Object[Prop] extends t.Node[]
16-
? t.Node[] | Object[Prop]
17-
: Object[Prop];
12+
type Opts<Obj> = Partial<{
13+
[Prop in keyof Obj]: Obj[Prop] extends t.Node
14+
? t.Node
15+
: Obj[Prop] extends t.Node[]
16+
? t.Node[]
17+
: Obj[Prop];
1818
}>;
1919
2020
interface BaseNodePathValidators {

‎packages/babel-traverse/src/path/generated/asserts.d.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
import type * as t from "@babel/types";
66
import type NodePath from "../index";
77

8-
type Opts<Object> = Partial<{
9-
[Prop in keyof Object]: Object[Prop] extends t.Node
10-
? t.Node | Object[Prop]
11-
: Object[Prop] extends t.Node[]
12-
? t.Node[] | Object[Prop]
13-
: Object[Prop];
8+
type Opts<Obj> = Partial<{
9+
[Prop in keyof Obj]: Obj[Prop] extends t.Node
10+
? t.Node
11+
: Obj[Prop] extends t.Node[]
12+
? t.Node[]
13+
: Obj[Prop];
1414
}>;
1515

1616
export interface NodePathAssertions {

‎packages/babel-traverse/src/path/generated/validators.d.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ import type * as t from "@babel/types";
66
import type NodePath from "../index";
77
import type { VirtualTypeNodePathValidators } from "../lib/virtual-types-validator";
88

9-
type Opts<Object> = Partial<{
10-
[Prop in keyof Object]: Object[Prop] extends t.Node
11-
? t.Node | Object[Prop]
12-
: Object[Prop] extends t.Node[]
13-
? t.Node[] | Object[Prop]
14-
: Object[Prop];
9+
type Opts<Obj> = Partial<{
10+
[Prop in keyof Obj]: Obj[Prop] extends t.Node
11+
? t.Node
12+
: Obj[Prop] extends t.Node[]
13+
? t.Node[]
14+
: Obj[Prop];
1515
}>;
1616

1717
interface BaseNodePathValidators {

‎packages/babel-traverse/src/path/lib/virtual-types-validator.ts‎

Lines changed: 26 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,14 @@ import type * as t from "@babel/types";
2626
const { isCompatTag } = react;
2727
import type { VirtualTypeAliases } from "./virtual-types";
2828

29-
type Opts<Object> = Partial<{
30-
[Prop in keyof Object]: Object[Prop] extends t.Node
31-
? t.Node | Object[Prop]
32-
: Object[Prop] extends t.Node[]
33-
? t.Node[] | Object[Prop]
34-
: Object[Prop];
29+
type Opts<Obj> = Partial<{
30+
[Prop in keyof Obj]: Obj[Prop] extends t.Node
31+
? t.Node
32+
: Obj[Prop] extends t.Node[]
33+
? t.Node[]
34+
: Obj[Prop];
3535
}>;
36+
3637
export interface VirtualTypeNodePathValidators {
3738
isBindingIdentifier<T extends t.Node>(
3839
this: NodePath<T>,
@@ -210,15 +211,23 @@ export function isForAwaitStatement(this: NodePath): boolean {
210211
return isForOfStatement(this.node, { await: true });
211212
}
212213

213-
// TODO: Remove in Babel 8
214-
export function isExistentialTypeParam(this: NodePath): void {
215-
throw new Error(
216-
"`path.isExistentialTypeParam` has been renamed to `path.isExistsTypeAnnotation()` in Babel 7.",
217-
);
218-
}
219-
220-
export function isNumericLiteralTypeAnnotation(this: NodePath): void {
221-
throw new Error(
222-
"`path.isNumericLiteralTypeAnnotation()` has been renamed to `path.isNumberLiteralTypeAnnotation()` in Babel 7.",
223-
);
214+
if (!process.env.BABEL_8_BREAKING) {
215+
if (!USE_ESM) {
216+
// eslint-disable-next-line no-restricted-globals
217+
exports.isExistentialTypeParam = function isExistentialTypeParam(
218+
this: NodePath,
219+
): void {
220+
throw new Error(
221+
"`path.isExistentialTypeParam` has been renamed to `path.isExistsTypeAnnotation()` in Babel 7.",
222+
);
223+
};
224+
225+
// eslint-disable-next-line no-restricted-globals
226+
exports.isNumericLiteralTypeAnnotation =
227+
function isNumericLiteralTypeAnnotation(this: NodePath): void {
228+
throw new Error(
229+
"`path.isNumericLiteralTypeAnnotation()` has been renamed to `path.isNumberLiteralTypeAnnotation()` in Babel 7.",
230+
);
231+
};
232+
}
224233
}

‎packages/babel-types/scripts/generators/validators.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,12 @@ import shallowEqual from "../../utils/shallowEqual";
8181
import type * as t from "../..";
8282
import deprecationWarning from "../../utils/deprecationWarning";
8383
84-
type Opts<Object> = Partial<{
85-
[Prop in keyof Object]: Object[Prop] extends t.Node
86-
? t.Node | Object[Prop]
87-
: Object[Prop] extends t.Node[]
88-
? t.Node[] | Object[Prop]
89-
: Object[Prop];
84+
type Opts<Obj> = Partial<{
85+
[Prop in keyof Obj]: Obj[Prop] extends t.Node
86+
? t.Node
87+
: Obj[Prop] extends t.Node[]
88+
? t.Node[]
89+
: Obj[Prop];
9090
}>;
9191
9292
`;

‎packages/babel-types/src/validators/generated/index.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ import shallowEqual from "../../utils/shallowEqual";
99
import type * as t from "../..";
1010
import deprecationWarning from "../../utils/deprecationWarning";
1111

12-
type Opts<Object> = Partial<{
13-
[Prop in keyof Object]: Object[Prop] extends t.Node
14-
? t.Node | Object[Prop]
15-
: Object[Prop] extends t.Node[]
16-
? t.Node[] | Object[Prop]
17-
: Object[Prop];
12+
type Opts<Obj> = Partial<{
13+
[Prop in keyof Obj]: Obj[Prop] extends t.Node
14+
? t.Node
15+
: Obj[Prop] extends t.Node[]
16+
? t.Node[]
17+
: Obj[Prop];
1818
}>;
1919

2020
export function isArrayExpression(

0 commit comments

Comments
 (0)