replace .substr(a,b) with .substring(a,a+b)

archmoj · archmoj · commit 0e54e6c33d92 · 2022-03-17T22:06:59.000-04:00
diff --git a/package.json b/package.json
@@ -32,9 +32,10 @@
     "use-draftlogs": "node tasks/use_draftlogs.js",
     "empty-draftlogs": "node tasks/empty_draftlogs.js",
     "empty-dist": "node tasks/empty_dist.js",
-    "build": "npm run empty-dist && npm run preprocess && npm run find-strings && npm run bundle && npm run extra-bundles basic && npm run extra-bundles cartesian && npm run extra-bundles geo && npm run extra-bundles gl2d && npm run extra-bundles gl3d && npm run extra-bundles mapbox && npm run extra-bundles finance && npm run locales && npm run schema dist && npm run stats",
+    "build": "npm run empty-dist && npm run preprocess && npm run find-strings && npm run bundle && npm run extra-bundles basic && npm run extra-bundles cartesian && npm run extra-bundles geo && npm run extra-bundles gl2d && npm run extra-bundles gl3d && npm run extra-bundles mapbox && npm run extra-bundles finance && npm run locales && npm run schema dist && npm run replace-substr && npm run stats",
+    "replace-substr": "node ./tasks/replace_substr.js",
     "regl-codegen": "node devtools/regl_codegen/server.js",
-    "cibuild": "npm run empty-dist && npm run preprocess && node tasks/cibundle.js",
+    "cibuild": "npm run empty-dist && npm run preprocess && node tasks/cibundle.js && npm run replace-substr -- build",
     "watch": "node tasks/watch.js",
     "lint": "eslint --version && eslint .",
     "lint-fix": "eslint . --fix || true",
diff --git a/tasks/replace_substr.js b/tasks/replace_substr.js
@@ -0,0 +1,84 @@
+'use strict';
+
+// Replace .substr(a, ?b) with .substring(a, (a)+b)
+//
+// String.prototype.substr() is deprecated!
+// See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr
+
+var fs = require('fs');
+var allFolders = ['dist/'];
+if(process.argv.indexOf('build') !== -1) allFolders.push('build/');
+
+for(var k = 0; k < allFolders.length; k++) {
+    var folder = allFolders[k];
+    var allFilenames = fs.readdirSync(folder);
+
+    for(var i = 0; i < allFilenames.length; i++) {
+        var filename = allFilenames[i];
+        var len = filename.length;
+        if(filename.substring(len - 3) === '.js') {
+            var f = folder + filename;
+            var str = fs.readFileSync(f, {encoding: 'utf8', flag: 'r+'});
+            fs.writeFileSync(f, replaceSubstr(str), 'utf8');
+            console.log('Overwritten:' + f);
+        }
+    }
+}
+
+function replaceSubstr(str) {
+    var i0;
+    while(i0 !== -1) {
+        i0 = str.indexOf('.substr(');
+        if(i0 === -1) return str;
+
+        var args = [];
+        var text = '';
+        var k = 0;
+
+        // step into the function
+        var i = i0 + 7;
+        var p = 1; // open parentheses
+        while(p > 0) {
+            i++;
+
+            var c = str.charAt(i);
+            if(!c) break;
+            if(p === 1 && (
+                c === ',' ||
+                c === ')'
+            )) {
+                args[k++] = text;
+                text = '';
+            } else {
+                text += c;
+            }
+
+            if(c === '(') p++;
+            if(c === ')') p--;
+        }
+
+        // console.log(str.substring(i0, i + 1));
+        // console.log(args);
+
+        var startStr = args[0];
+        var lengthStr = args[1];
+        var out = '.substring(' + startStr;
+
+        if(lengthStr !== undefined) {
+            out += ',';
+            if(+startStr !== 0) {
+                out += '(' + startStr + ')+';
+            }
+            out += lengthStr;
+        }
+
+        out += ')';
+
+        // console.log(out)
+        // console.log('__');
+
+        str = str.substring(0, i0) + out + str.substring(i + 1);
+    }
+
+    return str;
+}
