fix box/violin multicategory on value axis edge cases

etpinard · etpinard · commit e0111d4918c3 · 2018-12-06T15:19:54.000-05:00
diff --git a/src/traces/box/defaults.js b/src/traces/box/defaults.js
@@ -48,12 +48,12 @@ function handleSampleDefaults(traceIn, traceOut, coerce, layout) {
             len = Math.min(Lib.minRowLength(x), Lib.minRowLength(y));
         } else {
             coerce('x0');
-            len = y.length;
+            len = Lib.minRowLength(y);
         }
     } else if(hasX) {
         defaultOrientation = 'h';
         coerce('y0');
-        len = x.length;
+        len = Lib.minRowLength(x);
     } else {
         traceOut.visible = false;
         return;
diff --git a/src/traces/violin/calc.js b/src/traces/violin/calc.js
@@ -123,8 +123,9 @@ function calcSpan(trace, cdi, valAxis, bandwidth) {
 
     function calcSpanItem(index) {
         var s = spanIn[index];
-        // TODO skip on multicategory val axis?
-        var sc = valAxis.d2c(s, 0, trace[cdi.valLetter + 'calendar']);
+        var sc = valAxis.type === 'multicategory' ?
+            valAxis.r2c(s) :
+            valAxis.d2c(s, 0, trace[cdi.valLetter + 'calendar']);
         return sc === BADNUM ? spanLoose[index] : sc;
     }
 
diff --git a/test/image/baselines/box-violin-multicategory-on-val-axis.png b/test/image/baselines/box-violin-multicategory-on-val-axis.png
diff --git a/test/image/mocks/box-violin-multicategory-on-val-axis.json b/test/image/mocks/box-violin-multicategory-on-val-axis.json
@@ -0,0 +1,38 @@
+{
+  "data": [
+    {
+      "type": "violin",
+      "x": [
+        [ "2016", "2016", "2016", "2016", "2016", "2016", "2016", "2016", "2016", "2016", "2016", "2016",
+          "2017", "2017", "2017", "2017", "2017", "2017", "2017", "2017", "2017", "2017", "2017", "2017",
+          "2018", "2018", "2018", "2018", "2018", "2018", "2018", "2018", "2018", "2018", "2018", "2018"
+        ],
+        [ "day 1", "day 1", "day 1", "day 1", "day 1", "day 1", "day 2",
+          "day 2", "day 2", "day 2", "day 2", "day 2", "day 1", "day 1",
+          "day 1", "day 1", "day 1", "day 1", "day 2", "day 2", "day 2",
+          "day 2", "day 2", "day 2", "day 1", "day 1", "day 1", "day 1",
+          "day 1", "day 1", "day 2", "day 2", "day 2", "day 2", "day 2", "day 2"
+        ]
+      ],
+      "span": [0, 5]
+    },
+    {
+      "type": "box",
+      "x": [
+        [ "2016", "2016", "2016", "2016", "2016", "2016", "2016", "2016", "2016", "2016", "2016", "2016",
+          "2017", "2017", "2017", "2017", "2017", "2017", "2017", "2017", "2017", "2017", "2017", "2017",
+          "2018", "2018", "2018", "2018", "2018", "2018", "2018", "2018", "2018", "2018", "2018", "2018"
+        ],
+        [ "day 1", "day 1", "day 1", "day 1", "day 1", "day 1", "day 2", "day 2",
+          "day 2", "day 2", "day 2", "day 2", "day 1", "day 1", "day 1", "day 1",
+          "day 1", "day 1", "day 2", "day 2", "day 2", "day 2", "day 2", "day 2",
+          "day 1", "day 1", "day 1", "day 1", "day 1", "day 1", "day 2", "day 2",
+          "day 2", "day 2", "day 2", "day 2"
+        ]
+      ]
+    }
+  ],
+  "layout": {
+    "showlegend": false
+  }
+}
