-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Open
Description
System details
Omarchy 3.2.x (current)
What's wrong?
Setting EDITOR=fresh in ~/.config/uwsm/default does not work when using the Omarchy menu to edit config files. The toast notification appears briefly but the editor never opens.
This is because omarchy-launch-editor has a hardcoded list of known TUI editors:
case "$EDITOR" in
nvim | vim | nano | micro | hx | helix)
exec omarchy-launch-tui "$EDITOR" "$@"
;;
*)
exec setsid uwsm-app -- "$EDITOR" "$@"
;;
esacSince fresh is not in the list, it falls through to the GUI editor path which silently fails.
Proposed fix
Add fresh to the list of recognized TUI editors, similar to how helix was added in #1740.
Suggestion for future improvement
Rather than maintaining a hardcoded allowlist of TUI editors, consider:
- A user-configurable list (e.g.,
OMARCHY_TUI_EDITORSenv var) - Inverting the logic to have a list of known GUI editors instead (smaller list)
- Auto-detection of whether a command requires a TTY
This would prevent similar issues for users of other terminal editors.
Metadata
Metadata
Assignees
Labels
No labels