Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 4cb249a

Browse files
authored
docs(pip_parse): Update docs about experimental_requirement_cycles (#1588)
This PR updates the docs for #1166 since there were some inconsistencies about the naming (`experimental_requirement_cycles` vs `requirement_cycles`). Also moved the entry in the changelog from `0.27` to `Unreleased` since it missed `0.27`. Can't wait for this feature to land!
1 parent 900d801 commit 4cb249a

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

CHANGELOG.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,12 @@ A brief description of the categories of changes:
2525
rules_python Starlark implementation, not the one built into Bazel. NOTE: This
2626
only applies to Bazel 6+; Bazel 5 still uses the builtin implementation.
2727

28+
* (pip_parse) The parameter `experimental_requirement_cycles` may be provided a
29+
map of names to lists of requirements which form a dependency
30+
cycle. `pip_parse` will break the cycle for you transparently. This behavior
31+
is also available under bzlmod as
32+
`pip.parse(experimental_requirement_cycles={})`.
33+
2834
[0.XX.0]: https://github.com/bazelbuild/rules_python/releases/tag/0.XX.0
2935

3036
## [0.27.0] - 2023-11-16
@@ -59,11 +65,6 @@ A brief description of the categories of changes:
5965
`data`. Note, that the `@pypi_foo//:pkg` labels are still present for
6066
backwards compatibility.
6167

62-
* (pip_parse) The parameter `requirement_cycles` may be provided a map of names
63-
to lists of requirements which form a dependency cycle. `pip_parse` will break
64-
the cycle for you transparently. This behavior is also available under bzlmod
65-
as `pip.parse(requirement_cycles={})`.
66-
6768
* (gazelle) The flag `use_pip_repository_aliases` is now set to `True` by
6869
default, which will cause `gazelle` to change third-party dependency labels
6970
from `@pip_foo//:pkg` to `@pip//foo` by default.

docs/sphinx/pypi-dependencies.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -161,14 +161,15 @@ ERROR: .../external/pypi_sphinxcontrib_serializinghtml/BUILD.bazel:44:6: in alia
161161
`-- @pypi_sphinxcontrib_serializinghtml//:pkg (...)
162162
```
163163

164-
The `requirement_cycles` argument allows you to work around these issues by
165-
specifying groups of packages which form cycles. `pip_parse` will transparently
166-
fix the cycles for you and provide the cyclic dependencies simultaneously.
164+
The `experimental_requirement_cycles` argument allows you to work around these
165+
issues by specifying groups of packages which form cycles. `pip_parse` will
166+
transparently fix the cycles for you and provide the cyclic dependencies
167+
simultaneously.
167168

168169
```
169170
pip_parse(
170171
...
171-
requirement_cycles = {
172+
experimental_requirement_cycles = {
172173
"sphinx": [
173174
"sphinx",
174175
"sphinxcontrib-serializinghtml",
@@ -185,7 +186,7 @@ be a part of the `airflow` cycle. For instance --
185186
```
186187
pip_parse(
187188
...
188-
requirement_cycles = {
189+
experimental_requirement_cycles = {
189190
"airflow": [
190191
"apache-airflow",
191192
"apache-airflow-providers-common-sql",

0 commit comments

Comments
 (0)