Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.4.0-rc2
Choose a base ref
...
head repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.4.0-rc3
Choose a head ref
  • 3 commits
  • 22 files changed
  • 1 contributor

Commits on Apr 29, 2025

  1. revert(pypi): bring back Python PEP508 code with tests (#2831) 

    This just adds the code back at the original state before the following
PRs have been made to remove them: #2629, #2781. This has not been
hooked up yet in `evaluate_markers` and `whl_library` yet and I'll need
extra PRs to do that.

No CHANGELOG entries for now, will be done once the integration is back.

Work towards #2830

(cherry picked from commit 61c91fe)
    @aignas
    aignas committed Apr 29, 2025
    Configuration menu
    Copy the full SHA
    3209c66 View commit details
    Browse the repository at this point in the history

  2. fix(pypi) backport python_full_version fix to Python (#2833) 

    Handling of `python_full_version` correctly has been fixed in the
Starlark
implementation in #2793 and in this PR I am backporting the changes to
handle
the full python version target platform strings so that we can have the
same
behaviour for now.

At the same time I have simplified and got rid of the specialization
handling
in the Python algorithm just like I did in the starlark, which
simplifies the
tests and makes the algorithm more correct.

Summary:
* Handle `cp3x.y_os_arch` strings in the `platform.py`
* Produce correct strings when the `micro_version` is unset. Note, that
we use version `0` in evaluating but we use the default version in the
config setting. This is to keep compatibility with the current behaviour
when the target platform is not fully specified (which would be the case
for WORKSPACE users).
* Adjust the tests and the code to be more similar to the starlark impl.

Work towards #2830

(cherry picked from commit 9e613d5)
    @aignas
    aignas committed Apr 29, 2025
    Configuration menu
    Copy the full SHA
    46ff357 View commit details
    Browse the repository at this point in the history

  3. revert(pypi): use Python for marker eval and METADATA parsing (#2834) 

    Summary:
- Revert to using Python for marker evaluation during parsing of
  requirements (partial revert of #2692).
- Use Python to parse whl METADATA.
- Bugfix the new simpler algorithm and add a new unit test.

Fixes #2830

(cherry picked from commit 5b9d545)
    @aignas
    aignas committed Apr 29, 2025
    Configuration menu
    Copy the full SHA
    4dc0665 View commit details
    Browse the repository at this point in the history
Loading