Improve for support for Android < 8.0 (Fix NoClassDefFoundError)#356
Merged
bbottema merged 1 commit intobbottema:developfrom Dec 24, 2021
Merged
Improve for support for Android < 8.0 (Fix NoClassDefFoundError)#356bbottema merged 1 commit intobbottema:developfrom
bbottema merged 1 commit intobbottema:developfrom
Conversation
Owner
|
These methods are used from a lot of places actually. For example Other than that I think it's generally a good idea to separate these methods out to a FileUtil. |
Contributor
Author
|
Yes exactly :) |
Owner
|
Released in 6.7.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
java.nio.fileis only available starting at android API level 26 (= Android 8.0), see https://developer.android.com/reference/java/nio/file/package-summary.According to Google, 17,3% of all android phones currently (December 2021) in use are below Android version 8.0.
Note that java.nio.channels and java.nio.charsets are available since Android API level 1 (= Android 1.0).
Moving the usages of java.io.file into an own class omits a
java.lang.NoClassDefFoundErrorduring runtime. Previously this error gets thrown when MicsUtil was first loaded from classpath (e.g. when using MiscUtil.valueNullOrEmpty() in Email.java). Now with this PR all java.nio.file imports happen only in one file, which is not loaded during runtime when not using the CLI (which you most probably don't do on Android).