Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Subject/object construction never updated #3

Description

@amansani

Hello, Thanks for writing this code. It gives us basic idea to start working with KG.

In knowledgegraph.py file, once we enter the processSubjectObjectPairs(tokens) function, you are assigning empty string to subjectConstruction and objectConstruction variables. After that there is no update of value to that variable, to update we need to pass "if subjectConstruction" or "if objectConstruction" conditions. But the values to those variables are empty strings, so we can never pass that condition to update those values. Can you please fix it? Thanks.

if isConstructionCandidate(token):
if subjectConstruction:
subjectConstruction = appendChunk(subjectConstruction, token.text)
if objectConstruction:
objectConstruction = appendChunk(objectConstruction, token.text)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions