From ef89688a501033cde7843b14b021415563155509 Mon Sep 17 00:00:00 2001 From: Mitchell Henke Date: Sat, 7 Nov 2015 14:41:22 -0600 Subject: [PATCH 1/2] unused variables --- lib/jsonapi.ex | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/jsonapi.ex b/lib/jsonapi.ex index 29d1d944..a34abbac 100644 --- a/lib/jsonapi.ex +++ b/lib/jsonapi.ex @@ -53,7 +53,7 @@ defmodule JSONAPI do {Dict.put(doc, :data, data), included} end - defp as_relationship(nil, mod), do: nil + defp as_relationship(nil, _mod), do: nil defp as_relationship([], _mod), do: [] defp as_relationship(data, mod) when is_list(data) do Enum.map(data, &(as_relationship(&1, mod))) @@ -99,8 +99,6 @@ defmodule JSONAPI do end assoc_data = Map.get(data, key) - rel_data = nil - rel_data = if loaded?(assoc_data) do as_relationship(assoc_data, view) else From 77716e2aa08d7c8aa435234d476fcaddc0f22c21 Mon Sep 17 00:00:00 2001 From: Mitchell Henke Date: Sat, 7 Nov 2015 14:55:22 -0600 Subject: [PATCH 2/2] make ecto optional --- mix.exs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mix.exs b/mix.exs index dce85963..ca9251ba 100644 --- a/mix.exs +++ b/mix.exs @@ -31,7 +31,7 @@ defmodule JSONAPI.Mixfile do defp deps do [ {:phoenix, "~> 0.13 or ~> 1.0"}, - {:ecto, "~> 0.11 or ~> 1.0"}, + {:ecto, "~> 0.11 or ~> 1.0", optional: true}, {:ex_doc, "~> 0.7", only: :dev}, {:earmark, ">= 0.0.0", only: :dev} ]