cleaning up: key & value can never be null in ExtractAttributes

Licshee · Licshee · commit fbe070a62c62 · 2017-05-03T05:46:32.000+08:00
diff --git a/Source/HtmlRenderer/Core/Parse/HtmlParser.cs b/Source/HtmlRenderer/Core/Parse/HtmlParser.cs
@@ -246,7 +246,7 @@ private static void ExtractAttributes(string source, int idx, int length, out Di
                         value = HtmlUtils.DecodeHtml(value);
                     }
 
-                    if (!string.IsNullOrEmpty(key) && (value != null))
+                    if (key.Length != 0)
                     {
                         if (attributes == null)
                             attributes = new Dictionary<string, string>(StringComparer.InvariantCultureIgnoreCase);

Original file line number	Diff line number	Diff line change
`@@ -246,7 +246,7 @@ private static void ExtractAttributes(string source, int idx, int length, out Di`
`246`	`246`	`value = HtmlUtils.DecodeHtml(value);`
`247`	`247`	`}`
`248`	`248`
`249`		`- if (!string.IsNullOrEmpty(key) && (value != null))`
	`249`	`+ if (key.Length != 0)`
`250`	`250`	`{`
`251`	`251`	`if (attributes == null)`
`252`	`252`	`attributes = new Dictionary<string, string>(StringComparer.InvariantCultureIgnoreCase);`