From e5a17d36014aa59a0d8d0f95c1dc977657938f01 Mon Sep 17 00:00:00 2001
From: e_arome <emmanuel@deriv.com>
Date: Fri, 9 Jul 2021 10:15:58 +0200
Subject: [PATCH 1/3] Hotfix for DMT5 page OG

---
 src/pages/dmt5-trading-signals/index.js | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/src/pages/dmt5-trading-signals/index.js b/src/pages/dmt5-trading-signals/index.js
index 405ffcbb6dd..efa740500d0 100644
--- a/src/pages/dmt5-trading-signals/index.js
+++ b/src/pages/dmt5-trading-signals/index.js
@@ -1,4 +1,4 @@
-import React from 'react'
+import React, { useEffect, useState } from 'react'
 import styled from 'styled-components'
 import { Hero, SmallContainer } from './_style'
 import HowTo from './_how-to'
@@ -102,10 +102,14 @@ const Separator = styled.div`
 
 const DMT5TradingSignals = () => {
     const [active_tab, setActiveTab] = useTabState(['signal-subscriber', 'signal-provider'])
-
+    const [is_mounted, setMounted] = useState(false) //needs to fix bug with hightlight of the 1st loading
+    useEffect(() => {
+        setMounted(true)
+    }, [])
+  
     return (
         <Layout>
-            <SEO description={localize('Deriv MT5 signals')} title={localize('DMT5 Signals')} />
+            <SEO description={localize('Subscribe to Deriv MetaTrader 5 trading signals to copy the trades of experienced traders, or become a signal provider and share your strategies.')} title={localize('Deriv MetaTrader 5 trading signals | Resources | Deriv')} />
             <Hero jc="cneter" ai="center">
                 <SmallContainer>
                     <Header as="h1" type="display-title" color="white" align="center">
@@ -114,20 +118,20 @@ const DMT5TradingSignals = () => {
                 </SmallContainer>
             </Hero>
             <TabsContainer>
-                <Item
+                {is_mounted && <Item
                     onClick={() => setActiveTab('signal-subscriber')}
                     active_tab={active_tab}
                     name="signal-subscriber"
                 >
                     <Header as="h4">{localize('Signal subscriber')}</Header>
-                </Item>
-                <Item
+                </Item>}
+                {is_mounted && <Item
                     onClick={() => setActiveTab('signal-provider')}
                     active_tab={active_tab}
                     name="signal-provider"
                 >
                     <Header as="h4">{localize('Signal provider')}</Header>
-                </Item>
+                </Item>}
             </TabsContainer>
             <Box position="relative">
                 <Separator />

From a7bfbec56b44a4c632886c44391d4953a8dbf50a Mon Sep 17 00:00:00 2001
From: e_arome <emmanuel@deriv.com>
Date: Mon, 12 Jul 2021 09:06:13 +0200
Subject: [PATCH 2/3] DMT5 og Hotfix

---
 src/pages/dmt5-trading-signals/index.js | 41 +++++++++++++++----------
 1 file changed, 25 insertions(+), 16 deletions(-)

diff --git a/src/pages/dmt5-trading-signals/index.js b/src/pages/dmt5-trading-signals/index.js
index efa740500d0..ff6207c17ef 100644
--- a/src/pages/dmt5-trading-signals/index.js
+++ b/src/pages/dmt5-trading-signals/index.js
@@ -106,10 +106,15 @@ const DMT5TradingSignals = () => {
     useEffect(() => {
         setMounted(true)
     }, [])
-  
+
     return (
         <Layout>
-            <SEO description={localize('Subscribe to Deriv MetaTrader 5 trading signals to copy the trades of experienced traders, or become a signal provider and share your strategies.')} title={localize('Deriv MetaTrader 5 trading signals | Resources | Deriv')} />
+            <SEO
+                description={localize(
+                    'Subscribe to Deriv MetaTrader 5 trading signals to copy the trades of experienced traders, or become a signal provider and share your strategies.',
+                )}
+                title={localize('Deriv MetaTrader 5 trading signals | Resources | Deriv')}
+            />
             <Hero jc="cneter" ai="center">
                 <SmallContainer>
                     <Header as="h1" type="display-title" color="white" align="center">
@@ -118,20 +123,24 @@ const DMT5TradingSignals = () => {
                 </SmallContainer>
             </Hero>
             <TabsContainer>
-                {is_mounted && <Item
-                    onClick={() => setActiveTab('signal-subscriber')}
-                    active_tab={active_tab}
-                    name="signal-subscriber"
-                >
-                    <Header as="h4">{localize('Signal subscriber')}</Header>
-                </Item>}
-                {is_mounted && <Item
-                    onClick={() => setActiveTab('signal-provider')}
-                    active_tab={active_tab}
-                    name="signal-provider"
-                >
-                    <Header as="h4">{localize('Signal provider')}</Header>
-                </Item>}
+                {is_mounted && (
+                    <Item
+                        onClick={() => setActiveTab('signal-subscriber')}
+                        active_tab={active_tab}
+                        name="signal-subscriber"
+                    >
+                        <Header as="h4">{localize('Signal subscriber')}</Header>
+                    </Item>
+                )}
+                {is_mounted && (
+                    <Item
+                        onClick={() => setActiveTab('signal-provider')}
+                        active_tab={active_tab}
+                        name="signal-provider"
+                    >
+                        <Header as="h4">{localize('Signal provider')}</Header>
+                    </Item>
+                )}
             </TabsContainer>
             <Box position="relative">
                 <Separator />

From 9b64a05253dfa2127fbca58acebcb97b2ae7c9e0 Mon Sep 17 00:00:00 2001
From: e_arome <emmanuel@deriv.com>
Date: Mon, 12 Jul 2021 14:14:26 +0200
Subject: [PATCH 3/3] OG DMT5 hotfix

---
 src/pages/dmt5-trading-signals/index.js | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/pages/dmt5-trading-signals/index.js b/src/pages/dmt5-trading-signals/index.js
index ff6207c17ef..3bd7313719d 100644
--- a/src/pages/dmt5-trading-signals/index.js
+++ b/src/pages/dmt5-trading-signals/index.js
@@ -12,6 +12,12 @@ import { Header } from 'components/elements'
 import { useTabState } from 'components/hooks/use-tab-state'
 import device from 'themes/device'
 
+const meta_attributes = {
+    og_title: localize('Deriv MetaTrader 5 trading signals | Resources | Deriv'),
+    og_description: localize(
+        'Subscribe to Deriv MetaTrader 5 trading signals to copy the trades of experienced traders, or become a signal provider and share your strategies.',
+    ),
+}
 const signal_content_subscriber = {
     header: (
         <Localize
@@ -114,6 +120,7 @@ const DMT5TradingSignals = () => {
                     'Subscribe to Deriv MetaTrader 5 trading signals to copy the trades of experienced traders, or become a signal provider and share your strategies.',
                 )}
                 title={localize('Deriv MetaTrader 5 trading signals | Resources | Deriv')}
+                meta_attributes={meta_attributes}
             />
             <Hero jc="cneter" ai="center">
                 <SmallContainer>