From 6f6142580c50d52f5f87ecea5c97eed124ef8a12 Mon Sep 17 00:00:00 2001 From: Nikolai Berestevich Date: Fri, 30 Jul 2021 11:26:30 +0300 Subject: [PATCH 1/2] nikolai.berestevich/refactor/ alt tag delete on about us pages --- src/pages/besquare/components/helper/_card.js | 8 +--- src/pages/besquare/static/content/_join-us.js | 4 -- .../careers/_employee-testimonial-carousel.js | 17 ++------ src/pages/careers/_our-values.js | 8 ++-- src/pages/careers/locations/index.js | 4 +- src/pages/contact_us/_contact-ways.js | 6 +-- src/pages/contact_us/_offices.js | 42 ++++++++----------- src/pages/leadership/_leaders.js | 4 +- src/pages/partners/_why-choose-us.js | 6 +-- 9 files changed, 34 insertions(+), 65 deletions(-) diff --git a/src/pages/besquare/components/helper/_card.js b/src/pages/besquare/components/helper/_card.js index b4e857688fd..3fbcbc33927 100644 --- a/src/pages/besquare/components/helper/_card.js +++ b/src/pages/besquare/components/helper/_card.js @@ -18,7 +18,7 @@ const Card = ({ card_content, custom_icon, has_list, style, title_component }) = (is_list_open ? 'Minimize' : 'Maximize')} icon`} + alt="" width="32" height="32" /> @@ -49,11 +49,7 @@ const Card = ({ card_content, custom_icon, has_list, style, title_component }) = const { card_wrapper, icon_wrapper, text_wrapper } = style return ( - + {title_component && title_component} {card_content.text} {has_list && getCurrentDropdownComponent()} diff --git a/src/pages/besquare/static/content/_join-us.js b/src/pages/besquare/static/content/_join-us.js index 1e5c041b22b..e459d46e1dc 100644 --- a/src/pages/besquare/static/content/_join-us.js +++ b/src/pages/besquare/static/content/_join-us.js @@ -11,7 +11,6 @@ export default { content: [ { src: TechExperienceIcon, - alt: 'tech experience icon', text: ( <> Hands-on tech experience by learning directly from all our @@ -21,7 +20,6 @@ export default { }, { src: ExtensiveNetworkIcon, - alt: 'extensive network icon', text: ( <> An extensive network of professionals, guest speakers, and @@ -31,7 +29,6 @@ export default { }, { src: ProfessionalGuidanceIcon, - alt: 'professional guidance icon', text: ( <> Professional guidance that helps you set clear career goals to @@ -41,7 +38,6 @@ export default { }, { src: ResumeIcon, - alt: 'tech experience icon', text: ( <> An enriched résumé with tech and non-tech skills that set you diff --git a/src/pages/careers/_employee-testimonial-carousel.js b/src/pages/careers/_employee-testimonial-carousel.js index d76811affce..83fafadef35 100644 --- a/src/pages/careers/_employee-testimonial-carousel.js +++ b/src/pages/careers/_employee-testimonial-carousel.js @@ -74,20 +74,14 @@ const QuoteWrapper = styled(Flex)` top: 16px; } ` -const EmployeeSlide = ({ quote, img_path, img_alt, name }) => { +const EmployeeSlide = ({ quote, img_path, name }) => { return ( - {img_alt} + @@ -102,7 +96,6 @@ const EmployeeSlide = ({ quote, img_path, img_alt, name }) => { } EmployeeSlide.propTypes = { - img_alt: PropTypes.string, img_path: PropTypes.string, name: PropTypes.string, quote: PropTypes.string, @@ -111,28 +104,24 @@ EmployeeSlide.propTypes = { const ahmad = { name: 'Ahmad Aizuddin, Disaster Recovery Analyst', - img_alt: 'Ahmad - Recovery Analyst', img_path: AhmadImage, quote: `One of the things I like best about working here is how we’re encouraged to take ownership of our tasks and goals. The autonomy and trust by the leadership team motivate me to excel in my role.`, index: 2, } const aditya = { name: 'Lalitaditya Addanki, DevOps Engineer', - img_alt: 'Lalitaditya - DevOps Engineer', img_path: AdityaImage, quote: `The best thing about my peers is that they are highly talented and skilled. Problem-solving and brainstorming with my team is fun, and they provide a great support structure. I’m able to produce higher quality work than what I would have achieved on my own.`, index: 3, } const mei_theng = { name: 'Wong Mei Theng, Accounting Operations Lead', - img_alt: 'Mei Theng - Accounting Operations Lead', img_path: MeiThengImage, quote: `I love the people I work with, and the company culture that we share. Everyone contributes to a positive working environment by having fun together during the ups and shouldering the burden together during the downs.`, index: 4, } const gary = { name: 'Gary Ross Vytialingam, Chief Risk Officer', - img_alt: 'Gary - Chief Risk Officer', img_path: GaryImage, quote: `We encourage knowledge sharing at all levels, so I learn from the people I work with every day. Our company is enriched by the diversity of talented individuals from over 40 countries. It’s inspiring to be a leader of these motivated team players at Deriv.`, index: 5, @@ -177,7 +166,7 @@ const EmployeeTestimonialCarousel = () => { quote={employee_slide.quote} name={employee_slide.name} img_path={employee_slide.img_path} - img_alt={employee_slide.img_alt} + img_alt="" /> ))} diff --git a/src/pages/careers/_our-values.js b/src/pages/careers/_our-values.js index 6fd57e902ee..b6342540a21 100644 --- a/src/pages/careers/_our-values.js +++ b/src/pages/careers/_our-values.js @@ -44,7 +44,7 @@ const OurValues = () => ( mobile_columns="38.4rem" > - integrity + Integrity @@ -55,7 +55,7 @@ const OurValues = () => ( - customer + Customer focus @@ -65,7 +65,7 @@ const OurValues = () => ( - competence + Competence @@ -75,7 +75,7 @@ const OurValues = () => ( - teamwork + Teamwork diff --git a/src/pages/careers/locations/index.js b/src/pages/careers/locations/index.js index 99694c37f8b..b5be323f374 100644 --- a/src/pages/careers/locations/index.js +++ b/src/pages/careers/locations/index.js @@ -91,13 +91,13 @@ const CountryCardWrapper = styled(StyledCard)` const CountryCard = ({ country_name, city_name, link, img_data, Icon }) => { return ( - +
{city_name}
- + {country_name} diff --git a/src/pages/contact_us/_contact-ways.js b/src/pages/contact_us/_contact-ways.js index 188c67c2256..4cc5e1a11cf 100644 --- a/src/pages/contact_us/_contact-ways.js +++ b/src/pages/contact_us/_contact-ways.js @@ -117,11 +117,7 @@ const ContactWays = () => { return ( - +
diff --git a/src/pages/contact_us/_offices.js b/src/pages/contact_us/_offices.js index c3ccd0dcf10..ed114847012 100644 --- a/src/pages/contact_us/_offices.js +++ b/src/pages/contact_us/_offices.js @@ -184,7 +184,7 @@ export const Offices = () => {
- malta +
{localize('Malta')} @@ -199,11 +199,7 @@ export const Offices = () => { target="_blank" rel="noopener noreferrer" > - + {
- dubai +
{localize('Dubai')} @@ -239,11 +235,7 @@ export const Offices = () => { target="_blank" rel="noopener noreferrer" > - + {
- malaysia +
{localize('Malaysia')} @@ -281,7 +273,7 @@ export const Offices = () => { rel="noopener noreferrer" > @@ -312,7 +304,7 @@ export const Offices = () => { rel="noopener noreferrer" > @@ -343,7 +335,7 @@ export const Offices = () => { rel="noopener noreferrer" > @@ -374,7 +366,7 @@ export const Offices = () => { rel="noopener noreferrer" > @@ -401,7 +393,7 @@ export const Offices = () => {
- paraguay +
{localize('Paraguay')} @@ -416,7 +408,7 @@ export const Offices = () => { rel="noopener noreferrer" > @@ -441,7 +433,7 @@ export const Offices = () => {
- cyprus +
{localize('Cyprus')} @@ -456,7 +448,7 @@ export const Offices = () => { rel="noopener noreferrer" > @@ -479,7 +471,7 @@ export const Offices = () => {
- rwanda +
{localize('Rwanda')} @@ -494,7 +486,7 @@ export const Offices = () => { rel="noopener noreferrer" > @@ -517,7 +509,7 @@ export const Offices = () => {
- belarus +
{localize('Belarus')} @@ -532,7 +524,7 @@ export const Offices = () => { rel="noopener noreferrer" > diff --git a/src/pages/leadership/_leaders.js b/src/pages/leadership/_leaders.js index 4371fe9e4a6..3077bc29b48 100644 --- a/src/pages/leadership/_leaders.js +++ b/src/pages/leadership/_leaders.js @@ -309,7 +309,7 @@ const Leaders = () => { {leaders_data.map((leader, index) => ( - + {leader.description} @@ -331,7 +331,7 @@ const Leaders = () => { - +
diff --git a/src/pages/partners/_why-choose-us.js b/src/pages/partners/_why-choose-us.js index 4001cd99716..c4717b98d3b 100644 --- a/src/pages/partners/_why-choose-us.js +++ b/src/pages/partners/_why-choose-us.js @@ -48,7 +48,7 @@ const WhyChooseUs = () => {
- +
{localize('Partnership with a trusted pioneer')}
@@ -59,7 +59,7 @@ const WhyChooseUs = () => {
- +
{localize('Diverse opportunities')}
@@ -70,7 +70,7 @@ const WhyChooseUs = () => {
- +
{localize('No charges or hidden fees')}
From b2b98bc90a2eec9651d355a467b4dac47079f722 Mon Sep 17 00:00:00 2001 From: Nikolai Berestevich Date: Mon, 2 Aug 2021 17:08:53 +0300 Subject: [PATCH 2/2] nikolai.berestevich/refactor/change-alt-tags-about us --- .../careers/_employee-testimonial-carousel.js | 17 +++++++++-- src/pages/careers/locations/index.js | 2 +- src/pages/contact_us/_contact-ways.js | 6 +++- src/pages/contact_us/_offices.js | 28 ++++++++++++------- src/pages/leadership/_leaders.js | 4 +-- 5 files changed, 40 insertions(+), 17 deletions(-) diff --git a/src/pages/careers/_employee-testimonial-carousel.js b/src/pages/careers/_employee-testimonial-carousel.js index 83fafadef35..d76811affce 100644 --- a/src/pages/careers/_employee-testimonial-carousel.js +++ b/src/pages/careers/_employee-testimonial-carousel.js @@ -74,14 +74,20 @@ const QuoteWrapper = styled(Flex)` top: 16px; } ` -const EmployeeSlide = ({ quote, img_path, name }) => { +const EmployeeSlide = ({ quote, img_path, img_alt, name }) => { return ( - + {img_alt} @@ -96,6 +102,7 @@ const EmployeeSlide = ({ quote, img_path, name }) => { } EmployeeSlide.propTypes = { + img_alt: PropTypes.string, img_path: PropTypes.string, name: PropTypes.string, quote: PropTypes.string, @@ -104,24 +111,28 @@ EmployeeSlide.propTypes = { const ahmad = { name: 'Ahmad Aizuddin, Disaster Recovery Analyst', + img_alt: 'Ahmad - Recovery Analyst', img_path: AhmadImage, quote: `One of the things I like best about working here is how we’re encouraged to take ownership of our tasks and goals. The autonomy and trust by the leadership team motivate me to excel in my role.`, index: 2, } const aditya = { name: 'Lalitaditya Addanki, DevOps Engineer', + img_alt: 'Lalitaditya - DevOps Engineer', img_path: AdityaImage, quote: `The best thing about my peers is that they are highly talented and skilled. Problem-solving and brainstorming with my team is fun, and they provide a great support structure. I’m able to produce higher quality work than what I would have achieved on my own.`, index: 3, } const mei_theng = { name: 'Wong Mei Theng, Accounting Operations Lead', + img_alt: 'Mei Theng - Accounting Operations Lead', img_path: MeiThengImage, quote: `I love the people I work with, and the company culture that we share. Everyone contributes to a positive working environment by having fun together during the ups and shouldering the burden together during the downs.`, index: 4, } const gary = { name: 'Gary Ross Vytialingam, Chief Risk Officer', + img_alt: 'Gary - Chief Risk Officer', img_path: GaryImage, quote: `We encourage knowledge sharing at all levels, so I learn from the people I work with every day. Our company is enriched by the diversity of talented individuals from over 40 countries. It’s inspiring to be a leader of these motivated team players at Deriv.`, index: 5, @@ -166,7 +177,7 @@ const EmployeeTestimonialCarousel = () => { quote={employee_slide.quote} name={employee_slide.name} img_path={employee_slide.img_path} - img_alt="" + img_alt={employee_slide.img_alt} />
))} diff --git a/src/pages/careers/locations/index.js b/src/pages/careers/locations/index.js index b5be323f374..3357ea9cb5e 100644 --- a/src/pages/careers/locations/index.js +++ b/src/pages/careers/locations/index.js @@ -91,7 +91,7 @@ const CountryCardWrapper = styled(StyledCard)` const CountryCard = ({ country_name, city_name, link, img_data, Icon }) => { return ( - +
{city_name} diff --git a/src/pages/contact_us/_contact-ways.js b/src/pages/contact_us/_contact-ways.js index 4cc5e1a11cf..188c67c2256 100644 --- a/src/pages/contact_us/_contact-ways.js +++ b/src/pages/contact_us/_contact-ways.js @@ -117,7 +117,11 @@ const ContactWays = () => { return ( - +
diff --git a/src/pages/contact_us/_offices.js b/src/pages/contact_us/_offices.js index ed114847012..64e6035f152 100644 --- a/src/pages/contact_us/_offices.js +++ b/src/pages/contact_us/_offices.js @@ -199,7 +199,11 @@ export const Offices = () => { target="_blank" rel="noopener noreferrer" > - + { target="_blank" rel="noopener noreferrer" > - + { rel="noopener noreferrer" > @@ -304,7 +312,7 @@ export const Offices = () => { rel="noopener noreferrer" > @@ -335,7 +343,7 @@ export const Offices = () => { rel="noopener noreferrer" > @@ -366,7 +374,7 @@ export const Offices = () => { rel="noopener noreferrer" > @@ -408,7 +416,7 @@ export const Offices = () => { rel="noopener noreferrer" > @@ -448,7 +456,7 @@ export const Offices = () => { rel="noopener noreferrer" > @@ -486,7 +494,7 @@ export const Offices = () => { rel="noopener noreferrer" > @@ -524,7 +532,7 @@ export const Offices = () => { rel="noopener noreferrer" > diff --git a/src/pages/leadership/_leaders.js b/src/pages/leadership/_leaders.js index 3077bc29b48..4371fe9e4a6 100644 --- a/src/pages/leadership/_leaders.js +++ b/src/pages/leadership/_leaders.js @@ -309,7 +309,7 @@ const Leaders = () => { {leaders_data.map((leader, index) => ( - + {leader.description} @@ -331,7 +331,7 @@ const Leaders = () => { - +