From 50fccf0c21550725b45ec25e6a4432362c041ca0 Mon Sep 17 00:00:00 2001 From: Sean Ho Date: Mon, 24 Jan 2022 17:10:27 +0800 Subject: [PATCH 1/5] fix: preact missing images --- .../careers/_employee-testimonial-carousel.tsx | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/pages/careers/_employee-testimonial-carousel.tsx b/src/pages/careers/_employee-testimonial-carousel.tsx index 01be056354a..0b7d93d5bbb 100644 --- a/src/pages/careers/_employee-testimonial-carousel.tsx +++ b/src/pages/careers/_employee-testimonial-carousel.tsx @@ -79,6 +79,11 @@ const QuoteWrapper = styled(Flex)` top: 16px; } ` +const StyledImg = styled.img` + width: 100%; + height: 100%; +` + const EmployeeSlide = ({ quote, img_path, img_alt, name }) => { return ( @@ -86,13 +91,7 @@ const EmployeeSlide = ({ quote, img_path, img_alt, name }) => { - {img_alt} + From 07c57b66317e6073ce7b25b0225e517b594a3c57 Mon Sep 17 00:00:00 2001 From: Sean Ho Date: Mon, 24 Jan 2022 18:19:25 +0800 Subject: [PATCH 2/5] fix: copywriting --- src/pages/academy/common/_constants.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/academy/common/_constants.ts b/src/pages/academy/common/_constants.ts index b1e1f587557..8b7d69a03f0 100644 --- a/src/pages/academy/common/_constants.ts +++ b/src/pages/academy/common/_constants.ts @@ -10,7 +10,7 @@ export type TopicType = { // academy topic export const market_type: TopicType[] = [ { - type: 'Market', + type: 'Markets', items: [ { title: 'Forex', @@ -33,7 +33,7 @@ export const market_type: TopicType[] = [ export const platforms: TopicType[] = [ { - type: 'Platform', + type: 'Platforms', items: [ { title: 'Deriv MT5', From 9c4b88ca73950fe5ddda145911f06511d58aeff0 Mon Sep 17 00:00:00 2001 From: Sean Ho Date: Mon, 24 Jan 2022 18:22:01 +0800 Subject: [PATCH 3/5] fix: copywriting --- src/pages/academy/common/_constants.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/academy/common/_constants.ts b/src/pages/academy/common/_constants.ts index 8b7d69a03f0..9e050440f0d 100644 --- a/src/pages/academy/common/_constants.ts +++ b/src/pages/academy/common/_constants.ts @@ -48,7 +48,7 @@ export const platforms: TopicType[] = [ title: 'DBot', }, { - title: 'Deriv Go', + title: 'Deriv GO', }, ], }, From a5abfc8f83b7ad2b726ba73da2c71674ece0af5f Mon Sep 17 00:00:00 2001 From: Sean Ho Date: Mon, 24 Jan 2022 18:24:36 +0800 Subject: [PATCH 4/5] fix: add deriv go special case: --- src/pages/academy/search/index.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/pages/academy/search/index.tsx b/src/pages/academy/search/index.tsx index 0dd15fe0add..dc9629a0d9a 100644 --- a/src/pages/academy/search/index.tsx +++ b/src/pages/academy/search/index.tsx @@ -303,6 +303,8 @@ const SearchPage = () => { return 'DTrader' case 'deriv-mt5': return 'Deriv MT5' + case 'deriv-go': + return 'Deriv GO' default: return unslugify(category_type) } From 105203dc55662b29a191577a4395cfea1f835b6f Mon Sep 17 00:00:00 2001 From: Sean Ho Date: Mon, 24 Jan 2022 18:29:09 +0800 Subject: [PATCH 5/5] fix: preact missing images --- src/pages/academy/components/_social-sharing.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/pages/academy/components/_social-sharing.js b/src/pages/academy/components/_social-sharing.js index 25fed8e02c7..0810e055137 100644 --- a/src/pages/academy/components/_social-sharing.js +++ b/src/pages/academy/components/_social-sharing.js @@ -53,7 +53,7 @@ const SocialSharing = () => { target="_blank" rel="noopener noreferrer" > - + { target="_blank" rel="noopener noreferrer" > - + { target="_blank" rel="noopener noreferrer" > - + { target="_blank" rel="noopener noreferrer" > - +