Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

chrislee35
Copy link
Contributor

Updated to yfinance > 0.2.38; tested with 0.2.65

Issue

This fixes issue #291.

yfinance changed its API. I updated datasources.py to the new API.

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

chrislee35 and others added 2 commits July 26, 2025 23:18
@krystofair
Copy link

Hi,
The second commit shouldn't appear here I guess. I'm pretty sure, that this cannot be merged with it.
Do separation for it, and optionally make comment in modified/new PR, that there is patch add-on for timeseries in you fork.

@chrislee35
Copy link
Contributor Author

You're absolutely right. I messed that up and didn't fork it correctly. I will cancel this PR and submit a clean one.

@chrislee35 chrislee35 closed this Aug 12, 2025
@krystofair
Copy link

@chrislee35 You fork it correctly, there is, that you just continue working on branch which was connected to this PR. What should be done, is to open new branch let's say "fix-datasource-yfinance-api":

  1. check logs: git log --oneline --all and copy shorted hash of last commit from biolab:master
    (from main page: c19df2c) so I guess you can skip this step.
  2. create that new branch with start-point that commit git branch fix-datasource-yfinance-api c19df2c
  3. cherry pick commit fixed datasource.py. git cherry-pick f3c7ab6
  4. Push and create PR where you choose that new branch and you can even deleted it from local computer (not a fork repo)

I don't know how you advanced in git, so please don't be angry on me if I told obviousness. 😃

@chrislee35
Copy link
Contributor Author

I tried and now my repo is all broken. My git skills were unable to fix it.

@krystofair
Copy link

krystofair commented Aug 13, 2025

It's not look that bad, I see that you didn't lost your patch. Discord?

@chrislee35
Copy link
Contributor Author

How does this look? #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants