Maven central service should not parse versions as number (badges#3935)

reda-alaoui · calebcartwright · commit 94fdb81d1ca8 · 2019-09-02T12:47:18.000-05:00
diff --git a/services/maven-central/maven-central.service.js b/services/maven-central/maven-central.service.js
@@ -9,9 +9,7 @@ const schema = Joi.object({
     versioning: Joi.object({
       versions: Joi.object({
         version: Joi.array()
-          .items(
-            Joi.alternatives(Joi.string().required(), Joi.number().required())
-          )
+          .items(Joi.string().required())
           .single()
           .required(),
       }).required(),
@@ -71,7 +69,11 @@ module.exports = class MavenCentral extends BaseXmlService {
     const group = encodeURIComponent(groupId).replace(/\./g, '/')
     const artifact = encodeURIComponent(artifactId)
     const url = `https://repo1.maven.org/maven2/${group}/${artifact}/maven-metadata.xml`
-    return this._requestXml({ schema, url })
+    return this._requestXml({
+      schema,
+      url,
+      parserOptions: { parseNodeValue: false },
+    })
   }
 
   async handle({ groupId, artifactId, versionPrefix }) {
diff --git a/services/maven-central/maven-central.tester.js b/services/maven-central/maven-central.tester.js
@@ -26,3 +26,28 @@ t.create('inexistent artifact')
 t.create('inexistent version prefix')
   .get('/com.github.fabriziocucci/yacl4j/99.json')
   .expectBadge({ label: 'maven-central', message: 'version prefix not found' })
+
+t.create('version ending with zero')
+  .get('/mocked-group-id/mocked-artifact-id.json')
+  .intercept(nock =>
+    nock('https://repo1.maven.org/maven2')
+      .get('/mocked-group-id/mocked-artifact-id/maven-metadata.xml')
+      .reply(
+        200,
+        `
+      <metadata>
+        <groupId>mocked-group-id</groupId>
+        <artifactId>mocked-artifact-id</artifactId>
+        <versioning>
+            <latest>1.30</latest>
+            <release>1.30</release>
+            <versions>
+                <version>1.30</version>
+            </versions>
+            <lastUpdated>20190902002617</lastUpdated>
+        </versioning>
+        </metadata>
+      `
+      )
+  )
+  .expectBadge({ label: 'maven-central', message: /^v1\.30$/ })
